javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(frame): improve weakref guards (#9518)

Browse Source
This commit is contained in:
Osei Fortune
2021-08-19 22:15:18 -07:00
committed by GitHub
parent 2f630dc464
commit b7b9d7c259
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/core/ui/frame/index.ios.ts
View File

@@ -404,13 +404,13 @@ class UINavigationControllerImpl extends UINavigationController {
}
get owner(): Frame {
return this._owner.get();
return this._owner.get?.();
}
@profile
public viewWillAppear(animated: boolean): void {
super.viewWillAppear(animated);
const owner = this._owner.get();
const owner = this._owner.get?.();
if (owner && !owner.isLoaded && !owner.parent) {
owner.callLoaded();
}
@@ -419,7 +419,7 @@ class UINavigationControllerImpl extends UINavigationController {
@profile
public viewDidDisappear(animated: boolean): void {
super.viewDidDisappear(animated);
const owner = this._owner.get();
const owner = this._owner.get?.();
if (owner && owner.isLoaded && !owner.parent && !this.presentedViewController) {
owner.callUnloaded();
owner._tearDownUI(true);
@@ -543,7 +543,7 @@ class UINavigationControllerImpl extends UINavigationController {
super.traitCollectionDidChange(previousTraitCollection);
if (majorVersion >= 13) {
const owner = this._owner.get();
const owner = this._owner.get?.();
if (owner && this.traitCollection.hasDifferentColorAppearanceComparedToTraitCollection && this.traitCollection.hasDifferentColorAppearanceComparedToTraitCollection(previousTraitCollection)) {
owner.notify({
eventName: IOSHelper.traitCollectionColorAppearanceChangedEvent,