javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): typings for showModal correction (#9374)

Browse Source
This commit is contained in:
Nathan Walker
2021-05-04 23:27:35 -07:00
committed by GitHub
parent 0d4ccba60a
commit 9ec404225e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/core/ui/core/view-base/index.d.ts vendored
View File

@@ -187,14 +187,14 @@ export abstract class ViewBase extends Observable {
* @param moduleName - The name of the module to load starting from the application root. * @param moduleName - The name of the module to load starting from the application root.
* @param modalOptions - A ShowModalOptions instance * @param modalOptions - A ShowModalOptions instance
*/ */
showModal(moduleName: string, modalOptions: ShowModalOptions): ViewBase; showModal(moduleName: string, modalOptions?: ShowModalOptions): ViewBase;
/** /**
* Shows the view passed as parameter as a modal view. * Shows the view passed as parameter as a modal view.
* @param view - View instance to be shown modally. * @param view - View instance to be shown modally.
* @param modalOptions - A ShowModalOptions instance * @param modalOptions - A ShowModalOptions instance
*/ */
showModal(view: ViewBase, modalOptions: ShowModalOptions): ViewBase; showModal(view: ViewBase, modalOptions?: ShowModalOptions): ViewBase;
/** /**
* Closes the current modal view that this page is showing. * Closes the current modal view that this page is showing.