From 9ec404225ef0cff5f82d759fcdc7b85952e65c0d Mon Sep 17 00:00:00 2001 From: Nathan Walker Date: Tue, 4 May 2021 23:27:35 -0700 Subject: [PATCH] fix(core): typings for showModal correction (#9374) --- packages/core/ui/core/view-base/index.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/core/ui/core/view-base/index.d.ts b/packages/core/ui/core/view-base/index.d.ts index 3675745a4..b64af3aef 100644 --- a/packages/core/ui/core/view-base/index.d.ts +++ b/packages/core/ui/core/view-base/index.d.ts @@ -187,14 +187,14 @@ export abstract class ViewBase extends Observable { * @param moduleName - The name of the module to load starting from the application root. * @param modalOptions - A ShowModalOptions instance */ - showModal(moduleName: string, modalOptions: ShowModalOptions): ViewBase; + showModal(moduleName: string, modalOptions?: ShowModalOptions): ViewBase; /** * Shows the view passed as parameter as a modal view. * @param view - View instance to be shown modally. * @param modalOptions - A ShowModalOptions instance */ - showModal(view: ViewBase, modalOptions: ShowModalOptions): ViewBase; + showModal(view: ViewBase, modalOptions?: ShowModalOptions): ViewBase; /** * Closes the current modal view that this page is showing.