javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(ios): gesture handling resilience when views are destroyed quickly (#8645)

Browse Source 
closes https://github.com/NativeScript/NativeScript/issues/8641
This commit is contained in:
Nathan Walker
2020-06-16 15:18:48 -07:00
committed by GitHub
parent 5cacc25aa7
commit 9afa15fa71
1 changed files with 30 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
nativescript-core/ui/gestures/gestures.ios.ts
View File

@@ -128,55 +128,75 @@ export class GesturesObserver extends GesturesObserverBase {
if (type & GestureTypes.tap) {
nativeView.addGestureRecognizer(this._createRecognizer(GestureTypes.tap, args => {
this._executeCallback(_getTapData(args));
if (args.view) {
this._executeCallback(_getTapData(args));
}
}));
}
if (type & GestureTypes.doubleTap) {
nativeView.addGestureRecognizer(this._createRecognizer(GestureTypes.doubleTap, args => {
this._executeCallback(_getTapData(args));
if (args.view) {
this._executeCallback(_getTapData(args));
}
}));
}
if (type & GestureTypes.pinch) {
nativeView.addGestureRecognizer(this._createRecognizer(GestureTypes.pinch, args => {
this._executeCallback(_getPinchData(args));
if (args.view) {
this._executeCallback(_getPinchData(args));
}
}));
}
if (type & GestureTypes.pan) {
nativeView.addGestureRecognizer(this._createRecognizer(GestureTypes.pan, args => {
this._executeCallback(_getPanData(args, target.nativeViewProtected));
if (args.view) {
this._executeCallback(_getPanData(args, target.nativeViewProtected));
}
}));
}
if (type & GestureTypes.swipe) {
nativeView.addGestureRecognizer(this._createRecognizer(GestureTypes.swipe, args => {
this._executeCallback(_getSwipeData(args));
if (args.view) {
this._executeCallback(_getSwipeData(args));
}
}, UISwipeGestureRecognizerDirection.Down));
nativeView.addGestureRecognizer(this._createRecognizer(GestureTypes.swipe, args => {
this._executeCallback(_getSwipeData(args));
if (args.view) {
this._executeCallback(_getSwipeData(args));
}
}, UISwipeGestureRecognizerDirection.Left));
nativeView.addGestureRecognizer(this._createRecognizer(GestureTypes.swipe, args => {
this._executeCallback(_getSwipeData(args));
if (args.view) {
this._executeCallback(_getSwipeData(args));
}
}, UISwipeGestureRecognizerDirection.Right));
nativeView.addGestureRecognizer(this._createRecognizer(GestureTypes.swipe, args => {
this._executeCallback(_getSwipeData(args));
if (args.view) {
this._executeCallback(_getSwipeData(args));
}
}, UISwipeGestureRecognizerDirection.Up));
}
if (type & GestureTypes.rotation) {
nativeView.addGestureRecognizer(this._createRecognizer(GestureTypes.rotation, args => {
this._executeCallback(_getRotationData(args));
if (args.view) {
this._executeCallback(_getRotationData(args));
}
}));
}
if (type & GestureTypes.longPress) {
nativeView.addGestureRecognizer(this._createRecognizer(GestureTypes.longPress, args => {
this._executeCallback(_getLongPressData(args));
if (args.view) {
this._executeCallback(_getLongPressData(args));
}
}));
}