javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(stack-layout-ios): add warning when measuring unsized scrollable child (#6784)

Browse Source 
* refactor(stack-layout-ios): add warning when measuring unsized scrollable child

* fix typo
This commit is contained in:
Alexander Djenkov
2019-02-06 20:19:30 +02:00
committed by Svetoslav
parent 60c337b6f3
commit 97d878c107
1 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tns-core-modules/ui/layouts/stack-layout/stack-layout.ios.ts
View File

@@ -1,4 +1,5 @@
import { StackLayoutBase, View, layout, VerticalAlignment, HorizontalAlignment } from "./stack-layout-common";
import * as trace from "../../../trace";
export * from "./stack-layout-common";
@@ -51,7 +52,16 @@ export class StackLayout extends StackLayoutBase {
this.eachLayoutChild((child, last) => {
if (isVertical) {
// Measuring ListView, with no height property set, with layout.AT_MOST will
// result in total height equal to the count ot all items multiplied by DEFAULT_HEIGHT = 44 or the
// maximum available space for the StackLayout. Any following controls will be visible only if enough space left.
childSize = View.measureChild(this, child, childMeasureSpec, layout.makeMeasureSpec(remainingLength, measureSpec));
if (measureSpec === layout.AT_MOST && this.isUnsizedScrollableView(child)) {
trace.write("Avoid using ListView or ScrollView with no explicit height set inside StackLayout. Doing so might result in poor user interface performance and poor user experience.", trace.categories.Layout, trace.messageType.warn);
}
measureWidth = Math.max(measureWidth, childSize.measuredWidth);
let viewHeight = childSize.measuredHeight;
measureHeight += viewHeight;
@@ -93,7 +103,7 @@ export class StackLayout extends StackLayoutBase {
}
}
private layoutVertical(left: number, top: number, right: number, bottom: number, insets: {left, top, right, bottom}): void {
private layoutVertical(left: number, top: number, right: number, bottom: number, insets: { left, top, right, bottom }): void {
const paddingLeft = this.effectiveBorderLeftWidth + this.effectivePaddingLeft + insets.left;
const paddingTop = this.effectiveBorderTopWidth + this.effectivePaddingTop + insets.top;
const paddingRight = this.effectiveBorderRightWidth + this.effectivePaddingRight + insets.right;
@@ -127,7 +137,7 @@ export class StackLayout extends StackLayoutBase {
})
}
private layoutHorizontal(left: number, top: number, right: number, bottom: number, insets: {left, top, right, bottom}): void {
private layoutHorizontal(left: number, top: number, right: number, bottom: number, insets: { left, top, right, bottom }): void {
const paddingLeft = this.effectiveBorderLeftWidth + this.effectivePaddingLeft + insets.left;
const paddingTop = this.effectiveBorderTopWidth + this.effectivePaddingTop + insets.top;
const paddingRight = this.effectiveBorderRightWidth + this.effectivePaddingRight + insets.right;
@@ -160,4 +170,12 @@ export class StackLayout extends StackLayoutBase {
childLeft += childWidth;
});
}
private isUnsizedScrollableView(child: View): boolean {
if (child.height === "auto" && (child.ios instanceof UITableView || child.ios instanceof UIScrollView)) {
return true;
}
return false;
}
}