javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Small perf improvement in fromObject

Browse Source
This commit is contained in:
Hristo Hristov
2018-01-11 13:49:52 +02:00
parent 1e690a7b83
commit 8a428b011a
1 changed files with 12 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
tns-core-modules/data/observable/observable.ts
View File

@@ -215,22 +215,19 @@ function defineNewProperty(target: ObservableFromObject, propertyName: string):
}
function addPropertiesFromObject(observable: ObservableFromObject, source: any, recursive: boolean = false) {
let isRecursive = recursive;
for (let prop in source) {
if (source.hasOwnProperty(prop)) {
let value = source[prop];
if (isRecursive
&& !Array.isArray(value)
&& value
&& typeof value === 'object'
&& !(value instanceof Observable)) {
value = fromObjectRecursive(value);
}
defineNewProperty(observable, prop);
observable.set(prop, value);
Object.keys(source).forEach(prop => {
let value = source[prop];
if (recursive
&& !Array.isArray(value)
&& value
&& typeof value === 'object'
&& !(value instanceof Observable)) {
value = fromObjectRecursive(value);
}
}
defineNewProperty(observable, prop);
observable.set(prop, value);
});
}
export function fromObject(source: any): Observable {