javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(tabs): bottom nav item color fix

Browse Source
This commit is contained in:
Vasko
2020-03-31 11:53:10 +03:00
parent 32a55d35ae
commit 84d23ae89e
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
api-reports/NativeScript.api.md
View File

@@ -2258,6 +2258,8 @@ export class TabNavigationBase extends View {
setTabBarIconColor(tabStripItem: TabStripItem, value: any): void
setTabBarIconSource(tabStripItem: TabStripItem, value: any): void
setTabBarItemBackgroundColor(tabStripItem: TabStripItem, value: any): void
setTabBarItemColor(tabStripItem: TabStripItem, value: any): void

9
nativescript-core/ui/bottom-navigation/bottom-navigation.android.ts
View File

@@ -176,6 +176,8 @@ function initializeNativeClasses() {
tabStripItems[prevPosition]._emit(TabStripItem.unselectEvent);
owner._setItemColor(tabStripItems[prevPosition]);
}
owner._setItemsColors(owner.tabStrip.items);
}
public onTap(position: number): boolean {
@@ -726,7 +728,7 @@ export class BottomNavigation extends TabNavigationBase {
});
}
private setItemsColors(items: Array<TabStripItem>): void {
public _setItemsColors(items: Array<TabStripItem>): void {
items.forEach((item) => {
if (item.nativeView) {
this._setItemColor(item);
@@ -740,7 +742,7 @@ export class BottomNavigation extends TabNavigationBase {
public setTabBarSelectedItemColor(value: Color) {
this._selectedItemColor = value;
this.setItemsColors(this.tabStrip.items);
this._setItemsColors(this.tabStrip.items);
}
public getTabBarUnSelectedItemColor(): Color {
@@ -749,7 +751,7 @@ export class BottomNavigation extends TabNavigationBase {
public setTabBarUnSelectedItemColor(value: Color) {
this._unSelectedItemColor = value;
this.setItemsColors(this.tabStrip.items);
this._setItemsColors(this.tabStrip.items);
}
private updateItem(tabStripItem: TabStripItem): void {
@@ -768,6 +770,7 @@ export class BottomNavigation extends TabNavigationBase {
}
public _setItemColor(tabStripItem: TabStripItem) {
console.log("_setItemColor", tabStripItem._index);
const itemColor = (tabStripItem._index === this.selectedIndex) ? this._selectedItemColor : this._unSelectedItemColor;
if (!itemColor) {
return;