javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(bottom-navigation): android light/dark theme change on device crash (#9270)

Browse Source
This commit is contained in:
Nathan Walker
2021-03-18 13:47:46 -07:00
committed by GitHub
parent 17bdd2ad96
commit 8476931d6c
1 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
nativescript-core/ui/bottom-navigation/bottom-navigation.android.ts
View File

@@ -744,7 +744,12 @@ export class BottomNavigation extends TabNavigationBase {
}
public updateAndroidItemAt(index: number, spec: org.nativescript.widgets.TabItemSpec) {
this._bottomNavigationBar.updateItemAt(index, spec);
// this can throw when switching light/dark theme mode on device, just ignore
try {
this._bottomNavigationBar.updateItemAt(index, spec);
} catch (err) {
// ignore
}
}
public getTabBarBackgroundColor(): android.graphics.drawable.Drawable {
@@ -825,13 +830,18 @@ export class BottomNavigation extends TabNavigationBase {
}
private setIconColor(tabStripItem: TabStripItem, color?: Color) {
const tabBarItem = this._bottomNavigationBar.getViewForItemAt(tabStripItem._index);
// this can throw when switching light/dark theme mode on device, just ignore
try {
const tabBarItem = this._bottomNavigationBar.getViewForItemAt(tabStripItem._index);
const drawableInfo = this.getIconInfo(tabStripItem, color);
const imgView = <android.widget.ImageView>tabBarItem.getChildAt(0);
imgView.setImageDrawable(drawableInfo.drawable);
if (color) {
imgView.setColorFilter(color.android);
const drawableInfo = this.getIconInfo(tabStripItem, color);
const imgView = <android.widget.ImageView>tabBarItem.getChildAt(0);
imgView.setImageDrawable(drawableInfo.drawable);
if (color) {
imgView.setColorFilter(color.android);
}
} catch (err) {
// ignore
}
}