javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: disable animations for all in between fragments during a transition

Browse Source 
This prevent the wrong `transitionEnd` to be called last and thus the wrong `setCurrent` to be called on a released entry
This commit is contained in:
Martin Guillon
2022-02-10 10:39:46 +01:00
parent 40e0b73223
commit 80fe1837ac
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/core/ui/frame/index.android.ts
View File

@@ -440,7 +440,13 @@ export class Frame extends FrameBase {
}
if (clearHistory || isReplace) {
transaction.replace(this.containerViewId, newFragment, newFragmentTag);
// we need to ensure we dont listen for animations of
// in between fragments or they could break our transition end handling
// and set the wrong current entry
for (let index = 0; index < this.backStack.length; index++) {
_clearEntry(this.backStack[index]);
}
transaction.replace(this.containerViewId, newFragment, newFragmentTag);
} else {
transaction.add(this.containerViewId, newFragment, newFragmentTag);
}
@@ -473,6 +479,10 @@ export class Frame extends FrameBase {
// the order is important so that the last transition listener called be
// the one from the current entry we are going back from
for (let index = goBackToIndex + 1; index < currentIndex; index++) {
// we need to ensure we dont listen for animations of
// in between fragments or they could break our transition end handling
// and set the wrong current entry
_clearEntry(this.backStack[index]);
transaction.remove(this.backStack[index].fragment);
}
if (this._currentEntry !== backstackEntry) {