javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: fix app.start deprecation (#7067)

Browse Source
This commit is contained in:
Manol Donev
2019-03-25 16:04:48 +02:00
committed by GitHub
parent 26679d42ff
commit 761cd47360
2 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tns-core-modules/application/application.android.ts
View File

@@ -131,9 +131,8 @@ let mainEntry: NavigationEntry;
let started = false;
// NOTE: for backwards compatibility. Remove for 4.0.0.
const createRootFrame = { value: true };
export function start(entry?: NavigationEntry | string) {
console.log("application.start() is deprecated; use application.run() instead");
function _start(entry?: NavigationEntry | string) {
if (started) {
throw new Error("Application is already started.");
}
@@ -146,13 +145,18 @@ export function start(entry?: NavigationEntry | string) {
}
}
export function start(entry?: NavigationEntry | string) {
console.log("application.start() is deprecated; use application.run() instead");
_start(entry);
}
export function shouldCreateRootFrame(): boolean {
return createRootFrame.value;
}
export function run(entry?: NavigationEntry | string) {
createRootFrame.value = false;
start(entry);
_start(entry);
}
const CALLBACKS = "_callbacks";

11
tns-core-modules/application/application.ios.ts
View File

@@ -299,9 +299,7 @@ export function getRootView() {
// NOTE: for backwards compatibility. Remove for 4.0.0.
const createRootFrame = { value: true };
let started: boolean = false;
export function start(entry?: string | NavigationEntry) {
console.log("application.start() is deprecated; use application.run() instead");
function _start(entry?: string | NavigationEntry) {
mainEntry = typeof entry === "string" ? { moduleName: entry } : entry;
started = true;
@@ -333,9 +331,14 @@ export function start(entry?: string | NavigationEntry) {
}
}
export function start(entry?: string | NavigationEntry) {
console.log("application.start() is deprecated; use application.run() instead");
_start(entry);
}
export function run(entry?: string | NavigationEntry) {
createRootFrame.value = false;
start(entry);
_start(entry);
}
export function _resetRootView(entry?: NavigationEntry | string) {