javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

perf(core): cache default view paddings on android (#10390)

Browse Source
This commit is contained in:
Ammar Ahmed
2023-09-28 06:00:46 +05:00
committed by GitHub
parent a4bfbdaaa9
commit 6f599fef1c
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
packages/core/ui/core/view-base/index.ts
View File

@@ -309,6 +309,8 @@ namespace SuspendType {
}
}
const DEFAULT_VIEW_PADDINGS: Map<string, any> = new Map();
export abstract class ViewBase extends Observable implements ViewBaseDefinition {
/**
* String value used when hooking to loaded event.
@@ -1048,14 +1050,21 @@ export abstract class ViewBase extends Observable implements ViewBaseDefinition
if (this._androidView !== nativeView || !this.reusable) {
this._androidView = nativeView;
if (nativeView) {
const className = this.constructor.name;
if (this._isPaddingRelative === undefined) {
this._isPaddingRelative = nativeView.isPaddingRelative();
}
let result: any /* android.graphics.Rect */ = (<any>nativeView).defaultPaddings;
let result: any /* android.graphics.Rect */ = DEFAULT_VIEW_PADDINGS.get(className) || (<any>nativeView).defaultPaddings;
if (result === undefined) {
result = org.nativescript.widgets.ViewHelper.getPadding(nativeView);
(<any>nativeView).defaultPaddings = result;
DEFAULT_VIEW_PADDINGS.set(className, org.nativescript.widgets.ViewHelper.getPadding(nativeView));
(<any>nativeView).defaultPaddings = DEFAULT_VIEW_PADDINGS.get(className);
result = DEFAULT_VIEW_PADDINGS.get(className);
}
if (!nativeView.defaultPaddings) {
nativeView.defaultPaddings = DEFAULT_VIEW_PADDINGS.get(className);
}
this._defaultPaddingTop = result.top;