javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-15 11:01:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): ObservableArray splice ensure index is > 0 (#8921)

Browse Source 
Otherwise it will crash in ListView for iOS for example as it tries to animate an item with a negative row index
This commit is contained in:
Martin Guillon
2020-10-01 01:54:54 +02:00
committed by GitHub
parent a55bcd8561
commit 6d135e5d63
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/data/observable-array/index.ts
View File

@ -246,7 +246,7 @@ export class ObservableArray<T> extends Observable {
eventName: CHANGE, eventName: CHANGE,
object: this, object: this,
action: ChangeType.Splice, action: ChangeType.Splice,
index: Math.min(start, this._array.length-1), index: Math.max(Math.min(start, this._array.length-1), 0),
removed: result, removed: result,
addedCount: this._array.length + result.length - length, addedCount: this._array.length + result.length - length,
}); });