From 6d135e5d63ee34270e6452d0184fe40f45e2b5ec Mon Sep 17 00:00:00 2001 From: Martin Guillon Date: Thu, 1 Oct 2020 01:54:54 +0200 Subject: [PATCH] fix(core): ObservableArray splice ensure index is > 0 (#8921) Otherwise it will crash in ListView for iOS for example as it tries to animate an item with a negative row index --- packages/core/data/observable-array/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/data/observable-array/index.ts b/packages/core/data/observable-array/index.ts index cc026e91e..6f1123e19 100644 --- a/packages/core/data/observable-array/index.ts +++ b/packages/core/data/observable-array/index.ts @@ -246,7 +246,7 @@ export class ObservableArray extends Observable { eventName: CHANGE, object: this, action: ChangeType.Splice, - index: Math.min(start, this._array.length-1), + index: Math.max(Math.min(start, this._array.length-1), 0), removed: result, addedCount: this._array.length + result.length - length, });