javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-15 02:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: Proper variable naming for font variation

Browse Source
This commit is contained in:
Dimitris - Rafail Katsampas
2025-01-25 23:32:16 +02:00
committed by Nathan Walker
parent 8726d026fe
commit 6968997d9d
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/ui/core/view-base/index.ts
View File

@ -1067,7 +1067,7 @@ export abstract class ViewBase extends Observable implements ViewBaseDefinition
* Clean up references to the native view. * Clean up references to the native view.
*/ */
public disposeNativeView() { public disposeNativeView() {
// Unset those values so that view will check for resize after being removed and re-added to view-tree // Unset those values so that view checks for resize the next time it's added back to view tree
this._oldLeft = 0; this._oldLeft = 0;
this._oldTop = 0; this._oldTop = 0;
this._oldRight = 0; this._oldRight = 0;

4
packages/core/ui/styling/font-common.ts
View File

@ -83,10 +83,10 @@ export namespace FontVariationSettings {
return null; return null;
} }
const allowedValues = ['normal', 'inherit', 'initial', 'revert', 'revert-layer', 'unset']; const excluded = ['normal', 'inherit', 'initial', 'revert', 'revert-layer', 'unset'];
const variationSettingsValue: string = fontVariationSettings.trim(); const variationSettingsValue: string = fontVariationSettings.trim();
if (allowedValues.indexOf(variationSettingsValue.toLowerCase()) !== -1) { if (excluded.indexOf(variationSettingsValue.toLowerCase()) !== -1) {
return null; return null;
} }