From 6968997d9daee9c23e2cbccbe6e1ff1af01b680c Mon Sep 17 00:00:00 2001 From: Dimitris - Rafail Katsampas Date: Sat, 25 Jan 2025 23:32:16 +0200 Subject: [PATCH] chore: Proper variable naming for font variation --- packages/core/ui/core/view-base/index.ts | 2 +- packages/core/ui/styling/font-common.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/core/ui/core/view-base/index.ts b/packages/core/ui/core/view-base/index.ts index 2b0cf78c2..edadb694f 100644 --- a/packages/core/ui/core/view-base/index.ts +++ b/packages/core/ui/core/view-base/index.ts @@ -1067,7 +1067,7 @@ export abstract class ViewBase extends Observable implements ViewBaseDefinition * Clean up references to the native view. */ public disposeNativeView() { - // Unset those values so that view will check for resize after being removed and re-added to view-tree + // Unset those values so that view checks for resize the next time it's added back to view tree this._oldLeft = 0; this._oldTop = 0; this._oldRight = 0; diff --git a/packages/core/ui/styling/font-common.ts b/packages/core/ui/styling/font-common.ts index 3a0b35bf7..63e6743aa 100644 --- a/packages/core/ui/styling/font-common.ts +++ b/packages/core/ui/styling/font-common.ts @@ -83,10 +83,10 @@ export namespace FontVariationSettings { return null; } - const allowedValues = ['normal', 'inherit', 'initial', 'revert', 'revert-layer', 'unset']; + const excluded = ['normal', 'inherit', 'initial', 'revert', 'revert-layer', 'unset']; const variationSettingsValue: string = fontVariationSettings.trim(); - if (allowedValues.indexOf(variationSettingsValue.toLowerCase()) !== -1) { + if (excluded.indexOf(variationSettingsValue.toLowerCase()) !== -1) { return null; }