Merge pull request #2036 from NativeScript/feature/timer-fix

Fix: Timer somtimes crashing in IOS

apps/tests/timer-tests.ts

@@ -118,4 +118,54 @@ export function test_setInterval_callbackShouldBeCleared() {
 
     TKUnit.waitUntilReady(() => false, 0.5);
     TKUnit.assert(counter === 1, "Callback should be raised only once!");
-};
+};
+
+export function test_clearTimeout_multipleTimes_afterTick() {
+    let completed = false;
+
+    let id = timer.setTimeout(() => {
+        completed = true;
+    });
+
+    TKUnit.waitUntilReady(() => completed, 0.5);
+    TKUnit.assert(completed, "Callback should be called");
+    
+    timer.clearTimeout(id);
+    timer.clearTimeout(id);
+}
+
+export function test_clearTimeout_immediatelyAfterCreate() {
+    let completed = false;
+
+    let id = timer.setTimeout(() => {
+        completed = true;
+    });
+    timer.clearTimeout(id);
+
+    TKUnit.waitUntilReady(() => false, 0.02);
+    TKUnit.assert(!completed, "Callback should not be called");
+}
+
+export function test_clearInterval_immediatelyAfterCreate() {
+    let completed = false;
+
+    let id = timer.setInterval(() => {
+        completed = true;
+    });
+    timer.clearInterval(id);
+
+    TKUnit.waitUntilReady(() => false, 0.02);
+    TKUnit.assert(!completed, "Callback should not be called");
+}
+
+export function test_clearTimeout_insideCallback() {
+    let completed = false;
+
+    let id = timer.setTimeout(() => {
+        completed = true;
+        timer.clearTimeout(id);
+    });
+
+    TKUnit.waitUntilReady(() => completed, 0.5);
+    TKUnit.assert(completed, "Callback should be called");
+}

timer/timer.ios.ts

@@ -10,33 +10,37 @@ interface KeyValuePair<K, V> {
 }
 
 class TimerTargetImpl extends NSObject {
-    private _callback: Function;
-    public canceled = false;
+    private callback: Function;
+    private disposed: boolean;
     private id: number
     private shouldRepeat: boolean
 
     public static initWithCallback(callback: Function, id: number, shouldRepeat: boolean): TimerTargetImpl {
         let handler = <TimerTargetImpl>TimerTargetImpl.new();
-        handler._callback = callback;
+        handler.callback = callback;
         handler.id = id;
         handler.shouldRepeat = shouldRepeat;
         return handler;
     }
 
     public tick(timer): void {
-        if (!this.canceled) {
-            this._callback();
+        if (!this.disposed) {
+            this.callback();
         }
 
-        if (this.canceled || !this.shouldRepeat) {
+        if (!this.shouldRepeat) {
             this.unregister();
         }
     }
 
     public unregister() {
-        let timer = timeoutCallbacks.get(this.id).k;
-        timer.invalidate();
-        timeoutCallbacks.delete(this.id);
+        if (!this.disposed) {
+            this.disposed = true;
+
+            let timer = timeoutCallbacks.get(this.id).k;
+            timer.invalidate();
+            timeoutCallbacks.delete(this.id);
+        }
     }
 
     public static ObjCExposedMethods = {