golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-10-31 02:36:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup TODOs

Browse Source
This commit is contained in:
Derek Parker
2015-02-28 21:53:26 -06:00
parent c7cc84fa83
commit 9f05f444eb
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
proctl/threads_darwin.c
View File

@ -56,7 +56,6 @@ set_pc(thread_act_t task, uint64_t pc) {
if (kret != KERN_SUCCESS) return kret; if (kret != KERN_SUCCESS) return kret;
state.__rip = pc; state.__rip = pc;
// TODO(dp) - possible memory leak - vm_deallocate state
return thread_set_state(task, x86_THREAD_STATE64, (thread_state_t)&state, stateCount); return thread_set_state(task, x86_THREAD_STATE64, (thread_state_t)&state, stateCount);
} }
@ -74,7 +73,6 @@ single_step(thread_act_t thread) {
kret = thread_set_state(thread, x86_THREAD_STATE64, (thread_state_t)&regs, count); kret = thread_set_state(thread, x86_THREAD_STATE64, (thread_state_t)&regs, count);
if (kret != KERN_SUCCESS) return kret; if (kret != KERN_SUCCESS) return kret;
// TODO(dp) vm deallocate state?
// Continue here until we've fully decremented suspend_count // Continue here until we've fully decremented suspend_count
for (;;) { for (;;) {
@ -97,6 +95,5 @@ clear_trap_flag(thread_act_t thread) {
// Clear trap bit in rflags // Clear trap bit in rflags
regs.__rflags ^= 0x100UL; regs.__rflags ^= 0x100UL;
// TODO(dp) vm deallocate state?
return thread_set_state(thread, x86_THREAD_STATE64, (thread_state_t)&regs, count); return thread_set_state(thread, x86_THREAD_STATE64, (thread_state_t)&regs, count);
} }