From 9f05f444eb83d45aca3b26e4465c2e11e151de50 Mon Sep 17 00:00:00 2001 From: Derek Parker Date: Sat, 28 Feb 2015 21:53:26 -0600 Subject: [PATCH] Cleanup TODOs --- proctl/threads_darwin.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/proctl/threads_darwin.c b/proctl/threads_darwin.c index 04333446..cfe76d18 100644 --- a/proctl/threads_darwin.c +++ b/proctl/threads_darwin.c @@ -56,7 +56,6 @@ set_pc(thread_act_t task, uint64_t pc) { if (kret != KERN_SUCCESS) return kret; state.__rip = pc; - // TODO(dp) - possible memory leak - vm_deallocate state return thread_set_state(task, x86_THREAD_STATE64, (thread_state_t)&state, stateCount); } @@ -74,7 +73,6 @@ single_step(thread_act_t thread) { kret = thread_set_state(thread, x86_THREAD_STATE64, (thread_state_t)®s, count); if (kret != KERN_SUCCESS) return kret; - // TODO(dp) vm deallocate state? // Continue here until we've fully decremented suspend_count for (;;) { @@ -97,6 +95,5 @@ clear_trap_flag(thread_act_t thread) { // Clear trap bit in rflags regs.__rflags ^= 0x100UL; - // TODO(dp) vm deallocate state? return thread_set_state(thread, x86_THREAD_STATE64, (thread_state_t)®s, count); }