golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-10-29 09:46:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

proc: fix TestRangeOverFunc for arm64 on go1.25 (#4014)

Browse Source 
A couple of lines in rangeoverfunc.go do not produce instructions with
go1.25 on arm64, change the tests to handle this.
Also extend the TestRangeOverFuncNextInlined skip to go1.25 since the
problem with closure names will not be fixed in time.
This commit is contained in:
Alessandro Arzilli
2025-06-06 01:38:44 +02:00
committed by GitHub
parent 7c9b7d8dca
commit 89c6cd4f34
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
pkg/proc/stepping_test.go
View File

@ -695,6 +695,15 @@ func TestRangeOverFuncNext(t *testing.T) {
return seqTest{contNext, n}
}
nop := seqTest{contNothing, func(*proc.Target) {}}
ifcond := func(v bool, a seqTest, b seqTest) seqTest {
if v {
return a
}
return b
}
assertLocals := func(t *testing.T, varnames ...string) seqTest {
return seqTest{
contNothing,
@ -767,7 +776,7 @@ func TestRangeOverFuncNext(t *testing.T) {
testseq2intl(t, fixture, grp, p, nil, []seqTest{
funcBreak(t, "main.TestTrickyIterAll"),
{contContinue, 24}, // TestTrickyIterAll
nx(25),
ifcond(runtime.GOARCH == "arm64" && goversion.VersionAfterOrEqual(runtime.Version(), 1, 25), nop, nx(25)),
nx(26),
nx(27), // for _, x := range ...
assertLocals(t, "trickItAll", "i"),
@ -796,7 +805,7 @@ func TestRangeOverFuncNext(t *testing.T) {
testseq2intl(t, fixture, grp, p, nil, []seqTest{
funcBreak(t, "main.TestTrickyIterAll2"),
{contContinue, 37}, // TestTrickyIterAll2
nx(38),
ifcond(runtime.GOARCH == "arm64" && goversion.VersionAfterOrEqual(runtime.Version(), 1, 25), nop, nx(38)),
nx(39),
nx(40), // for _, x := range...
nx(41),
@ -1218,7 +1227,7 @@ func TestRangeOverFuncNextInlined(t *testing.T) {
if !goversion.VersionAfterOrEqual(runtime.Version(), 1, 23) {
t.Skip("N/A")
}
if goversion.VersionAfterOrEqual(runtime.Version(), 1, 24) && !goversion.VersionAfterOrEqual(runtime.Version(), 1, 25) {
if goversion.VersionAfterOrEqual(runtime.Version(), 1, 24) && !goversion.VersionAfterOrEqual(runtime.Version(), 1, 26) {
t.Skip("broken due to inlined symbol names")
}