mirror of
https://github.com/flutter/packages.git
synced 2025-06-02 08:56:45 +08:00

Many commands had insufficient failure testing. This adds new tests that ensure that for every Process call, at least one test fails if a failure from that process were ignored (with the exception of calls in the `publish` command, which has a custom process mocking system, so was out of scope here; it already has more coverage than most tests did though.) For a few existing failure tests, adds output checks to ensure that they are testing for the *right* failures. Other changes: - Adds convenience constructors to MockProcess for the common cases of a mock process that just exits with a 0 or 1 status, to reduce test verbosity. - Fixes a few bugs that were found by the new tests. - Minor test cleanup, especially cases where a mock process was being set up just to make all calls succeed, which is the default as of recent changes.
262 lines
7.6 KiB
Dart
262 lines
7.6 KiB
Dart
// Copyright 2013 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:io' as io;
|
|
|
|
import 'package:args/command_runner.dart';
|
|
import 'package:file/file.dart';
|
|
import 'package:file/memory.dart';
|
|
import 'package:flutter_plugin_tools/src/common/core.dart';
|
|
import 'package:flutter_plugin_tools/src/lint_podspecs_command.dart';
|
|
import 'package:path/path.dart' as p;
|
|
import 'package:test/test.dart';
|
|
|
|
import 'mocks.dart';
|
|
import 'util.dart';
|
|
|
|
void main() {
|
|
group('$LintPodspecsCommand', () {
|
|
FileSystem fileSystem;
|
|
late Directory packagesDir;
|
|
late CommandRunner<void> runner;
|
|
late MockPlatform mockPlatform;
|
|
late RecordingProcessRunner processRunner;
|
|
|
|
setUp(() {
|
|
fileSystem = MemoryFileSystem();
|
|
packagesDir = createPackagesDirectory(fileSystem: fileSystem);
|
|
|
|
mockPlatform = MockPlatform(isMacOS: true);
|
|
processRunner = RecordingProcessRunner();
|
|
final LintPodspecsCommand command = LintPodspecsCommand(
|
|
packagesDir,
|
|
processRunner: processRunner,
|
|
platform: mockPlatform,
|
|
);
|
|
|
|
runner =
|
|
CommandRunner<void>('podspec_test', 'Test for $LintPodspecsCommand');
|
|
runner.addCommand(command);
|
|
});
|
|
|
|
test('only runs on macOS', () async {
|
|
createFakePlugin('plugin1', packagesDir,
|
|
extraFiles: <String>['plugin1.podspec']);
|
|
mockPlatform.isMacOS = false;
|
|
|
|
Error? commandError;
|
|
final List<String> output = await runCapturingPrint(
|
|
runner, <String>['podspecs'], errorHandler: (Error e) {
|
|
commandError = e;
|
|
});
|
|
|
|
expect(commandError, isA<ToolExit>());
|
|
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
equals(<ProcessCall>[]),
|
|
);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(
|
|
<Matcher>[contains('only supported on macOS')],
|
|
));
|
|
});
|
|
|
|
test('runs pod lib lint on a podspec', () async {
|
|
final Directory plugin1Dir = createFakePlugin(
|
|
'plugin1',
|
|
packagesDir,
|
|
extraFiles: <String>[
|
|
'ios/plugin1.podspec',
|
|
'bogus.dart', // Ignore non-podspecs.
|
|
],
|
|
);
|
|
|
|
processRunner.mockProcessesForExecutable['pod'] = <io.Process>[
|
|
MockProcess.succeeding(),
|
|
MockProcess.succeeding(),
|
|
];
|
|
processRunner.resultStdout = 'Foo';
|
|
processRunner.resultStderr = 'Bar';
|
|
|
|
final List<String> output =
|
|
await runCapturingPrint(runner, <String>['podspecs']);
|
|
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall('which', const <String>['pod'], packagesDir.path),
|
|
ProcessCall(
|
|
'pod',
|
|
<String>[
|
|
'lib',
|
|
'lint',
|
|
p.join(plugin1Dir.path, 'ios', 'plugin1.podspec'),
|
|
'--configuration=Debug',
|
|
'--skip-tests',
|
|
'--use-modular-headers',
|
|
'--use-libraries'
|
|
],
|
|
packagesDir.path),
|
|
ProcessCall(
|
|
'pod',
|
|
<String>[
|
|
'lib',
|
|
'lint',
|
|
p.join(plugin1Dir.path, 'ios', 'plugin1.podspec'),
|
|
'--configuration=Debug',
|
|
'--skip-tests',
|
|
'--use-modular-headers',
|
|
],
|
|
packagesDir.path),
|
|
]),
|
|
);
|
|
|
|
expect(output, contains('Linting plugin1.podspec'));
|
|
expect(output, contains('Foo'));
|
|
expect(output, contains('Bar'));
|
|
});
|
|
|
|
test('allow warnings for podspecs with known warnings', () async {
|
|
final Directory plugin1Dir = createFakePlugin('plugin1', packagesDir,
|
|
extraFiles: <String>['plugin1.podspec']);
|
|
|
|
final List<String> output = await runCapturingPrint(
|
|
runner, <String>['podspecs', '--ignore-warnings=plugin1']);
|
|
|
|
expect(
|
|
processRunner.recordedCalls,
|
|
orderedEquals(<ProcessCall>[
|
|
ProcessCall('which', const <String>['pod'], packagesDir.path),
|
|
ProcessCall(
|
|
'pod',
|
|
<String>[
|
|
'lib',
|
|
'lint',
|
|
p.join(plugin1Dir.path, 'plugin1.podspec'),
|
|
'--configuration=Debug',
|
|
'--skip-tests',
|
|
'--use-modular-headers',
|
|
'--allow-warnings',
|
|
'--use-libraries'
|
|
],
|
|
packagesDir.path),
|
|
ProcessCall(
|
|
'pod',
|
|
<String>[
|
|
'lib',
|
|
'lint',
|
|
p.join(plugin1Dir.path, 'plugin1.podspec'),
|
|
'--configuration=Debug',
|
|
'--skip-tests',
|
|
'--use-modular-headers',
|
|
'--allow-warnings',
|
|
],
|
|
packagesDir.path),
|
|
]),
|
|
);
|
|
|
|
expect(output, contains('Linting plugin1.podspec'));
|
|
});
|
|
|
|
test('fails if pod is missing', () async {
|
|
createFakePlugin('plugin1', packagesDir,
|
|
extraFiles: <String>['plugin1.podspec']);
|
|
|
|
// Simulate failure from `which pod`.
|
|
processRunner.mockProcessesForExecutable['which'] = <io.Process>[
|
|
MockProcess.failing(),
|
|
];
|
|
|
|
Error? commandError;
|
|
final List<String> output = await runCapturingPrint(
|
|
runner, <String>['podspecs'], errorHandler: (Error e) {
|
|
commandError = e;
|
|
});
|
|
|
|
expect(commandError, isA<ToolExit>());
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(
|
|
<Matcher>[
|
|
contains('Unable to find "pod". Make sure it is in your path.'),
|
|
],
|
|
));
|
|
});
|
|
|
|
test('fails if linting as a framework fails', () async {
|
|
createFakePlugin('plugin1', packagesDir,
|
|
extraFiles: <String>['plugin1.podspec']);
|
|
|
|
// Simulate failure from `pod`.
|
|
processRunner.mockProcessesForExecutable['pod'] = <io.Process>[
|
|
MockProcess.failing(),
|
|
];
|
|
|
|
Error? commandError;
|
|
final List<String> output = await runCapturingPrint(
|
|
runner, <String>['podspecs'], errorHandler: (Error e) {
|
|
commandError = e;
|
|
});
|
|
|
|
expect(commandError, isA<ToolExit>());
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(
|
|
<Matcher>[
|
|
contains('The following packages had errors:'),
|
|
contains('plugin1:\n'
|
|
' plugin1.podspec')
|
|
],
|
|
));
|
|
});
|
|
|
|
test('fails if linting as a static library fails', () async {
|
|
createFakePlugin('plugin1', packagesDir,
|
|
extraFiles: <String>['plugin1.podspec']);
|
|
|
|
// Simulate failure from the second call to `pod`.
|
|
processRunner.mockProcessesForExecutable['pod'] = <io.Process>[
|
|
MockProcess.succeeding(),
|
|
MockProcess.failing(),
|
|
];
|
|
|
|
Error? commandError;
|
|
final List<String> output = await runCapturingPrint(
|
|
runner, <String>['podspecs'], errorHandler: (Error e) {
|
|
commandError = e;
|
|
});
|
|
|
|
expect(commandError, isA<ToolExit>());
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(
|
|
<Matcher>[
|
|
contains('The following packages had errors:'),
|
|
contains('plugin1:\n'
|
|
' plugin1.podspec')
|
|
],
|
|
));
|
|
});
|
|
|
|
test('skips when there are no podspecs', () async {
|
|
createFakePlugin('plugin1', packagesDir);
|
|
|
|
final List<String> output =
|
|
await runCapturingPrint(runner, <String>['podspecs']);
|
|
|
|
expect(
|
|
output,
|
|
containsAllInOrder(
|
|
<Matcher>[contains('SKIPPING: No podspecs.')],
|
|
));
|
|
});
|
|
});
|
|
}
|