* [pigeon] Fix missed line break between generated statements in Kotlin
* [pigeon] Extend platform test pigeon to catch missed line break
* [pigeon] Use prefared core tests pigeon to catch missed line break
* [pigeon] Remove formatting that causes a position-related issues
* [pigeon] Move not a special-case type field to the end to improve compilation test coverage
* [pigeon] Restore accidentally removed changelog entry
* fix broken test and add gen files
Co-authored-by: tarrinneal <tarrinneal@gmail.com>
This adds a bringup LUCI version of the macOS-host custom package tests.
This is the first attempt to migrate a flutter/packages or
flutter/plugins test to macOS ARM, so is experimental.
The motivation for doing this migration now is to see if it can unblock
https://github.com/flutter/packages/pull/2816, which doesn't seem to
be able to run successfully on Cirrus ARM machines (very possibly due
to the same issue that blocked flutter/plugins migrations to ARM on
Cirrus).
* Add new APIs, unimplemented and unused
* Add Dart implementation
* Add multiple arity FlutterApi
* Add Dart unit tests for desired output format
* Enable the existing integration test
* Add units tests for callback format
* Adjust unit test expectations for error callback
* First-pass implementation; mostly untested
* Comment fix
* Add todo
* Minor fixes
* Fix compilation error in Swift from new pigeons
* Make new Maps string-keyed to avoid Swift error
* Update generation
* Update unit test for change
* Update C++ test plugin for API changes
* Fix type regression
* missing ;
* Drop string_view in Flutter API
* Unwind incorrect 'simplification' of custom classes
* Fix merge mistake
* Merge mistake
* Version bump
* Address review comments
* Fix Dart unit test compilation
* Rename generator class to Adapter
* create new generator class and dart subclass
* cpp and dart test gen
* added files
* Adds Generator class to all generators
* adds swift
* Updates tests to use new Adapter naming scheme
* Dart generate methods
* convert all generate functions to use new method
* chagngelog
* remove Generator class fields
* move paths to options
* remove dartTestOptions
* Moves write header to generator class method
* Updates tests to use new generator class
* source -> header
* correct options
* header -> source
* header -> prefix, source -> header
* remove headers from generateTestDart
* changelog
* Nits and combines source and header generators
* renames Adapter to GeneratorAdapter
* Update version number for breaking changes
* nits
* more personal nits
* update tests to match new merged generators
* cleaner header methods
* Fixes dart header bug
* add gen files for clarity
* better field naming
* better field naming
* removed unneeded dart test generator
* Add filetype to generator
* Adds filetype as field to generatorAdapters
* merge
* analyze
* add import method
* re-remove DartTestGenerator
* Moves imports to new method
* adds writeEnum method to generator class
* nits
* assert
* objc enum
* fix code order issues
* add writeDataClass method
* remove writeMainClass from java
* java + kotlin
* remove dead code
* swift
* fix dart test error
* cpp + objc
* objc + cpp
* Move all migrated methods into class
* Creates writeHeader method on Generator classes
* private unique methods and reorder
* changelog
* changelog
* changelog
* changelog
* prologue
* gen
* dart
* java
* kotlin
* swift
* cpp
* objc
* remove unneeded java method
* analyze
* single file gens
* objc
* Cpp
* analyze
* vocab
* vocab
* typo
* less comma
* wrap write methods
* move code from writeGeneralUtilities
* update changelog
* adds open and close namespace and fixes nits
* makes writeEnum optional
* remove unneeded sink
* remove unneeded namespace from guardname
* [indent]
* clean up
* 33c71beee Bump actions/upload-artifact from 3.1.1 to 3.1.2 (flutter/flutter#118116)
* 2e0849e9d Bump actions/checkout from 3.1.0 to 3.3.0 (flutter/flutter#118052)
* aabf146f3 Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter/flutter#117104)
* a50e2c8d6 6048f9110 Roll Dart SDK from 23cbd61a1327 to 22fa50e09ee8 (3 revisions) (flutter/engine#38776) (flutter/flutter#118320)
* e697805bf Roll Plugins from 9fdc899b72ca to 620a059d62b2 (4 revisions) (flutter/flutter#118317)
* b4a07de2a ee76ab71e Cleanup Skia includes in image_generator/descriptor (flutter/engine#38775) (flutter/flutter#118335)
* c6be43a65 Roll Flutter Engine from ee76ab71e0a6 to cccaae2f3d8b (3 revisions) (flutter/flutter#118349)
* 4b2d3eb0f 764a9e012 Roll Skia from e1f3980272f3 to dfb838747295 (48 revisions) (flutter/engine#38790) (flutter/flutter#118355)
* b2b405043 Roll Flutter Engine from 764a9e01204d to 4a8d6866a1c0 (2 revisions) (flutter/flutter#118357)
* 727e86079 Marks Mac_ios complex_layout_scroll_perf_bad_ios__timeline_summary to be unflaky (flutter/flutter#111570)
* 13ebde6ff Marks Mac channels_integration_test to be unflaky (flutter/flutter#111571)
* f8628b5cb Marks Mac_ios platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary to be unflaky (flutter/flutter#116668)
* 44f540338 Fix `SliverAppBar.large` and `SliverAppBar.medium` do not use `foregroundColor` (flutter/flutter#118322)
* 51c2af56c docs: update docs about color property in material card (flutter/flutter#117263)
* 0d91c0343 Fix M3 `Drawer` default shape in RTL (flutter/flutter#118185)
* [gis_web] Adds id.renderButton API.
* Modernizes JS-interop so it's more compliant with dart2wasm.
* Updates examples, tests and docs.
* Bumps major version.
* Add the GsiButtonDataExtension class.
* Make oauth2 library more dart2wasm friendly.
* Reimplement hasGrantedA[ny|ll]Scopes in Dart.
* Fix oauth example.
* Added troubleshooting section to README.
* Add happy case tests for the oauth flow.
* Fix typo in config constructors.
* dart format
* Add some error handling to the library
* Add previously_granted_scopes field to overridable token config.
Make scopes a List of Strings in the hasGranted[Any|All]Scopes method.
* Rename generator class to Adapter
* create new generator class and dart subclass
* cpp and dart test gen
* added files
* Adds Generator class to all generators
* adds swift
* Updates tests to use new Adapter naming scheme
* Dart generate methods
* convert all generate functions to use new method
* chagngelog
* remove Generator class fields
* move paths to options
* remove dartTestOptions
* Nits and combines source and header generators
* renames Adapter to GeneratorAdapter
* Update version number for breaking changes
* nits
* more personal nits
* Fixes dart header bug
* add gen files for clarity
* better field naming
* better field naming
* removed unneeded dart test generator
* Add filetype to generator
* Adds filetype as field to generatorAdapters
* nits
* assert
* Default FileType
* alt v4
* alt v5
* nits
Fixes a warning in generated Swift output when an argument is of type Object. This is blocking flutter/plugins#6914 since we check our macOS and iOS plugin code for warnings in CI.
Rather than add a Dart generator unit test for this one specific case, I tightened the Swift compilation settings for our test plugin to treat warnings as errors (per flutter/flutter#59116 (comment)) to catch the entire class of errors, and added echo* variants for Object to make sure this one then showed up.
Incidental fixes:
I had to make a similar fix to the Dart generator for a similar warning with casting to Object?, which we'd never noticed because we weren't analyzing any generated code that returning Object or Object? before.
I had to make a change to the C++ generator so that generation would succeed, because it turned out we had no handling at all of Object in the C++ generator, causing it to throw. I'm not sure this is the output I'll keep for C++ (thus the TODO), but it's the simple fix to make it work at all.
Fixesflutter/flutter#117994
Part of flutter/flutter#59116
* 64e733647 Roll Plugins from b202b3db98dc to e85f8ac1502d (3 revisions) (flutter/flutter#117875)
* fe8dcf663 [flutter_tools] timeline_test.dart flaky (flutter/flutter#116667)
* f1905593b 7e51aef0a Roll Skia from fde37f5986fd to 809e328ed55c (1 revision) (flutter/engine#38596) (flutter/flutter#117874)
* ccfd14b05 Updated to tokens v0.150. (flutter/flutter#117350)
* b9ead3724 Simplify null check. (flutter/flutter#117026)
* 084be5e6d Roll Flutter Engine from 7e51aef0a1be to 1d2ba73d1059 (9 revisions) (flutter/flutter#117923)
* fdc25a170 Reland "Remove single-view assumption from ScrollPhysics (#117503)" (flutter/flutter#117916)
* 6b9f1c228 Minor documentation fix on BorderRadiusDirectional.zero (flutter/flutter#117661)
* 889e35b3f fix typos (flutter/flutter#117592)
* bd69ef70a c0b3f8fce Make `AccessibilityBridge` a `AXPlatformTreeManager` (flutter/engine#38610) (flutter/flutter#117931)
* a7942e80d Add convenience constructors for SliverList (flutter/flutter#116605)
* dbd36fb13 2213b80dd [Impeller Scene] Use std::chrono for animation durations (flutter/engine#38606) (flutter/flutter#117935)
* 9080d1acc Reland "Add support for double tap and drag for text selection #109573" (flutter/flutter#117502)
* 63653e827 == override parameters are non-nullable (flutter/flutter#117839)
* 906761cf9 Fix the message strings for xcodeMissing and xcodeIncomplete (flutter/flutter#117922)
* e599e5c9a 32c468507 Roll quiver to 3.2.1 (flutter/engine#38617) (flutter/flutter#117942)
* c53501d83 Send text direction in selection rects (flutter/flutter#117436)
* 025ce117b Correctly propagate verbosity to subtasks in flutter.gradle (flutter/flutter#117897)
* 9bb4ffe15 Roll Flutter Engine from 9e63c1ae1480 to 190f743a8506 (2 revisions) (flutter/flutter#117744)
* babeb6191 cc8055d5f Roll Skia from 4b578d72dc2e to e4c86c2fed9a (1 revision) (flutter/engine#38535) (flutter/flutter#117745)
* 9afaf6b88 f3cc581d9 Roll Dart SDK from 6e07d9b025bd to f7b36d5e50a5 (1 revision) (flutter/engine#38536) (flutter/flutter#117749)
* 0e83ada59 Update M3 IconButton unselected focused opacity (flutter/flutter#117321)
* 2783d3168 Roll Flutter Engine from f3cc581d97e1 to 3655bf981d4c (2 revisions) (flutter/flutter#117751)
* 4a6ab96c9 Roll Flutter Engine from 3655bf981d4c to 34f75ed27c9b (3 revisions) (flutter/flutter#117760)
* 2ffa65c76 e9e79180e Roll Skia from 2923399853d9 to 0027eb334691 (6 revisions) (flutter/engine#38545) (flutter/flutter#117763)
* cee9ec522 606e77f35 Roll Skia from 0027eb334691 to 668260c85e9d (1 revision) (flutter/engine#38547) (flutter/flutter#117766)
* c089c19f1 Revert "[reland] Add Material 3 support for `ListTile` - Part 1 (#116963)" (flutter/flutter#117756)
* bdefebcf7 9b534a5f8 Roll Skia from 668260c85e9d to 25ffa2b757e9 (1 revision) (flutter/engine#38548) (flutter/flutter#117768)
* aa70994f6 8655ec022 [Impeller Scene] Add ColorSourceContents for drawing a node (flutter/engine#38485) (flutter/flutter#117769)
* cbc184d9a Roll Flutter Engine from 8655ec022fe1 to ecd47e0b256a (2 revisions) (flutter/flutter#117772)
* 0b6971946 Roll Flutter Engine from ecd47e0b256a to 45e689b15d1a (2 revisions) (flutter/flutter#117778)
* d2127ad34 e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter/flutter#117779)
* d1244b7c9 da77d1a3a Roll Skia from 2e3ee507e838 to 7ad6f27aff57 (1 revision) (flutter/engine#38447) (flutter/flutter#117474)
* 400b05ac0 Manual package roll (flutter/flutter#117439)
* 9a347fb06 Support safe area and scrolling in the NavigationDrawer (flutter/flutter#116995)
* 2a502363e Add native unit tests to iOS and macOS templates (flutter/flutter#117147)
* 1970bc919 cacheWidth cacheHeight support for canvaskit on web (flutter/flutter#117423)
* ff347bfde Fix `InkRipple` doesn't respect `rectCallback` when rendering ink circle (flutter/flutter#117395)
* ddb7e43d7 Roll Flutter Engine from da77d1a3abb8 to 84ba80331ffe (2 revisions) (flutter/flutter#117489)
* 8ff1b6eb5 Fix Scaffold bottomSheet null exceptions (flutter/flutter#117008)
* 2931e50c3 Handle the case of no selection rects (flutter/flutter#117419)
* 39fa0117a Revert "Add support for double tap and drag for text selection (#109573)" (flutter/flutter#117497)
* b8b356713 Remove single-view assumption from widgets library (flutter/flutter#117480)
* ca7ca3b8f Roll Flutter Engine from 84ba80331ffe to a90c45db3f13 (2 revisions) (flutter/flutter#117499)
* 9fb1ae839 [iOS] Add task for spell check integration test (flutter/flutter#116222)
* b20a9e0a3 imporve gesture recognizer semantics test cases (flutter/flutter#117257)
* a82c556a1 3626c487a Add a missing include to display_list_matrix_clip_tracker.h (flutter/engine#38371) (flutter/flutter#117269)
* 9daf2a67e Roll Flutter Engine from 3626c487a610 to 7e296985f426 (2 revisions) (flutter/flutter#117270)
* d0d13c545 51b84d69b Roll Fuchsia Mac SDK from qYE6uXjRtAxy7p5HB... to qk9nUlw83EeMMaWmE... (flutter/engine#38380) (flutter/flutter#117273)
* 725049f2b 794370b9c Roll Fuchsia Linux SDK from PqyqxdbUFyd8xoYIP... to bloqad357AGI6lnOb... (flutter/engine#38381) (flutter/flutter#117276)
* 49f3ca400 eeae936f9 Use canvaskit `toByteData` for unsupported videoFrame formats (flutter/engine#38361) (flutter/flutter#117279)
* c0dddacb8 Fix is canvas kit bool (flutter/flutter#116944)
* d88d52405 276327f7e Roll Fuchsia Mac SDK from qk9nUlw83EeMMaWmE... to DdU--deE0Xl4TQ2Bm... (flutter/engine#38383) (flutter/flutter#117286)
* b7d9be0a7 747a9d8c7 Roll Skia from 7b0a9d9a3008 to 0362c030efa7 (9 revisions) (flutter/engine#38385) (flutter/flutter#117289)
* 1233fc979 37387019b Roll Fuchsia Linux SDK from bloqad357AGI6lnOb... to mRBUNknZk43y-LHGS... (flutter/engine#38386) (flutter/flutter#117290)
* a3a0048d7 3c6cab032 Roll Fuchsia Mac SDK from DdU--deE0Xl4TQ2Bm... to NLb_T58g0l_X46JEN... (flutter/engine#38387) (flutter/flutter#117295)
* 420c6d6cc Roll Flutter Engine from 3c6cab03274f to 58ab5277a7c4 (2 revisions) (flutter/flutter#117312)
* d238bedf4 Roll Plugins from cbcf50726fb9 to 840a04954fa0 (8 revisions) (flutter/flutter#117314)
* 3eefb7af0 a9491515f Roll Skia from 0362c030efa7 to fc0ac31a46f8 (4 revisions) (flutter/engine#38399) (flutter/flutter#117317)
* 9f9010f5e [flutter_tools] Update DAP progress when waiting for Dart Debug extension connection (flutter/flutter#116892)
* 32da25053 a12dadfda Roll Fuchsia Mac SDK from NLb_T58g0l_X46JEN... to NS4fVXM2KhKcZ1uyD... (flutter/engine#38400) (flutter/flutter#117319)
* cb988c7b6 Add `indicatorColor` & `indicatorShape` to `NavigationRail`, `NavigationDrawer` and move these properties from destination to `NavigationBar` (flutter/flutter#117049)
* 5fcb48d59 Fix `NavigationRail` highlight (flutter/flutter#117320)
* 70f391db7 7bc519375 Roll Skia from fc0ac31a46f8 to 46af4ad25426 (1 revision) (flutter/engine#38403) (flutter/flutter#117322)
* 9f2c5d8e2 Support `flutter build web --wasm` (flutter/flutter#117075)
* 55584ad50 Roll Flutter Engine from 7bc519375b7b to 45713ea10510 (2 revisions) (flutter/flutter#117330)
* 4daff0857 Roll Flutter Engine from 45713ea10510 to cba3a3990138 (5 revisions) (flutter/flutter#117336)
* 1adc27503 Bump min SDK to 2.19.0-0 (flutter/flutter#117345)
* efadc3458 Roll Flutter Engine from cba3a3990138 to 6de29d1cba70 (3 revisions) (flutter/flutter#117354)
* b30947bef roll packages (flutter/flutter#117226)
* e625e5f46 3330cce60 Roll Fuchsia Linux SDK from yGQvkNl85l1TSeuo9... to uKNwsaf92uZcX_QiY... (flutter/engine#38411) (flutter/flutter#117358)
* 50a23d962 339791f19 Roll Skia from 8876daf17554 to e8c3fa6d7d2f (3 revisions) (flutter/engine#38413) (flutter/flutter#117366)
* 7f7a8778d Implemented Scrim Focus for BottomSheet (flutter/flutter#116743)
* 38e3930f3 Exposed tooltip longPress action when available (flutter/flutter#117338)
* 61fb6ea2d Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (flutter/flutter#117372)
* c64dcbefa Revert "Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (#117372)" (flutter/flutter#117396)
* 8289ea624 Move a comment where it belongs (flutter/flutter#117385)
* fa3777bd3 Enable `sized_box_shrink_expand` lint (flutter/flutter#117371)
* e0742ebb2 [Android] Add spell check suggestions toolbar (flutter/flutter#114460)
* 0220afdd3 enable use_enums (flutter/flutter#117376)
* d71fa885e Bump ossf/scorecard-action from 2.1.0 to 2.1.1 (flutter/flutter#117337)
* 4591f057f roll packages (flutter/flutter#117357)
* 46bb85376 Revert "Revert "Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (#117372)" (#117396)" (flutter/flutter#117402)
* 81bc54be7 Enable `use_colored_box` lint (flutter/flutter#117370)
* fdd2d7d64 Sync analysis_options.yaml & cleanups (flutter/flutter#117327)
* de357647b [Android] Bump template AGP and NDK versions (flutter/flutter#116536)
* b308555ed Enable `dangling_library_doc_comments` and `library_annotations` lints (flutter/flutter#117365)
* b3c7fe32e enable test_ownership in presubmit (flutter/flutter#117414)
* 014b8f735 Roll Flutter Engine from 7ee3bf518036 to 75d75575d0ea (12 revisions) (flutter/flutter#117421)
* cd0f15a77 Add support for double tap and drag for text selection (flutter/flutter#109573)
* e8e26b684 c7eae2901 [Impeller] Remove depth/stencil attachments from imgui pipeline (flutter/engine#38427) (flutter/flutter#117425)
* a3e7fe3ff de59f842a Roll Dart SDK from 35f6108ef685 to 1530a824fd5f (6 revisions) (flutter/engine#38431) (flutter/flutter#117429)
* 169935168 4724a91af Roll Skia from 09d796c0a728 to a60f3f6214d3 (5 revisions) (flutter/engine#38432) (flutter/flutter#117433)
* 9024c9543 28f344ceb Roll Dart SDK from 1530a824fd5f to 8078926ca996 (1 revision) (flutter/engine#38434) (flutter/flutter#117435)
* cae784649 c9ee05b68 use min/max sandwich test on unit test bounds (flutter/engine#38435) (flutter/flutter#117442)
* 6819f72a9 Roll Flutter Engine from c9ee05b68e6e to 2404db80ae80 (3 revisions) (flutter/flutter#117443)
* f5c071659 4910ff889 Roll Fuchsia Mac SDK from nJJfWIwH5zElheIX8... to UsYNZnnfR_s0OGQoX... (flutter/engine#38444) (flutter/flutter#117454)
* a7a5d14d2 Roll Plugins from 840a04954fa0 to 54fc2066d636 (6 revisions) (flutter/flutter#117456)
* 51a3e3a33 1e695f453 Roll Dart SDK from 778a29535ab5 to 62ea309071c6 (1 revision) (flutter/engine#38445) (flutter/flutter#117459)
* start
* Class file transfer and skeleton comments
* relocate generator classes and update imports
* merge main and changelog update
* update openSink to openWriteSink
* Revert "[pigeon] Relocates generator classes and updates imports (#2985)"
This reverts commit 3b5ae0070738103a80bb9ac12440dd69d598ad2c.
Picks up minor improvements, most notably understanding that Pigeon's
platform_tests are dev-only changes that don't need changelog or version
updates.
* ✨ Add redirectWithState method to GoRouteData
* ✅ Update the tests
* ⬆️ Increase version number
* ✏️ Better changelog
* 💥 Remove xxxWithState and adds a the context and the state as a parameter to all GoRouteData callbacks
* 📝 Update the change logs and version number
* 💥 Rename replace into pushReplacement
* 📝 Add pushReplacementNamed into change log
* 📝 Add migration guide's link to the read me
