mirror of
https://github.com/flutter/packages.git
synced 2026-03-13 10:40:37 +08:00
addExampleDataAssets
10470 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
stuartmorgan-g
|
cfa6324f7a | Merge branch 'main' into addExampleDataAssets | ||
|
stuartmorgan-g
|
3b856a2ab0 |
[ci] Fix syntax error in auto-labeler (#11052)
https://github.com/flutter/packages/pull/11042 was missing a `:`, causing label jobs to fail in CI. |
||
|
Google Admin
|
73afe268cc |
Refactor Github Action per b/485167538 (#11051)
This is a http://go/LSC run by http://go/ghss to automatically refactor your Github Actions per http://b/485167538. This is a PR to help you upgrade to the latest standards in Github Actions. Please merge this PR to accept the changes. NOTE: if you do not accept this PR, it may be force merged by the GHSS team. See http://b/485167538 for more details. |
||
|
Kate Lovett
|
2684fe0e09 |
[material_ui] Add material_ui package (#11043)
Creates the material_ui package in preparation for decoupling. Once published, this will be marked as `unlisted` (to be done in pub.dev dashboard) until the primary code move from the framework takes place. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.material_ui-v0.0.1 |
||
|
Kate Lovett
|
ff7dff5b41 |
[cupertino_ui] Add cupertino_ui package (#11042)
Creates the cupertino_ui package in preparation for decoupling. Once published, this will be marked as `unlisted` (to be done in pub.dev dashboard) until the primary code move from the framework takes place. - The [`cupertino`](https://pub.dev/packages/cupertino) package will also be marked discontinued and pointed to this one. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.cupertino_ui-v0.0.1 |
||
|
Felipe Morschel
|
59f905ced6 |
[camera][google_fonts] Fixes future warning for awaiting Future returns in async bodies inside try blocks (#11009)
This is merely an `analyzer` change to avoid the bug explained at: - https://github.com/dart-lang/sdk/issues/62555. This will allow the development of a warning about these situations so we can avoid this bug in the future. I'm not entirely sure about the version change. This is definitely not working as the author(s) expected (as described on the issue linked above), but I'm not sure how urgent this needs to be published, so I'll leave it up to the reviewers. Same about tests (which I'm not sure exactly where to add them) and CHANGELOGs. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.camera_android_camerax-v0.7.0+1 camera-v0.11.4 camera_android-v0.10.10+15 camera_avfoundation-v0.10.0+2 google_fonts-v8.0.2 |
||
|
Robert Odrowaz
|
66b0cce4a1 |
[camera_avfoundation] Pigeon swift migration - part 2 (#10980)
Migrates camera package to the Swift-based pigeon interface as the last part of https://github.com/flutter/flutter/issues/119109 This PR replaces the ObjC-based pigeon interfaces with Swift-based ones, thus removing the last remaining pieces of ObjC code in the package 🎉 I know there are a lot of changes in this PR, but there is no way to split it into smaller parts. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.camera_avfoundation-v0.10.0+1 |
||
|
Rui Craveiro
|
86c0cea8d6 |
[camera_android_camerax] Adds support for video stabilization (#11020)
Implements getSupportedVideoStabilizationModes() and setVideoStabilizationMode() methods in AndroidCameraCameraX. Address issue https://github.com/flutter/flutter/issues/89525. It is the camera_android_camerax sub-PR for https://github.com/flutter/packages/pull/7108. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.camera_android_camerax-v0.7.0 |
||
|
Natesh Bhat
|
3a5e9a8ced |
[video_player] Adds audio track metadata fetching and audio track selection feature (#9925)
## Description This PR adds comprehensive audio track retrieval and selection support to the video_player package, enabling developers to access detailed information about available audio tracks and switch between them during playback. Breakout PRs: 1. Platform interface : #10171 2. Andrioid : #10312 3. ios : #10313 ### Changes Made #### Core Features - **Added `VideoAudioTrack` model** with comprehensive metadata fields: `id`, `label`, `language`, `isSelected`, `bitrate`, `sampleRate`, `channelCount`, `codec` - **Added [getAudioTracks()]() method** to retrieve all available audio tracks with real metadata - **Added [selectAudioTrack()]() method** to switch between audio tracks during playback - **Updated `VideoPlayerController`** to expose audio track functionality #### Platform Implementations - **Android**: - Real metadata extraction using ExoPlayer's `getCurrentTracks()` API - Robust track selection using `TrackSelectionOverride` with proper error handling - Support for multiple audio formats (AAC, AC3, EAC3, MP3, etc.) - **iOS**: - Metadata extraction from AVFoundation using `AVAssetTrack` for regular videos - HLS stream support using `AVMediaSelectionGroup` for adaptive streams - Proper track selection for both asset tracks and media selection options #### Technical Infrastructure - **Updated Pigeon interfaces** for both Android and iOS with new data structures: - `AudioTrackMessage`, `ExoPlayerAudioTrackData`, `AssetAudioTrackData`, `MediaSelectionAudioTrackData`, `NativeAudioTrackData` - **Enhanced platform interface** with new methods and data classes - **Has native unit tests** for both Android and iOS platforms - **Created demo screen** showcasing audio track functionality with interactive UI ### Demo Features - Interactive video player with audio track selection - Real-time metadata display (bitrate, sample rate, channels, codec) - Support for multiple video sources including HLS streams - Visual indicators for currently selected tracks ## Related Issues Fixes https://github.com/flutter/flutter/issues/59437 ### Testing - Added native unit tests for both Android and iOS - Tested with various video formats and HLS streams - Verified backward compatibility with existing functionality - Demo screen widget for manual testing and validation ### Breaking Changes None - all changes are additive and backward compatible. ## Pre-Review Checklistvideo_player-v2.11.0 |
||
|
stuartmorgan-g
|
5805a10bf0 |
[video_player] Update Android to exoplayer 1.9.1 (#10904)
Updates from 1.8.0 to the just-released 1.9.1. `ExoPlayer` 1.9 is no longer trivially mockable, so I followed the [team's general guidance](https://github.com/androidx/media/issues/2985#issuecomment-3710857660) to use a real ExoPlayer in a Robolectric test instead of mocking it. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.video_player_android-v2.9.3 |
||
|
Joonas Kerttula
|
8b3e40e706 |
[google_maps_flutter_android] Add advanced markers support (#10381)
This PR adds Advanced markers support to the Android implementation of google_maps_flutter. Approved combined PR: https://github.com/flutter/packages/pull/7882 Approved and merged platform interface PR: https://github.com/flutter/packages/pull/9737 Issue: https://github.com/flutter/flutter/issues/155526 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.google_maps_flutter_android-v2.19.0 |
||
|
stuartmorgan-g
|
bbd9781475 |
[google_maps_flutter] Standardize iOS class and file names (#10964)
Fixes inconsistencies in the class and file naming in `google_maps_flutter_ios`: - Standardizes on `FGM` instead of a mix of `FGM` and the older `FLT`. - Removes `GoogleMaps` from most class names, as now that we are using `FGM` we don't need to further specific that it's related to Google Maps, and removing that makes it much easier to see the useful part of the name. - Ensures that all files have a prefix matching their class, for consistency. - Removes prefixing from all test classes and files, since tests don't need prefixes as they aren't part of client builds. Part of https://github.com/flutter/flutter/issues/102601 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.google_maps_flutter_ios_sdk10-v2.17.4 google_maps_flutter_ios-v2.17.4 google_maps_flutter_ios_sdk9-v2.17.4 |
||
|
stuartmorgan-g
|
ba4fe2aa3f |
[google_sign_in] Simply Kotlin/Java interop utils (#11011)
Replaces one-off wrappers with a templated version. While this isn't important in isolation, it sets a better precedent for us to follow for future plugins, and likely for Pigeon generation of helper utils. The "Unit" forms of the wrappers are still necessary because there's no way (AFAICT) to cause Java to infer the Unit type, since it's not a thing in Java. I've validated that the type inference on the generic is still enforcing type safety based on the inferred type. I.e., if I try to pass the wrong value type, it won't compile. Related to https://github.com/flutter/flutter/issues/158287 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.google_sign_in_android-v7.2.9 |
||
|
engine-flutter-autoroll
|
13d5f3240c |
Roll Flutter from 9bda20a11f1e to 6e4a481bdf27 (103 revisions) (#11041)
Roll Flutter from 9bda20a11f1e to 6e4a481bdf27 (103 revisions) |
||
|
stuartmorgan-g
|
0250616ede |
[ci] Update repo for 3.41 (#11017)
Updates the repo for the 3.41 stable release. This does everything in https://github.com/flutter/flutter/blob/master/docs/ecosystem/release/Updating-Packages-repo-for-a-stable-release.md except for: - The pin update, which already landed - The release action, which is https://github.com/flutter/packages/pull/11014 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. |
||
|
stuartmorgan-g
|
f83926f04c |
[ci] Update release to 3.41 (#11014)
Updates the release step to use 3.41. Part of https://github.com/flutter/flutter/blob/master/docs/ecosystem/release/Updating-Packages-repo-for-a-stable-release.md Includes a fix for an out-of-band breakage in tool unit tests, where the behavior of pubspec editing appears to be that it now normalizes final whitespace, causing some overly-picky tests to fail. The tool now: - does a better job generating test pubspecs that don't have a bunch of extra newlines, and - ignores trailing whitespace in tests checking file contents that were failing. |
||
|
Rui Craveiro
|
09104b08c3 |
[camera_avfoundation] Adds support for video stabilization (#10367)
Implements getSupportedVideoStabilizationModes() and setVideoStabilizationMode() methods in AVFoundationCamera. Address issue https://github.com/flutter/flutter/issues/89525. It is the camera_avfoundation sub-PR for https://github.com/flutter/packages/pull/7108. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.camera_avfoundation-v0.10.0 |
||
|
stuartmorgan-g
|
66cc739902 |
[google_maps_flutter] Add README section about SDK versions (#11005)
Updates the iOS section of the app-facing package's README to discuss the new `google_maps_flutter_ios_sdk*` packages and how to select between them. Also removes the Obj-C part of the delegate update example, since at this point it's extremely unlikely that new developers are using Obj-C, and if they are they are making a deliberate choice to do so and so can be reasonably expected to know how to translate to Obj-C. Fixes https://github.com/flutter/flutter/issues/146920 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.google_maps_flutter-v2.14.2 |
||
|
stuartmorgan-g
|
9cac057336 |
[url_launcher] Modernize url_launcher_ios example (#11002)
Replaces the Obj-C example app with Swift. Rather than attempt to modify the example in place, I started clean from the Swift template: - deleted the ios/ directory. - ran `flutter create --platforms=ios .` using current `stable` (3.41.0). - re-did the [RunnerUITest setup process](https://github.com/flutter/flutter/blob/master/docs/ecosystem/testing/Plugin-Tests.md#enabling-xcuitests), and swapped in the existing test files for that and RunnerTest. - ran native tests and the example app to capture the auto-migration steps for CocoaPods. In addition, I did some cleanup on the Dart part of this example, which had never been updated post-federation (since implementation package example apps are mostly not things we expect users to look at, so it's never been a priority): - Removed the canLaunch/launch anti-pattern, which was long since removed from the app-facing package. This copies the code from app-facing example to demonstrate canLaunch controlling enabling a UI element, which is how we recommend using it. - Removed all the configuration options that only ever worked on Android, since they are't relevant to an iOS example. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.url_launcher_ios-v6.4.1 |
||
|
Oleh
|
0488339fa2 |
[google_maps_flutter] Improved perfomance of clusterization (#10562)
Google Maps implementation for flutter web is invoking rendering after each added marker to cluster. It is extremely non optimal, as result app is freezing for some time in case of significant number of markers (200+, but it is more obvious for 1k+) especially if they are using images instead of default icon. As fix I am proposing to utilize method addItems of JS implementation instead of addMarker and render only as batch of markers are added. I have tested new implementation with 3k markers and before it was freezed for 15-30 seconds, now it works without any freeze at all. Fixes [#179456](https://github.com/flutter/flutter/issues/179456) ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.google_maps_flutter_web-v0.6.1 |
||
|
Bruno Corona
|
af1d610094 |
[video_player_avfoundation] Fix regression where http headers were ignored (#10991)
Fixed a regression in `2.9.1` where `httpHeaders` were ignored on iOS. Fixes https://github.com/flutter/flutter/issues/182015 **The Fix**: Updated `FVPAVFactory.m` to use `[AVURLAsset URLAssetWithURL:options:]` instead of `[AVAsset assetWithURL:]`. The previous implementation dropped the `options` dictionary containing the headers. **Verification:** Verified manually with Wireshark. * **2.9.1:** Headers missing. * **2.9.2 (Fix):** Headers present. ## Pre-Review Checklistvideo_player_avfoundation-v2.9.3 |
||
|
chunhtai
|
73dfeaa21c |
[ci] Adds more ci checks for batch release file integrity (#10859)
also opts in go_router ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. |
||
|
stuartmorgan-g
|
217729e23c |
[google_maps_flutter] Create SDK 9 and 10 packages for iOS (#10852)
Implements approach E.1b from [the design doc](https://flutter.dev/go/google-maps-spm-versioning) about SwiftPM support. The main changes are: - Adds a new `google_maps_flutter_ios_shared_code` directory which has an exact copy of almost all of the code files from `google_maps_flutter_ios`. - Adds a new `tool` directory to `google_maps_flutter_ios` (and the shared code, so that it stays in sync) with two command scripts: - `run_tests.dart`, which is automatically run by existing repo tool logic, as part of the custom tests task. This validates that for every file in `google_maps_flutter_ios_shared_code`, the corresponding file in `google_maps_flutter_ios` is identical (modulo some expected package name differences in specific cases). It lists all the files checked, to allow for easy auditing in CI output or locally about what is being shared. - `sync_shared_files.dart`, which is a helper script for local use that copies all files in the current package that have changes relative to their shared code counterparts, both to the shared copy and all other copies. This is to make the local development process less painful; for most changes, all someone has to do is work in one of the packages, and then run this script when they are done to sync those changes to all the other copies. It also logs any code files that aren't shared, to remind people adding files to take the step of adding those to the shared copy if they should be shared. - Adds two new duplicates of `google_maps_flutter_ios`, `..._sdk9` and `..._sdk10'` which are direct copies of `google_maps_ios` with very minor changes: - Anything based on the package name is changed/renamed - The podspecs are narrowed to use the relevant dependency versions and have the correct min iOS version for that SDK - Swift.package entries are added, making the packages SwiftPM-compatible - The CHANGELOGs are cleared. - The READMEs are updated to explain each package's role/behavior. There are some minor supporting changes: - The `google_maps_flutter_ios` README has been adjusted to reflect the new set of options. - Obj-C code using the Google Maps Utils package has been updated to handle differences in the package name for Obj-C (adapted from https://github.com/flutter/packages/pull/8288). I created a trampoline header to deal with this difference rather than inline the `#if` and explanation in each file. - Dart test code has been updated to use a non-shared trampoline header to localize the import diffs due to different package names to a tiny non-shared file. (We could switch this to using the file rewriting logic that I ended up having to add to `sync_shared_files.dart` later; I left it this way to minimize the number of files we have to do rewriting in, but I'm fine with either option.) - The Pigeon configuration forces a specific package name instead of auto-determining it. Pigeon currently uses the package name as part of the channel name for each call, so doing this avoids tons of unnecessary diff in the generated files. (This does mean that the different implementation packages are all using the same channel names, but that should be safe since `flutter` should only allow one of the implementations to be registered.) Once this lands and the new packages are published, I will do a follow-up PR to add a `google_maps_flutter` README discussion of how and why to use these new packages. Mostly completes https://github.com/flutter/flutter/issues/146920 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.google_maps_flutter_ios_sdk9-v2.17.3 google_maps_flutter_ios-v2.17.3 google_maps_flutter_ios_sdk10-v2.17.3 |
||
|
Kate Lovett
|
a1777bbe9c |
Update codeowners (#11004)
Updating for cupertino_icons ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. |
||
|
engine-flutter-autoroll
|
ea46450e25 |
Roll Flutter (stable) from 67323de285b0 to 44a626f4f002 (1372 revisions) (#10999)
|
||
|
stuartmorgan-g
|
d2c8969225 |
[video_player] Convert iOS unit tests to Swift (#10989)
Converts all of the native unit tests in `video_player_avfoundation` to Swift: - For the UI integration tests, it's just a direct Swift conversion. - For the unit tests, I first did a direct conversion to Swift, including ensuring that everything passed in that version, then converted from XCTest to Swift Testing. To minimize churn, I deliberately didn't address other technical debt in the tests (e.g., testing of player instances by making an entire plugin instance just to make a player). Some changes were necessary though: - Added some missing `NS_ASSUME_NONNULL_BEGIN` annotations to headers, to avoid having to deal with optional values in the Swift version of tests that couldn't ever actually be null. - Changed a utility method to take the necessary parts of `AVAssetTrack` instead of `AVAssetTrack`. The tests for that worked by subclassing `AVAssetTrack` even though it has no public initializers, which was extremely sketchy. It worked okay in Obj-C because Obj-C will let you get away with almost anything, but it doesn't compile in Swift. - Some tests that used Expectations to watch for KVO on player items extracted from the player internals have instead been changed to watch for player-level observable events. This is because I was having a lot of trouble getting KVO of `AVPlayerItem` to actually work in Swift, and rather than try to fix that when it wasn't great test design anyway, I just changed to using something that wasn't an internal detail anyway. Part of https://github.com/flutter/flutter/issues/119105 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.video_player_avfoundation-v2.9.2 |
||
|
chunhtai
|
7f35f52f74 |
[ci] updates update-release-info to support batch release (#10958)
As title ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. |
||
|
Alexander Troshkov
|
1e5019501f |
[google_maps_flutter_web] Add Advanced markers support (web) (#9773)
This PR adds Advanced markers support to the web implementation of `google_maps_flutter`. Approved combined PR: #7882 Approved and merged platform interface PR: #9737 Issue: [#155526](https://github.com/flutter/flutter/issues/155526) ## Pre-Review Checklistgoogle_maps_flutter_web-v0.6.0 |
||
|
LouiseHsu
|
20c0712f9d |
[google_sign_in_ios][UIScene] Migrate to UIScene (#10960)
Addresses https://github.com/flutter/flutter/issues/177063?issue=flutter%7Cflutter%7C174412 ## Pre-Review Checklistgoogle_sign_in_ios-v6.3.0 |
||
|
stuartmorgan-g
|
0e9252df1d |
[google_maps_flutter] Fix custom marker icons on iOS (#10993)
In https://github.com/flutter/packages/pull/10863 I intermediated asset loading through an asset loader, so that individual controllers weren't using the plugin registrar directly. In doing that, I just updated the types of the ivars, but—incorrectly—not their memory models. Registrar references are generally `weak` to avoid possible cycles (the registrar may internally be the same thing in the engine that owns the plugin instance), so the result was a weak reference to the new wrapper object. However, unlike the registrar, which has an externally enforced lifetime longer than the plugin, the wrapper was just an object created locally during map controller initialization, so was invalidated almost as soon as it was passed in. This fixes the controllers to keep strong references to the wrapper (which doesn't own anything, and has a weak registrar pointer, so can't create any cycles). Fixes https://github.com/flutter/flutter/issues/182149 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.google_maps_flutter_ios-v2.17.2 |
||
|
engine-flutter-autoroll
|
8efc4da5f8 |
Roll Flutter from e8f9dc50356d to 9bda20a11f1e (34 revisions) (#10992)
Roll Flutter from e8f9dc50356d to 9bda20a11f1e (34 revisions) |
||
|
dependabot[bot]
|
091acc58ac |
[dependabot]: Bump org.mockito.kotlin:mockito-kotlin from 6.1.0 to 6.2.3 in /packages/interactive_media_ads/android (#10983)
Bumps [org.mockito.kotlin:mockito-kotlin](https://github.com/mockito/mockito-kotlin) from 6.1.0 to 6.2.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mockito/mockito-kotlin/releases">org.mockito.kotlin:mockito-kotlin's releases</a>.</em></p> <blockquote> <h2>v6.2.3</h2> <h4>6.2.3</h4> <ul> <li>2026-01-26 - <a href="https://github.com/mockito/mockito-kotlin/compare/v6.2.2...v6.2.3">2 commit(s)</a> by Joshua Selbo, Mark Koops</li> <li>Update exception message now that onGeneric is deprecated [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/583">#583</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/583">mockito/mockito-kotlin#583</a>)</li> <li>Improve Result support in matchers and captors [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/582">#582</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/582">mockito/mockito-kotlin#582</a>)</li> </ul> <h2>v6.2.2</h2> <h4>6.2.2</h4> <ul> <li>2026-01-21 - <a href="https://github.com/mockito/mockito-kotlin/compare/v6.2.1...v6.2.2">2 commit(s)</a> by Mark Koops</li> <li>Fix eq() matcher NPE with nullable value class and null value [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/579">#579</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/579">mockito/mockito-kotlin#579</a>)</li> <li>Improve support for stubbing Result return values for synchronous and suspendable functions [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/576">#576</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/576">mockito/mockito-kotlin#576</a>)</li> </ul> <h2>v6.2.1</h2> <h4>6.2.1</h4> <ul> <li>2026-01-17 - <a href="https://github.com/mockito/mockito-kotlin/compare/v6.2.0...v6.2.1">2 commit(s)</a> by Joshua Selbo, Mark Koops</li> <li>Solve 6.2.0 regression due to runblocking being unavailable [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/575">#575</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/575">mockito/mockito-kotlin#575</a>)</li> <li>Use jvmToolchain API to configure builds [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/572">#572</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/572">mockito/mockito-kotlin#572</a>)</li> </ul> <h2>v6.2.0</h2> <h4>6.2.0</h4> <ul> <li>2026-01-14 - <a href="https://github.com/mockito/mockito-kotlin/compare/v6.1.0...v6.2.0">27 commit(s)</a> by Joshua Selbo, Mark Koops, Tim van der Lippe</li> <li>Improving stubbing support for suspend functions and value classes [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/569">#569</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/569">mockito/mockito-kotlin#569</a>)</li> <li>Update PR template to run formatting [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/568">#568</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/568">mockito/mockito-kotlin#568</a>)</li> <li>Ignore ktfmt formatting revision in git blame [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/567">#567</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/567">mockito/mockito-kotlin#567</a>)</li> <li>Enable Spotless formatting check in CI [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/566">#566</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/566">mockito/mockito-kotlin#566</a>)</li> <li>Apply ktfmt formatting [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/565">#565</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/565">mockito/mockito-kotlin#565</a>)</li> <li>Add tooling for Spotless + ktfmt [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/562">#562</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/562">mockito/mockito-kotlin#562</a>)</li> <li>Follow-up on primitive value classes [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/561">#561</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/561">mockito/mockito-kotlin#561</a>)</li> <li>Update MockSettings usage [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/560">#560</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/560">mockito/mockito-kotlin#560</a>)</li> <li>Fix anyOrNull matcher with value class wrapping primitive type [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/557">#557</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/557">mockito/mockito-kotlin#557</a>)</li> <li>Enhance/unify and document stubbing API, more groundwork towards implementing improved suspend function support [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/556">#556</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/556">mockito/mockito-kotlin#556</a>)</li> <li>Add wrappers for mockStatic, mockConstruction [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/551">#551</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/551">mockito/mockito-kotlin#551</a>)</li> <li>Add MockedStatic.verify extension fun with lambda last [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/549">#549</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/549">mockito/mockito-kotlin#549</a>)</li> <li>Extending/organizing MatchersTest.kt [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/548">#548</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/548">mockito/mockito-kotlin#548</a>)</li> <li>Adding value class support to KArgumentCaptor. [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/547">#547</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/547">mockito/mockito-kotlin#547</a>)</li> <li>Fix the output directory for the dokka Javadoc plugin [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/546">#546</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/546">mockito/mockito-kotlin#546</a>)</li> <li><a href="https://redirect.github.com/mockito/mockito-kotlin/issues/544">#544</a> Adding value class support to the eq() argument matcher. [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/545">#545</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/545">mockito/mockito-kotlin#545</a>)</li> <li>eq() argument matcher does not support for value class type arguments [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/544">#544</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/544">mockito/mockito-kotlin#544</a>)</li> <li>Add note about releasing tags via GitHub UI [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/543">#543</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/543">mockito/mockito-kotlin#543</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
engine-flutter-autoroll
|
3d5eaa507f |
Roll Flutter from f916dd6887bf to e8f9dc50356d (34 revisions) (#10979)
Roll Flutter from f916dd6887bf to e8f9dc50356d (34 revisions) |
||
|
stuartmorgan-g
|
ebacd563bf |
[quick_actions] Convert example to Swift (#10970)
Replaces the Obj-C example app with Swift. Rather than attempt to modify the example in place, I started clean from the Swift template: - deleted the ios/ directory. - ran `flutter create --platforms=ios .` using current `stable` (3.38.9). - re-did the [RunnerUITest setup process](https://github.com/flutter/flutter/blob/master/docs/ecosystem/testing/Plugin-Tests.md#enabling-xcuitests), and swapped in the existing test files for that and RunnerTest. - ran native tests and the example app to capture the auto-migration steps for CocoaPods. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. |
||
|
Robert Odrowaz
|
e68d4a800e |
[camera_avfoundation] Pigeon swift migration - part 1 (#10939)
Prepares camera package for pigeon Swift migration as part of https://github.com/flutter/flutter/issues/119109 Current implementation of `FormatUtils.selectBestFormat` overrides `MediaSettings.framesPerSecond`. With swift pigeon contracts `MediaSettings` is non mutable so that will no longer be possible. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.camera_avfoundation-v0.9.23+2 |
||
|
stuartmorgan-g
|
7805d3e2d6 |
[flutter_svg] Convert example app to Swift (#10968)
This package was imported after I did a repository-wide sweep to convert all the non-plugin examples from Obj-C to Swift, to reduce use of a deprecated template. This was done by: - deleting the ios/ directory - running `flutter create --platforms=ios .` using current `stable` (3.38.9) - deleting the RunnerTest target and source, since we will never have native tests for this ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. |
||
|
stuartmorgan-g
|
7bd2fd1274 |
[camera] Remove unused test file (#10966)
This test file doesn't appear to ever have been part of a project, so was never run, and was testing a utility method that no longer exists. |
||
|
Rick Hohler
|
749c79dc9b |
[camera_avfoundation] Handle startWriting errors (#10921)
Fixes https://github.com/flutter/flutter/issues/180048. This PR adds error handling for `AVAssetWriter.startWriting` in `camera_avfoundation`. Previously, the boolean return value was ignored, which could mask initialization errors. Now, a `FlutterError` is returned if writing fails to start. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.camera_avfoundation-v0.9.23+1 |
||
|
dependabot[bot]
|
4ec17d65f2 |
[dependabot]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.38.0 to 3.39.0 in /packages/interactive_media_ads/android (#10950)
Bumps com.google.ads.interactivemedia.v3:interactivemedia from 3.38.0 to 3.39.0. The latest update adds `@Nullable` to the SDK so the Kotlin static analysis is starting to fail where values are known nullable. See https://developers.google.com/interactive-media-ads/docs/sdks/android/client-side/history [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>interactive_media_ads-v0.3.0+10 |
||
|
engine-flutter-autoroll
|
c197455fc1 |
Roll Flutter from bf701fefec86 to f916dd6887bf (44 revisions) (#10967)
Roll Flutter from bf701fefec86 to f916dd6887bf (44 revisions) |
||
|
stuartmorgan-g
|
2b6a0b0963 |
[webview_flutter] Fix crash in iOS external native API (#10959)
Fixes a crash if `FWFWebViewFlutterWKWebViewExternalAPI`'s `webView(forIdentifier:withPluginRegistry:)` is called with a registry that doesn't contain a published webview plugin value. This can happen if the wrong object is passed in (e.g., the FlutterAppDelegate in an app that has adopted UIScene). Fixes https://github.com/flutter/flutter/issues/181865 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.webview_flutter_wkwebview-v3.23.6 |
||
|
Frank
|
3cbdacaa03 |
[google_fonts] Fix file type priority in asset path lookup (#10907)
# Description Follow-up to #10703 which added WOFF/WOFF2 support for web. The previous implementation iterated through manifest assets first, then checked file extensions. This meant if a `.ttf` file appeared before a `.woff2` file in the manifest, the `.ttf` would be selected even though `.woff2` should be preferred on web. This fix inverts the loop order to iterate by file type priority first (woff2 > woff > ttf > otf on web), ensuring the preferred format is selected regardless of manifest order. --- While working on #10703 I already looked at the specific for-loop, but not immediately notice this might be an issue. For Flutter projects with web-only support it is not; one can just include the woff2 fonts only. But for cross-platform projects it is an issue. Sample from an `assets.gen.dart` file: ```dart /// File path: assets/google_fonts/Roboto-Regular.ttf String get robotoRegularTtf => 'assets/google_fonts/Roboto-Regular.ttf'; /// File path: assets/google_fonts/Roboto-Regular.woff2 String get robotoRegularWoff2 => 'assets/google_fonts/Roboto-Regular.woff2'; ``` With the old loop, the `.ttf` would be selected, even though a better alternative (the `.woff2`) is present. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.google_fonts-v8.0.1 |
||
|
ivan-vanyusho
|
3bddf2c57e |
[camera_avfoundation] ios saving path (#10832)
## Description
Changed iOS file storage path from `documentDirectory` to `temporaryDirectory` to ensure consistency with Android where files are stored in cache directory.
## Changes
- iOS now uses `temporaryDirectory` instead of `documentDirectory` for consistency with Android
## Code changes
```swift
// Before:
let documentDirectory = FileManager.default.urls(
for: .documentDirectory,
in: .userDomainMask)[0]
// After:
let documentDirectory = FileManager.default.temporaryDirectory
```
## Issues
https://github.com/flutter/flutter/issues/166933
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
camera_avfoundation-v0.9.23
|
||
|
stuartmorgan-g
|
f4ea763b25 |
[video_player] Remove OCMock (#10932)
Adds protocols to wrap usage of many AVFoundation objects in order to eliminate OCMock from the existing tests. This intentionally doesn't wrap everything, because it's already a large change; increasing test coverage in the future will almost certainly require adding more protocols. As with other PRs following this approach, in the short term this adds fair amount of production boilerplate (all the passthrough implementations in AVFVPFactory), but in the long term that boilerplate will almost all be eliminated in favor of using Swift protocol conformance in extensions, to just graft the protocols directly onto the real objects. This also requires more manual stub/mock test objects, but it does have some advantages beyond unblocking migration to Swift tests: - In many cases the tests themselves are less verbose, because some operations like triggering callbacks is cumbersome with OCMock. - It's much clearer where the test are using real AVFoundation objects that are doing things like loading network resources. (The answer is "far more than actually need to", but I deemed fixing that out of scope for this PR. This structure should make it easier to move most tests away from real objects in future test improvement work.) As an opportunistic fix while touching a lot of files anyway, I updated all the imports to the modern module import style. Helps unblock https://github.com/flutter/flutter/issues/119105 ## Pre-Review Checklist - [x ] I read the [Tree Hygiene] page, which explains my responsibilities. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.video_player_avfoundation-v2.9.1 |
||
|
stuartmorgan-g
|
f3ee98a823 |
[google_maps_flutter] Remove use of OCMock (#10863)
Eliminates usage of OCMock in the native iOS unit tests: - Creates a protocol for image asset loading that wraps that part of the registrar and the UIImage class method to replace mocking with injecting a protocol implementation. - Creates an abstract delegate for event reporting, instead of all of the sub-controllers communicating directly with the FlutterAPI instance. - Creates an abstract delegate for tile queries, instead of all of the tile controller communicating directly with the FlutterAPI instance. - Replaces mocking of our test subclass of the Google Maps view object with slightly more logic on that existing test subclass. - Replaces mocking of our existing protocols with simple manual fakes that lets us test the same assertions. - Eliminates static mock testing of GMSCameraUpdate. Unblocks https://github.com/flutter/flutter/issues/119108 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.google_maps_flutter_ios-v2.17.1 |
||
|
Valentin Vignal
|
df85ef0f4c |
[go_router_builder] Add support for @TypedGoRouteParameter to customize parameter names (#10793)
Relates to https://github.com/flutter/flutter/issues/112152 Add support for `@TypedGoRouteParameter` to customize parameter names Needs https://github.com/flutter/packages/pull/10792 to get merged first ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.go_router_builder-v4.2.0 |
||
|
engine-flutter-autoroll
|
f07e75452d |
Roll Flutter from c305f1f7ad35 to bf701fefec86 (9 revisions) (#10957)
|
||
|
misos1
|
5b1bea87e8 |
[camera_avfoundation] handle interruptions and use single offset (#8982)
Handle interruptions of capture sessions. Stop receiving and writing video and audio samples during such interruptions to avoid synchronization issues between video and audio. Handle asynchronous error notifications posted about capture sessions. This can happen for example when there is an incoming phone call and then the camera starts recording with audio. The camera controller enters an error state and can be recovered by disposing and recreating. Use single offset for both video and audio as separate offsets can cause unsynchronized video with audio. Seems audio timestamps tend to be ignored except for the first sample (probably by the video encoder, maybe it is inherent to the video format used) so prefer audio samples for calculating offset to avoid desynchronization. Avoid errors when trying to append samples with timestamp less or equal to the previous sample by not appending them. Fix a bug when after adjusting offset the last sample time was not updated which could cause adding past offsets multiple times (this could happen for example if `videoIsDisconnected` is set to true too early after it was previously set to true). - fixes https://github.com/flutter/flutter/issues/149978 - fixes https://github.com/flutter/flutter/issues/151253 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.camera-v0.11.3+1 camera_avfoundation-v0.9.22+10 |
||
|
Valentin Vignal
|
2662b91ee9 |
[go_router] Add TypedQueryParameter annotation (#10792)
Relates to https://github.com/flutter/flutter/issues/112152 Adds `TypedGoRouteParameter` annotation ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.go_router-v17.1.0 |
||
|
Elijah Okoroh
|
5abc46ccd6 |
[local_auth_darwin][UIScene] Add UIScene lifecycle support (#10836)
Adds support for the new Apple UIScene lifecycle while maintaining backward compatibility with apps that haven't migrated yet. Fixes flutter/flutter#174411 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.local_auth_darwin-v2.0.2 |