flutter/packages
1
0
Fork 0
mirror of https://github.com/flutter/packages.git synced 2025-07-01 23:51:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_markdown] Change the way tests get screen size (#4514)

Browse Source 
As of https://github.com/flutter/flutter/pull/125003 the current method these tests use to get the screen width throws an exception, since it assumes that the first widget in the tree has certain properties. To make the test more robust, this get the width of the outmost Column, which is part of the test setup, rather than whatever the first widget is.

Unblocks the flutter->packgaes roller.
This commit is contained in:
stuartmorgan
2023-07-18 20:06:06 -07:00
committed by GitHub
parent 7f07f6655a
commit f16ba3291c
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/flutter_markdown/test/list_test.dart
View File

@ -202,7 +202,8 @@ void defineTests() {
),
);
final double screenWidth = tester.allElements.first.size!.width;
final double screenWidth =
find.byType(Column).evaluate().first.size!.width;
final double markdownBodyWidth =
find.byType(MarkdownBody).evaluate().single.size!.width;
@ -225,7 +226,8 @@ void defineTests() {
),
);
final double screenWidth = tester.allElements.first.size!.width;
final double screenWidth =
find.byType(Column).evaluate().first.size!.width;
final double markdownBodyWidth =
find.byType(MarkdownBody).evaluate().single.size!.width;