remove bottom padding. (#178)

android/app/build.gradle

@@ -50,7 +50,7 @@ android {
 
     defaultConfig {
         applicationId "com.jiaqifeng.hacki"
-        minSdkVersion 26
+        minSdkVersion 30
         targetSdkVersion 33
         versionCode flutterVersionCode.toInteger()
         versionName flutterVersionName

lib/cubits/fav/fav_cubit.dart

@@ -160,6 +160,13 @@ class FavCubit extends Cubit<FavState> {
     });
   }
 
+  void removeAll() {
+    _preferenceRepository
+      ..clearAllFavs(username: '')
+      ..clearAllFavs(username: _authBloc.state.username);
+    emit(FavState.init());
+  }
+
   void _onItemLoaded(Item item) {
     emit(
       state.copyWith(

lib/extensions/object_extension.dart

@@ -5,4 +5,15 @@ extension ObjectExtension on Object {
   void log({String identifier = ''}) {
     locator.get<Logger>().d('$identifier ${toString()}');
   }
+
+  void logInfo({String identifier = ''}) {
+    locator.get<Logger>().i('$identifier ${toString()}');
+  }
+
+  void logError({
+    String identifier = '',
+    StackTrace? stackTrace,
+  }) {
+    locator.get<Logger>().e(identifier, this, stackTrace ?? StackTrace.current);
+  }
 }

lib/models/preference.dart

@@ -31,7 +31,7 @@ abstract class Preference<T> extends Equatable with SettingsDisplayable {
       const NotificationModePreference(),
       const SwipeGesturePreference(),
       const CollapseModePreference(),
-      NavigationModePreference(),
+      const NavigationModePreference(),
       const ReaderModePreference(),
       const MarkReadStoriesModePreference(),
       const EyeCandyModePreference(),
@@ -54,8 +54,7 @@ abstract class IntPreference extends Preference<int> {
 const bool _notificationModeDefaultValue = true;
 const bool _swipeGestureModeDefaultValue = false;
 const bool _displayModeDefaultValue = true;
-const bool _navigationModeDefaultValueIOS = false;
-const bool _navigationModeDefaultValueAndroid = false;
+const bool _navigationModeDefaultValue = false;
 const bool _eyeCandyModeDefaultValue = false;
 const bool _trueDarkModeDefaultValue = false;
 const bool _readerModeDefaultValue = true;
@@ -193,12 +192,9 @@ class StoryUrlModePreference extends BooleanPreference {
 /// The value deciding whether or not user should be
 /// navigated to web view first. Defaults to false.
 class NavigationModePreference extends BooleanPreference {
-  NavigationModePreference({bool? val})
+  const NavigationModePreference({bool? val})
       : super(
-          val: val ??
-              (Platform.isAndroid
-                  ? _navigationModeDefaultValueAndroid
-                  : _navigationModeDefaultValueIOS),
+          val: val ?? _navigationModeDefaultValue,
         );
 
   @override

lib/repositories/preference_repository.dart

@@ -207,6 +207,23 @@ class PreferenceRepository {
     }
   }
 
+  Future<void> clearAllFavs({required String username}) async {
+    final String key = _getFavKey(username);
+
+    if (Platform.isIOS) {
+      await _syncedPrefs.setStringList(
+        key: key,
+        val: <String>[],
+      );
+    } else {
+      final SharedPreferences prefs = await _prefs;
+      await prefs.setStringList(
+        key,
+        <String>[],
+      );
+    }
+  }
+
   static String _getFavKey(String username) => 'fav_$username';
 
   //#endregion

lib/screens/item/widgets/more_popup_menu.dart

@@ -1,5 +1,3 @@
-import 'dart:io';
-
 import 'package:flutter/material.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:flutter_feather_icons/flutter_feather_icons.dart';
@@ -25,16 +23,8 @@ class MorePopupMenu extends StatelessWidget {
   final bool isBlocked;
   final VoidCallback onLoginTapped;
 
-  static double? _cachedStoryHeight;
-  static double? _cachedCommentHeight;
-
-  static double get storyHeight {
-    return _cachedStoryHeight ??= Platform.isIOS ? 500 : 530;
-  }
-
-  static double get commentHeight {
-    return _cachedCommentHeight ??= Platform.isIOS ? 480 : 520;
-  }
+  static const double _storySheetHeight = 500;
+  static const double _commentSheetHeight = 480;
 
   @override
   Widget build(BuildContext context) {
@@ -80,7 +70,7 @@ class MorePopupMenu extends StatelessWidget {
           final bool upvoted = voteState.vote == Vote.up;
           final bool downvoted = voteState.vote == Vote.down;
           return Container(
-            height: item is Comment ? commentHeight : storyHeight,
+            height: item is Comment ? _commentSheetHeight : _storySheetHeight,
             color: Theme.of(context).canvasColor,
             child: Material(
               color: Palette.transparent,

lib/screens/profile/widgets/settings.dart

@@ -1,6 +1,7 @@
 import 'dart:io';
 
 import 'package:adaptive_theme/adaptive_theme.dart';
+import 'package:clipboard/clipboard.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
@@ -21,7 +22,6 @@ import 'package:hacki/screens/profile/widgets/tab_bar_settings.dart';
 import 'package:hacki/screens/widgets/widgets.dart';
 import 'package:hacki/styles/styles.dart';
 import 'package:hacki/utils/utils.dart';
-import 'package:logger/logger.dart';
 import 'package:package_info_plus/package_info_plus.dart';
 import 'package:path_provider/path_provider.dart';
 import 'package:share_plus/share_plus.dart';
@@ -192,7 +192,7 @@ class _SettingsState extends State<Settings> {
                       .whereType<BooleanPreference>()
                       .where(
                         (Preference<dynamic> e) => e.isDisplayable,
-                      ))
+                      )) ...<Widget>[
                     SwitchListTile(
                       title: Text(preference.title),
                       subtitle: preference.subtitle.isNotEmpty
@@ -217,6 +217,8 @@ class _SettingsState extends State<Settings> {
                       },
                       activeColor: Palette.orange,
                     ),
+                    if (preference is StoryUrlModePreference) const Divider(),
+                  ],
                   ListTile(
                     title: const Text(
                       'Font',
@@ -229,11 +231,24 @@ class _SettingsState extends State<Settings> {
                     ),
                     onTap: showThemeSettingDialog,
                   ),
+                  const Divider(),
                   ListTile(
                     title: const Text(
-                      'Clear Data',
+                      'Export Favorites',
                     ),
-                    onTap: showClearDataDialog,
+                    onTap: onExportFavoritesTapped,
+                  ),
+                  ListTile(
+                    title: const Text(
+                      'Clear Favorites',
+                    ),
+                    onTap: showClearFavoritesDialog,
+                  ),
+                  ListTile(
+                    title: const Text(
+                      'Clear Cache',
+                    ),
+                    onTap: showClearCacheDialog,
                   ),
                   ListTile(
                     title: const Text('About'),
@@ -376,12 +391,12 @@ class _SettingsState extends State<Settings> {
     );
   }
 
-  void showClearDataDialog() {
+  void showClearCacheDialog() {
     showDialog<void>(
       context: context,
       builder: (_) {
         return AlertDialog(
-          title: const Text('Clear Data?'),
+          title: const Text('Clear Cache?'),
           content: const Text(
             'Clear all cached images, stories and comments.',
           ),
@@ -621,11 +636,64 @@ class _SettingsState extends State<Settings> {
         LinkUtil.launchInExternalBrowser(Constants.githubIssueLink);
       }
     } catch (error, stackTrace) {
-      locator.get<Logger>().e(
-            'Error caught in onGithubTapped',
-            error,
-            stackTrace,
-          );
+      error.logError(stackTrace: stackTrace);
     }
   }
+
+  Future<void> onExportFavoritesTapped() async {
+    final List<int> allFavorites = context.read<FavCubit>().state.favIds;
+
+    if (allFavorites.isEmpty) {
+      showSnackBar(content: "You don't have any favorite item.");
+      return;
+    }
+
+    try {
+      await FlutterClipboard.copy(
+        allFavorites.join('\n'),
+      ).whenComplete(HapticFeedback.selectionClick);
+      showSnackBar(content: 'Ids of favorites have been copied to clipboard.');
+    } catch (error, stackTrace) {
+      error.logError(stackTrace: stackTrace);
+    }
+  }
+
+  void showClearFavoritesDialog() {
+    showDialog<bool>(
+      context: context,
+      builder: (BuildContext context) {
+        return AlertDialog(
+          title: const Text('Remove all favorites?'),
+          content: const Text(
+            '''This will not effect favorites saved in your Hacker News account.''',
+          ),
+          actions: <Widget>[
+            TextButton(
+              onPressed: () => Navigator.pop(context),
+              child: const Text(
+                'Cancel',
+              ),
+            ),
+            TextButton(
+              onPressed: () {
+                Navigator.pop(context);
+                try {
+                  context.read<FavCubit>().removeAll();
+                  showSnackBar(content: 'All favorites have been removed.');
+                } catch (error, stackTrace) {
+                  error.logError(stackTrace: stackTrace);
+                }
+              },
+              child: const Text(
+                'Confirm',
+                style: TextStyle(
+                  color: Palette.red,
+                ),
+              ),
+            ),
+          ],
+        );
+      },
+    );
+  }
 }

lib/screens/widgets/link_preview/link_view.dart

@@ -1,10 +1,12 @@
 import 'package:cached_network_image/cached_network_image.dart';
 import 'package:flutter/material.dart';
 import 'package:hacki/config/constants.dart';
+import 'package:hacki/models/models.dart';
 import 'package:hacki/styles/styles.dart';
+import 'package:memoize/memoize.dart';
 
 class LinkView extends StatelessWidget {
-  const LinkView({
+  LinkView({
     super.key,
     required this.metadata,
     required this.url,
@@ -13,18 +15,19 @@ class LinkView extends StatelessWidget {
     required this.description,
     required this.onTap,
     required this.showMetadata,
-    required this.showUrl,
+    required bool showUrl,
+    required this.bodyMaxLines,
     this.imageUri,
     this.imagePath,
     this.titleTextStyle,
     this.bodyTextStyle,
     this.showMultiMedia = true,
     this.bodyTextOverflow,
-    this.bodyMaxLines,
     this.isIcon = false,
     this.bgColor,
     this.radius = 0,
-  }) : assert(
+  })  : showUrl = showUrl && url.isNotEmpty,
+        assert(
           !showMultiMedia ||
               (showMultiMedia && (imageUri != null || imagePath != null)),
           'imageUri or imagePath cannot be null when showMultiMedia is true',
@@ -42,14 +45,17 @@ class LinkView extends StatelessWidget {
   final TextStyle? bodyTextStyle;
   final bool showMultiMedia;
   final TextOverflow? bodyTextOverflow;
-  final int? bodyMaxLines;
+  final int bodyMaxLines;
   final bool isIcon;
   final double radius;
   final Color? bgColor;
   final bool showMetadata;
   final bool showUrl;
 
-  double computeTitleFontSize(double width) {
+  static final double Function(double) _getTitleFontSize =
+      memo1(_computeTitleFontSize);
+
+  static double _computeTitleFontSize(double width) {
     double size = width * 0.13;
     if (size > 15) {
       size = 15;
@@ -57,16 +63,26 @@ class LinkView extends StatelessWidget {
     return size;
   }
 
-  int computeTitleLines(double layoutHeight) {
+  static final int Function(double) _getTitleLines = memo1(_computeTitleLines);
+
+  static int _computeTitleLines(double layoutHeight) {
     return layoutHeight >= 100 ? 2 : 1;
   }
 
-  int computeBodyLines(double layoutHeight) {
-    int lines = 1;
-    if (layoutHeight > 40) {
-      lines += (layoutHeight - 40.0) ~/ 15.0;
-    }
-    return lines;
+  static final int Function(int, bool, bool, String?) _getBodyLines =
+      memo4(_computeBodyLines);
+
+  static int _computeBodyLines(
+    int bodyMaxLines,
+    bool showMetadata,
+    bool showUrl,
+    String? fontFamily,
+  ) {
+    final int maxLines = bodyMaxLines -
+        (showMetadata ? 1 : 0) -
+        (showUrl ? 1 : 0) +
+        (fontFamily == Font.ubuntuMono.name ? 1 : 0);
+    return maxLines;
   }
 
   @override
@@ -76,15 +92,15 @@ class LinkView extends StatelessWidget {
         final double layoutWidth = constraints.biggest.width;
         final double layoutHeight = constraints.biggest.height;
 
-        final TextStyle titleFontSize = titleTextStyle ??
+        final TextStyle titleFontStyle = titleTextStyle ??
             TextStyle(
-              fontSize: computeTitleFontSize(layoutWidth),
+              fontSize: _getTitleFontSize(layoutWidth),
               color: Palette.black,
               fontWeight: FontWeight.bold,
             );
-        final TextStyle bodyFontSize = bodyTextStyle ??
+        final TextStyle bodyFontStyle = bodyTextStyle ??
             TextStyle(
-              fontSize: computeTitleFontSize(layoutWidth) - 1,
+              fontSize: _getTitleFontSize(layoutWidth) - 1,
               color: Palette.grey,
               fontWeight: FontWeight.w400,
             );
@@ -96,7 +112,7 @@ class LinkView extends StatelessWidget {
               if (showMultiMedia)
                 Padding(
                   padding: const EdgeInsets.only(
-                    right: 5,
+                    right: 8,
                     top: 5,
                     bottom: 5,
                   ),
@@ -112,7 +128,7 @@ class LinkView extends StatelessWidget {
                             imageUrl: imageUri!,
                             fit: isIcon ? BoxFit.scaleDown : BoxFit.fitWidth,
                             memCacheHeight: layoutHeight.toInt() * 4,
-                            errorWidget: (BuildContext context, _, dynamic __) {
+                            errorWidget: (BuildContext context, _, __) {
                               return Image.asset(
                                 Constants.hackerNewsLogoPath,
                                 fit: BoxFit.cover,
@@ -124,22 +140,85 @@ class LinkView extends StatelessWidget {
               else
                 const SizedBox(width: 5),
               Expanded(
-                flex: 4,
-                child: Padding(
-                  padding: const EdgeInsets.symmetric(vertical: 3),
-                  child: Column(
-                    mainAxisAlignment: MainAxisAlignment.center,
-                    children: <Widget>[
-                      _buildTitleContainer(
-                        titleFontSize,
-                        computeTitleLines(layoutHeight),
+                child: Column(
+                  mainAxisAlignment: MainAxisAlignment.center,
+                  children: <Widget>[
+                    Padding(
+                      padding: EdgeInsets.only(
+                        top: Theme.of(context)
+                                    .textTheme
+                                    .bodyMedium
+                                    ?.fontFamily ==
+                                Font.robotoSlab.name
+                            ? 2
+                            : 4,
                       ),
-                      _buildBodyContainer(
-                        bodyFontSize,
-                        computeBodyLines(layoutHeight),
-                      )
-                    ],
-                  ),
+                      child: Column(
+                        children: <Widget>[
+                          Container(
+                            alignment: Alignment.topLeft,
+                            child: Text(
+                              title,
+                              style: titleFontStyle,
+                              overflow: TextOverflow.ellipsis,
+                              maxLines: _getTitleLines(layoutHeight),
+                            ),
+                          ),
+                          if (showUrl && url.isNotEmpty)
+                            Container(
+                              alignment: Alignment.topLeft,
+                              child: Text(
+                                '($readableUrl)',
+                                textAlign: TextAlign.left,
+                                style: titleFontStyle.copyWith(
+                                  color: Palette.grey,
+                                  fontSize: titleFontStyle.fontSize == null
+                                      ? 12
+                                      : titleFontStyle.fontSize! - 4,
+                                  fontWeight: FontWeight.w400,
+                                ),
+                                overflow:
+                                    bodyTextOverflow ?? TextOverflow.ellipsis,
+                                maxLines: 1,
+                              ),
+                            ),
+                        ],
+                      ),
+                    ),
+                    if (showMetadata)
+                      Container(
+                        alignment: Alignment.topLeft,
+                        margin: const EdgeInsets.only(top: 2),
+                        child: Text(
+                          metadata,
+                          textAlign: TextAlign.left,
+                          style: bodyFontStyle.copyWith(
+                            fontSize: bodyFontStyle.fontSize == null
+                                ? 12
+                                : bodyFontStyle.fontSize! - 2,
+                          ),
+                          overflow: bodyTextOverflow ?? TextOverflow.ellipsis,
+                          maxLines: 1,
+                        ),
+                      ),
+                    Expanded(
+                      child: Container(
+                        alignment: Alignment.topLeft,
+                        child: Text(
+                          description,
+                          textAlign: TextAlign.left,
+                          style: bodyFontStyle,
+                          overflow: bodyTextOverflow ?? TextOverflow.ellipsis,
+                          maxLines: _getBodyLines(
+                            bodyMaxLines,
+                            showMetadata,
+                            showUrl,
+                            Theme.of(context).textTheme.bodyMedium?.fontFamily,
+                          ),
+                        ),
+                      ),
+                    ),
+                  ],
                 ),
               ),
             ],
@@ -148,81 +227,4 @@ class LinkView extends StatelessWidget {
       },
     );
   }
-
-  Widget _buildTitleContainer(TextStyle titleTS, int maxLines) {
-    final bool showUrl = this.showUrl && url.isNotEmpty;
-    return Padding(
-      padding: const EdgeInsets.fromLTRB(4, 2, 3, 0),
-      child: Column(
-        children: <Widget>[
-          Container(
-            alignment: Alignment.topLeft,
-            child: Text(
-              title,
-              style: titleTS,
-              overflow: TextOverflow.ellipsis,
-              maxLines: maxLines,
-            ),
-          ),
-          if (showUrl)
-            Container(
-              alignment: Alignment.topLeft,
-              child: Text(
-                '($readableUrl)',
-                textAlign: TextAlign.left,
-                style: titleTS.copyWith(
-                  color: Palette.grey,
-                  fontSize:
-                      titleTS.fontSize == null ? 12 : titleTS.fontSize! - 4,
-                  fontWeight: FontWeight.w400,
-                ),
-                overflow: bodyTextOverflow ?? TextOverflow.ellipsis,
-                maxLines: 1,
-              ),
-            ),
-        ],
-      ),
-    );
-  }
-
-  Widget _buildBodyContainer(TextStyle bodyTS, int maxLines) {
-    return Expanded(
-      flex: 2,
-      child: Padding(
-        padding: const EdgeInsets.fromLTRB(5, 2, 5, 0),
-        child: Column(
-          children: <Widget>[
-            if (showMetadata)
-              Container(
-                alignment: Alignment.topLeft,
-                child: Text(
-                  metadata,
-                  textAlign: TextAlign.left,
-                  style: bodyTS.copyWith(
-                    fontSize:
-                        bodyTS.fontSize == null ? 12 : bodyTS.fontSize! - 2,
-                  ),
-                  overflow: bodyTextOverflow ?? TextOverflow.ellipsis,
-                  maxLines: 1,
-                ),
-              ),
-            Expanded(
-              child: Container(
-                alignment: Alignment.topLeft,
-                child: Text(
-                  description,
-                  textAlign: TextAlign.left,
-                  style: bodyTS,
-                  overflow: bodyTextOverflow ?? TextOverflow.ellipsis,
-                  maxLines: (bodyMaxLines ?? maxLines) -
-                      (showMetadata ? 1 : 0) -
-                      (showUrl && url.isNotEmpty ? 1 : 0),
-                ),
-              ),
-            ),
-          ],
-        ),
-      ),
-    );
-  }
 }

pubspec.lock

@@ -600,6 +600,14 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "0.2.0"
+  memoize:
+    dependency: "direct main"
+    description:
+      name: memoize
+      sha256: "51481d328c86cbdc59711369179bac88551ca0556569249be5317e66fc796cac"
+      url: "https://pub.dev"
+    source: hosted
+    version: "3.0.0"
   meta:
     dependency: transitive
     description:

pubspec.yaml

@@ -1,6 +1,6 @@
 name: hacki
 description: A Hacker News reader.
-version: 1.2.4+97
+version: 1.3.0+99
 publish_to: none
 
 environment:
@@ -45,6 +45,7 @@ dependencies:
   intl: ^0.18.0
   linkify: ^4.1.0
   logger: ^1.1.0
+  memoize: ^3.0.0
   package_info_plus: ^3.0.3
   path: ^1.8.2
   path_provider: ^2.0.12