Compare commits

..

5 Commits

Author SHA1 Message Date
459ab961d1 v0.2.19 hotfix (#52)
* improved offline mode.

* bumped version.

* reset stories count on download event.

* fixed overflow.
2022-06-18 23:40:56 -07:00
362d7005df fixed jank while exiting story screen. 2022-06-18 11:44:34 -07:00
6b7c1d42de fixed offline mode. 2022-06-18 02:38:31 -07:00
2a889bca56 v0.2.19 (#51)
* improved comments loading.

* added web page caching to offline mode.

* improved offline webview.

* fixed web analyzer.

* updated description.
2022-06-18 02:18:03 -07:00
e25026f129 created FUNDING.yml 2022-06-17 21:25:24 -07:00
26 changed files with 509 additions and 419 deletions

13
.github/FUNDING.yml vendored Normal file
View File

@ -0,0 +1,13 @@
# These are supported funding model platforms
github: livinglist
patreon: # Replace with a single Patreon username
open_collective: # Replace with a single Open Collective username
ko_fi: # Replace with a single Ko-fi username
tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel
community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
liberapay: jfeng_for_open_source
issuehunt: # Replace with a single IssueHunt username
otechie: # Replace with a single Otechie username
lfx_crowdfunding: # Replace with a single LFX Crowdfunding project-name e.g., cloud-foundry
custom: # Replace with up to 4 custom sponsorship URLs e.g., ['link1', 'link2']

Binary file not shown.

Before

Width:  |  Height:  |  Size: 313 KiB

After

Width:  |  Height:  |  Size: 390 KiB

View File

@ -0,0 +1 @@
- Offline mode now includes web pages.

View File

@ -0,0 +1 @@
- Offline mode now includes web pages.

View File

@ -0,0 +1 @@
- Offline mode now includes web pages.

Binary file not shown.

Before

Width:  |  Height:  |  Size: 313 KiB

After

Width:  |  Height:  |  Size: 390 KiB

View File

@ -36,8 +36,6 @@ PODS:
- Flutter
- url_launcher_ios (0.0.1):
- Flutter
- video_player_avfoundation (0.0.1):
- Flutter
- wakelock (0.0.1):
- Flutter
- webview_flutter_wkwebview (0.0.1):
@ -59,7 +57,6 @@ DEPENDENCIES:
- sqflite (from `.symlinks/plugins/sqflite/ios`)
- synced_shared_preferences (from `.symlinks/plugins/synced_shared_preferences/ios`)
- url_launcher_ios (from `.symlinks/plugins/url_launcher_ios/ios`)
- video_player_avfoundation (from `.symlinks/plugins/video_player_avfoundation/ios`)
- wakelock (from `.symlinks/plugins/wakelock/ios`)
- webview_flutter_wkwebview (from `.symlinks/plugins/webview_flutter_wkwebview/ios`)
- workmanager (from `.symlinks/plugins/workmanager/ios`)
@ -97,8 +94,6 @@ EXTERNAL SOURCES:
:path: ".symlinks/plugins/synced_shared_preferences/ios"
url_launcher_ios:
:path: ".symlinks/plugins/url_launcher_ios/ios"
video_player_avfoundation:
:path: ".symlinks/plugins/video_player_avfoundation/ios"
wakelock:
:path: ".symlinks/plugins/wakelock/ios"
webview_flutter_wkwebview:
@ -123,7 +118,6 @@ SPEC CHECKSUMS:
sqflite: 6d358c025f5b867b29ed92fc697fd34924e11904
synced_shared_preferences: f722742b06d65c7315b8e9f56b794c9fbd5597f7
url_launcher_ios: 839c58cdb4279282219f5e248c3321761ff3c4de
video_player_avfoundation: e489aac24ef5cf7af82702979ed16f2a5ef84cff
wakelock: d0fc7c864128eac40eba1617cb5264d9c940b46f
webview_flutter_wkwebview: b7e70ef1ddded7e69c796c7390ee74180182971f
workmanager: 0afdcf5628bbde6924c21af7836fed07b42e30e6

View File

@ -568,7 +568,7 @@
CODE_SIGN_ENTITLEMENTS = Runner/Runner.entitlements;
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 5;
DEVELOPMENT_TEAM = QMWX3X2NF7;
ENABLE_BITCODE = NO;
INFOPLIST_FILE = Runner/Info.plist;
@ -577,7 +577,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 0.2.18;
MARKETING_VERSION = 0.2.19;
PRODUCT_BUNDLE_IDENTIFIER = com.jiaqi.hacki;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
@ -705,7 +705,7 @@
CODE_SIGN_ENTITLEMENTS = Runner/Runner.entitlements;
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 5;
DEVELOPMENT_TEAM = QMWX3X2NF7;
ENABLE_BITCODE = NO;
INFOPLIST_FILE = Runner/Info.plist;
@ -714,7 +714,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 0.2.18;
MARKETING_VERSION = 0.2.19;
PRODUCT_BUNDLE_IDENTIFIER = com.jiaqi.hacki;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
@ -736,7 +736,7 @@
CODE_SIGN_ENTITLEMENTS = Runner/Runner.entitlements;
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 5;
DEVELOPMENT_TEAM = QMWX3X2NF7;
ENABLE_BITCODE = NO;
INFOPLIST_FILE = Runner/Info.plist;
@ -745,7 +745,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 0.2.18;
MARKETING_VERSION = 0.2.19;
PRODUCT_BUNDLE_IDENTIFIER = com.jiaqi.hacki;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";

View File

@ -32,6 +32,7 @@ class StoriesBloc extends Bloc<StoriesEvent, StoriesState> {
on<StoryRead>(onStoryRead);
on<StoriesLoaded>(onStoriesLoaded);
on<StoriesDownload>(onDownload);
on<StoryDownloaded>(onStoryDownloaded);
on<StoriesExitOffline>(onExitOffline);
on<StoriesPageSizeChanged>(onPageSizeChanged);
on<ClearAllReadStories>(onClearAllReadStories);
@ -244,35 +245,48 @@ class StoriesBloc extends Bloc<StoriesEvent, StoriesState> {
await _cacheRepository.deleteAllStories();
await _cacheRepository.deleteAllComments();
final Set<int> allIds = <int>{};
final Set<int> prioritizedIds = <int>{};
final List<StoryType> prioritizedTypes = <StoryType>[...types]
..remove(StoryType.latest);
for (final StoryType type in types) {
for (final StoryType type in prioritizedTypes) {
final List<int> ids = await _storiesRepository.fetchStoryIds(of: type);
await _cacheRepository.cacheStoryIds(of: type, ids: ids);
allIds.addAll(ids);
prioritizedIds.addAll(ids);
}
emit(
state.copyWith(
storiesDownloaded: 0,
storiesToBeDownloaded: prioritizedIds.length,
),
);
try {
_storiesRepository
.fetchStoriesStream(ids: allIds.toList())
.listen((Story story) async {
if (story.kids.isNotEmpty) {
await _cacheRepository.cacheStory(story: story);
_storiesRepository
.fetchAllChildrenComments(ids: story.kids)
.listen((Comment? comment) async {
if (comment != null) {
await _cacheRepository.cacheComment(comment: comment);
}
});
}
}).onDone(() {
emit(
state.copyWith(
downloadStatus: StoriesDownloadStatus.finished,
),
);
});
await fetchAndCacheStories(
prioritizedIds,
includingWebPage: event.includingWebPage,
isPrioritized: true,
);
final Set<int> latestIds = <int>{};
final List<int> ids = await _storiesRepository.fetchStoryIds(
of: StoryType.latest,
);
await _cacheRepository.cacheStoryIds(of: StoryType.latest, ids: ids);
latestIds.addAll(ids);
await fetchAndCacheStories(
latestIds,
includingWebPage: event.includingWebPage,
isPrioritized: false,
);
emit(
state.copyWith(
downloadStatus: StoriesDownloadStatus.finished,
),
);
} catch (_) {
emit(
state.copyWith(
@ -282,6 +296,71 @@ class StoriesBloc extends Bloc<StoriesEvent, StoriesState> {
}
}
Future<void> fetchAndCacheStories(
Iterable<int> ids, {
required bool includingWebPage,
required bool isPrioritized,
}) async {
for (final int id in ids) {
final Story? story = await _storiesRepository.fetchStoryBy(id);
if (story == null) {
if (isPrioritized) {
add(StoryDownloaded(skipped: true));
}
continue;
}
if (story.kids.isEmpty) {
if (isPrioritized) {
add(StoryDownloaded(skipped: true));
}
continue;
}
await _cacheRepository.cacheStory(story: story);
if (story.url.isNotEmpty && includingWebPage) {
await _cacheRepository.cacheUrl(url: story.url);
}
final Completer<void> completer = Completer<void>();
_storiesRepository
.fetchAllChildrenComments(ids: story.kids)
.listen((Comment? comment) async {
if (comment != null) {
await _cacheRepository.cacheComment(comment: comment);
}
}).onDone(() {
completer.complete();
add(StoryDownloaded(skipped: false));
});
await completer.future;
}
}
void onStoryDownloaded(StoryDownloaded event, Emitter<StoriesState> emit) {
if (event.skipped) {
emit(
state.copyWith(
storiesToBeDownloaded: state.storiesToBeDownloaded - 1,
),
);
} else {
final int updatedStoriesDownloaded = state.storiesDownloaded + 1;
emit(
state.copyWith(
storiesDownloaded: updatedStoriesDownloaded,
storiesToBeDownloaded:
updatedStoriesDownloaded > state.storiesToBeDownloaded
? state.storiesToBeDownloaded + 1
: state.storiesToBeDownloaded,
),
);
}
}
Future<void> onPageSizeChanged(
StoriesPageSizeChanged event,
Emitter<StoriesState> emit,
@ -297,6 +376,7 @@ class StoriesBloc extends Bloc<StoriesEvent, StoriesState> {
await _cacheRepository.deleteAllStoryIds();
await _cacheRepository.deleteAllStories();
await _cacheRepository.deleteAllComments();
await _cacheRepository.deleteAllWebPages();
emit(state.copyWith(offlineReading: false));
add(StoriesInitialize());
}

View File

@ -38,8 +38,21 @@ class StoriesLoadMore extends StoriesEvent {
}
class StoriesDownload extends StoriesEvent {
StoriesDownload({required this.includingWebPage});
final bool includingWebPage;
@override
List<Object?> get props => <Object?>[];
List<Object?> get props => <Object?>[includingWebPage];
}
class StoryDownloaded extends StoriesEvent {
StoryDownloaded({required this.skipped});
final bool skipped;
@override
List<Object?> get props => <Object?>[skipped];
}
class StoriesExitOffline extends StoriesEvent {

View File

@ -23,6 +23,8 @@ class StoriesState extends Equatable {
required this.offlineReading,
required this.downloadStatus,
required this.currentPageSize,
required this.storiesDownloaded,
required this.storiesToBeDownloaded,
});
const StoriesState.init({
@ -61,7 +63,9 @@ class StoriesState extends Equatable {
}) : offlineReading = false,
downloadStatus = StoriesDownloadStatus.initial,
currentPageSize = 0,
readStoriesIds = const <int>{};
readStoriesIds = const <int>{},
storiesDownloaded = 0,
storiesToBeDownloaded = 0;
final Map<StoryType, List<Story>> storiesByType;
final Map<StoryType, List<int>> storyIdsByType;
@ -71,6 +75,8 @@ class StoriesState extends Equatable {
final StoriesDownloadStatus downloadStatus;
final bool offlineReading;
final int currentPageSize;
final int storiesDownloaded;
final int storiesToBeDownloaded;
StoriesState copyWith({
Map<StoryType, List<Story>>? storiesByType,
@ -81,6 +87,8 @@ class StoriesState extends Equatable {
StoriesDownloadStatus? downloadStatus,
bool? offlineReading,
int? currentPageSize,
int? storiesDownloaded,
int? storiesToBeDownloaded,
}) {
return StoriesState(
storiesByType: storiesByType ?? this.storiesByType,
@ -91,6 +99,9 @@ class StoriesState extends Equatable {
offlineReading: offlineReading ?? this.offlineReading,
downloadStatus: downloadStatus ?? this.downloadStatus,
currentPageSize: currentPageSize ?? this.currentPageSize,
storiesDownloaded: storiesDownloaded ?? this.storiesDownloaded,
storiesToBeDownloaded:
storiesToBeDownloaded ?? this.storiesToBeDownloaded,
);
}
@ -102,18 +113,12 @@ class StoriesState extends Equatable {
final Map<StoryType, List<Story>> newMap =
Map<StoryType, List<Story>>.from(storiesByType);
newMap[of] = List<Story>.from(newMap[of]!)..add(story);
return StoriesState(
return copyWith(
storiesByType: newMap,
storyIdsByType: storyIdsByType,
statusByType: statusByType,
currentPageByType: currentPageByType,
readStoriesIds: <int>{
...readStoriesIds,
if (hasRead) story.id,
},
offlineReading: offlineReading,
downloadStatus: downloadStatus,
currentPageSize: currentPageSize,
);
}
@ -124,15 +129,8 @@ class StoriesState extends Equatable {
final Map<StoryType, List<int>> newMap =
Map<StoryType, List<int>>.from(storyIdsByType);
newMap[of] = to;
return StoriesState(
storiesByType: storiesByType,
return copyWith(
storyIdsByType: newMap,
statusByType: statusByType,
currentPageByType: currentPageByType,
readStoriesIds: readStoriesIds,
offlineReading: offlineReading,
downloadStatus: downloadStatus,
currentPageSize: currentPageSize,
);
}
@ -143,15 +141,8 @@ class StoriesState extends Equatable {
final Map<StoryType, StoriesStatus> newMap =
Map<StoryType, StoriesStatus>.from(statusByType);
newMap[of] = to;
return StoriesState(
storiesByType: storiesByType,
storyIdsByType: storyIdsByType,
return copyWith(
statusByType: newMap,
currentPageByType: currentPageByType,
readStoriesIds: readStoriesIds,
offlineReading: offlineReading,
downloadStatus: downloadStatus,
currentPageSize: currentPageSize,
);
}
@ -162,15 +153,8 @@ class StoriesState extends Equatable {
final Map<StoryType, int> newMap =
Map<StoryType, int>.from(currentPageByType);
newMap[of] = to;
return StoriesState(
storiesByType: storiesByType,
storyIdsByType: storyIdsByType,
statusByType: statusByType,
return copyWith(
currentPageByType: newMap,
readStoriesIds: readStoriesIds,
offlineReading: offlineReading,
downloadStatus: downloadStatus,
currentPageSize: currentPageSize,
);
}
@ -187,15 +171,11 @@ class StoriesState extends Equatable {
final Map<StoryType, int> newCurrentPageMap =
Map<StoryType, int>.from(currentPageByType);
newCurrentPageMap[of] = 0;
return StoriesState(
return copyWith(
storiesByType: newStoriesMap,
storyIdsByType: newStoryIdsMap,
statusByType: newStatusMap,
currentPageByType: newCurrentPageMap,
readStoriesIds: readStoriesIds,
offlineReading: offlineReading,
downloadStatus: downloadStatus,
currentPageSize: currentPageSize,
);
}
@ -209,5 +189,7 @@ class StoriesState extends Equatable {
offlineReading,
downloadStatus,
currentPageSize,
storiesDownloaded,
storiesToBeDownloaded,
];
}

View File

@ -9,6 +9,7 @@ abstract class Constants {
'https://apps.apple.com/us/app/hacki/id1602043763?action=write-review';
static const String googlePlayLink =
'https://play.google.com/store/apps/details?id=com.jiaqifeng.hacki&hl=en_US&gl=US';
static const String sponsorLink = 'https://github.com/sponsors/Livinglist';
static const String _imagePath = 'assets/images';
static const String hackerNewsLogoPath = '$_imagePath/hacker_news_logo.png';

View File

@ -178,7 +178,11 @@ class CommentsCubit extends Cubit<CommentsState> {
if (updatedComments.length >= _pageSize + _pageSize * state.currentPage &&
updatedComments.length <=
_pageSize * 2 + _pageSize * state.currentPage) {
_streamSubscription?.pause();
final bool isHidden = _cacheService.isHidden(comment.id);
if (!isHidden) {
_streamSubscription?.pause();
}
emit(
state.copyWith(

View File

@ -1,5 +1,7 @@
import 'package:flutter/foundation.dart';
import 'package:hacki/models/models.dart';
import 'package:hive/hive.dart';
import 'package:http/http.dart';
/// [CacheRepository] is for storing stories and comments for offline reading.
/// It's using [Hive] as its database which is being stored in temp directory.
@ -7,19 +9,23 @@ class CacheRepository {
CacheRepository({
Future<Box<List<int>>>? storyIdBox,
Future<Box<Map<dynamic, dynamic>>>? storyBox,
Future<Box<String>>? webPageBox,
Future<LazyBox<Map<dynamic, dynamic>>>? commentBox,
}) : _storyIdBox = storyIdBox ?? Hive.openBox<List<int>>(_storyIdBoxName),
_storyBox =
storyBox ?? Hive.openBox<Map<dynamic, dynamic>>(_storyBoxName),
_webPageBox = webPageBox ?? Hive.openBox<String>(_webPageBoxName),
_commentBox = commentBox ??
Hive.openLazyBox<Map<dynamic, dynamic>>(_commentBoxName);
static const String _storyIdBoxName = 'storyIdBox';
static const String _storyBoxName = 'storyBox';
static const String _commentBoxName = 'commentBox';
static const String _webPageBoxName = 'webPageBox';
final Future<Box<List<int>>> _storyIdBox;
final Future<Box<Map<dynamic, dynamic>>> _storyBox;
final Future<LazyBox<Map<dynamic, dynamic>>> _commentBox;
final Future<Box<String>> _webPageBox;
Future<bool> get hasCachedStories =>
_storyBox.then((Box<Map<dynamic, dynamic>> box) => box.isNotEmpty);
@ -37,6 +43,22 @@ class CacheRepository {
return box.put(story.id.toString(), story.toJson());
}
Future<void> cacheUrl({required String url}) async {
final Box<String> box = await _webPageBox;
final String html = await compute(downloadWebPage, url);
return box.put(url, html);
}
Future<String?> getHtml({required String url}) async {
final Box<String> box = await _webPageBox;
return box.get(url);
}
Future<bool> hasCachedWebPage({required String url}) async {
final Box<String> box = await _webPageBox;
return box.containsKey(url);
}
Future<List<int>> getCachedStoryIds({required StoryType of}) async {
final Box<List<int>> box = await _storyIdBox;
final List<int>? ids = box.get(of.name);
@ -119,9 +141,27 @@ class CacheRepository {
return box.clear();
}
Future<int> deleteAllWebPages() async {
final Box<String> box = await _webPageBox;
return box.clear();
}
Future<int> deleteAll() async {
return deleteAllStoryIds()
.whenComplete(deleteAllStories)
.whenComplete(deleteAllComments);
.whenComplete(deleteAllComments)
.whenComplete(deleteAllWebPages);
}
static Future<String> downloadWebPage(String link) async {
try {
final Client client = Client();
final Uri url = Uri.parse(link);
final Response response = await client.get(url);
final String body = response.body;
return body;
} catch (_) {
return '''Web page not available.''';
}
}
}

View File

@ -62,11 +62,14 @@ class _HomeScreenState extends State<HomeScreen>
@override
void didPopNext() {
super.didPopNext();
if (context.read<StoriesBloc>().deviceScreenType ==
DeviceScreenType.mobile) {
cacheService.resetCollapsedComments();
Future<void>.delayed(
const Duration(milliseconds: 500),
cacheService.resetCollapsedComments,
);
}
super.didPopNext();
}
@override
@ -390,8 +393,12 @@ class _HomeScreenState extends State<HomeScreen>
}
}
if (!offlineReading && (isJobWithLink || (showWebFirst && !hasRead))) {
LinkUtil.launch(story.url, useReader: useReader);
if (story.url.isNotEmpty && (isJobWithLink || (showWebFirst && !hasRead))) {
LinkUtil.launch(
story.url,
useReader: useReader,
offlineReading: offlineReading,
);
}
context.read<StoriesBloc>().add(

View File

@ -5,6 +5,7 @@ import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:flutter_bloc/flutter_bloc.dart';
import 'package:flutter_cache_manager/flutter_cache_manager.dart';
import 'package:flutter_feather_icons/flutter_feather_icons.dart';
import 'package:font_awesome_flutter/font_awesome_flutter.dart';
import 'package:hacki/blocs/blocs.dart';
import 'package:hacki/config/constants.dart';
@ -407,7 +408,7 @@ class _ProfileScreenState extends State<ProfileScreen>
showAboutDialog(
context: context,
applicationName: 'Hacki',
applicationVersion: 'v0.2.18',
applicationVersion: 'v0.2.19',
applicationIcon: ClipRRect(
borderRadius: const BorderRadius.all(
Radius.circular(12),
@ -447,7 +448,7 @@ class _ProfileScreenState extends State<ProfileScreen>
SizedBox(
width: 12,
),
Text('Source Code'),
Text('Source code'),
],
),
),
@ -465,7 +466,23 @@ class _ProfileScreenState extends State<ProfileScreen>
SizedBox(
width: 12,
),
Text('Like the App?'),
Text('Like the app?'),
],
),
),
ElevatedButton(
onPressed: () => LinkUtil.launch(
Constants.sponsorLink,
),
child: Row(
children: const <Widget>[
Icon(
FeatherIcons.coffee,
),
SizedBox(
width: 12,
),
Text('Buy me a coffee'),
],
),
),
@ -648,11 +665,11 @@ class _ProfileScreenState extends State<ProfileScreen>
child: const Text(
'Cancel',
style: TextStyle(
color: Colors.red,
color: Colors.orange,
),
),
),
ElevatedButton(
TextButton(
onPressed: () {
Navigator.pop(context);
locator
@ -671,15 +688,8 @@ class _ProfileScreenState extends State<ProfileScreen>
showSnackBar(content: 'Data cleared!');
});
},
style: ButtonStyle(
backgroundColor: MaterialStateProperty.all(Colors.deepOrange),
),
child: const Text(
'Yes',
style: TextStyle(
fontWeight: FontWeight.bold,
color: Colors.white,
),
),
),
],
@ -855,9 +865,6 @@ class _ProfileScreenState extends State<ProfileScreen>
},
child: const Text(
'Cancel',
style: TextStyle(
color: Colors.red,
),
),
),
ElevatedButton(
@ -909,63 +916,30 @@ class _ProfileScreenState extends State<ProfileScreen>
context: context,
barrierDismissible: false,
builder: (BuildContext context) {
return SimpleDialog(
children: <Widget>[
...<Widget>[
const SizedBox(
height: 16,
return AlertDialog(
content: Text(
'Log out as ${authBloc.state.username}?',
style: const TextStyle(
fontSize: 16,
),
),
actions: <Widget>[
TextButton(
onPressed: () => Navigator.pop(context),
child: const Text(
'Cancel',
),
Padding(
padding: const EdgeInsets.symmetric(
horizontal: 18,
),
child: Text(
'Log out as ${authBloc.state.username}?',
style: const TextStyle(
fontSize: 16,
),
),
),
TextButton(
onPressed: () {
Navigator.pop(context);
context.read<AuthBloc>().add(AuthLogout());
context.read<HistoryCubit>().reset();
},
child: const Text(
'Log out',
),
const SizedBox(
height: 16,
),
Padding(
padding: const EdgeInsets.only(
right: 12,
),
child: ButtonBar(
children: <Widget>[
TextButton(
onPressed: () => Navigator.pop(context),
child: const Text(
'Cancel',
style: TextStyle(
color: Colors.red,
),
),
),
ElevatedButton(
onPressed: () {
Navigator.pop(context);
context.read<AuthBloc>().add(AuthLogout());
context.read<HistoryCubit>().reset();
},
style: ButtonStyle(
backgroundColor:
MaterialStateProperty.all(Colors.deepOrange),
),
child: const Text(
'Log out',
style: TextStyle(
fontWeight: FontWeight.bold,
color: Colors.white,
),
),
),
],
),
),
],
),
],
);
},

View File

@ -14,12 +14,15 @@ class OfflineListTile extends StatelessWidget {
listenWhen: (StoriesState previous, StoriesState current) =>
previous.downloadStatus != current.downloadStatus,
listener: (BuildContext context, StoriesState state) {
if (state.downloadStatus == StoriesDownloadStatus.failure) {
if (state.downloadStatus == StoriesDownloadStatus.failure ||
state.downloadStatus == StoriesDownloadStatus.finished) {
Wakelock.disable();
}
},
buildWhen: (StoriesState previous, StoriesState current) =>
previous.downloadStatus != current.downloadStatus,
previous.downloadStatus != current.downloadStatus ||
previous.storiesDownloaded != current.storiesDownloaded ||
previous.storiesToBeDownloaded != current.storiesToBeDownloaded,
builder: (BuildContext context, StoriesState state) {
final bool downloading =
state.downloadStatus == StoriesDownloadStatus.downloading;
@ -41,19 +44,53 @@ class OfflineListTile extends StatelessWidget {
return ListTile(
title: Text(
downloading ? 'Downloading All Stories...' : 'Download All Stories',
downloading
? '''Downloading All Stories (${state.storiesDownloaded}/${state.storiesToBeDownloaded})'''
: 'Download All Stories',
),
subtitle: const Text(
'download all latest stories that have at least one comment '
"for offline reading. (web page won't be downloaded)",
'for offline reading. (Please keep Hacki in foreground while '
'downloading.)',
),
trailing: trailingWidget,
isThreeLine: true,
onTap: () {
if (state.downloadStatus == StoriesDownloadStatus.downloading) {
return;
}
Connectivity().checkConnectivity().then((ConnectivityResult res) {
if (res != ConnectivityResult.none) {
Wakelock.enable();
context.read<StoriesBloc>().add(StoriesDownload());
showDialog<bool>(
context: context,
builder: (BuildContext context) => AlertDialog(
title: const Text('Download web pages as well?'),
content: const Text('It will take longer time.'),
actions: <Widget>[
TextButton(
onPressed: () => Navigator.pop(context),
child: const Text('Cancel'),
),
TextButton(
onPressed: () => Navigator.pop(context, false),
child: const Text('No'),
),
TextButton(
onPressed: () => Navigator.pop(context, true),
child: const Text('Yes'),
),
],
),
).then((bool? includeWebPage) {
if (includeWebPage != null) {
Wakelock.enable();
context.read<StoriesBloc>().add(
StoriesDownload(
includingWebPage: includeWebPage,
),
);
}
});
}
});
},

View File

@ -3,3 +3,4 @@ export 'profile/profile_screen.dart';
export 'search/search_screen.dart';
export 'story/story_screen.dart';
export 'submit/submit_screen.dart';
export 'web_view/web_view_screen.dart';

View File

@ -353,6 +353,10 @@ class _StoryScreenState extends State<StoryScreen> {
.read<PreferenceCubit>()
.state
.useReader,
offlineReading: context
.read<StoriesBloc>()
.state
.offlineReading,
),
child: Padding(
padding: const EdgeInsets.only(
@ -417,10 +421,13 @@ class _StoryScreenState extends State<StoryScreen> {
height: 0,
),
if (state.onlyShowTargetComment) ...<Widget>[
TextButton(
onPressed: () =>
context.read<CommentsCubit>().loadAll(widget.story),
child: const Text('View all comments'),
Center(
child: TextButton(
onPressed: () => context
.read<CommentsCubit>()
.loadAll(widget.story),
child: const Text('View all comments'),
),
),
const Divider(
height: 0,
@ -623,6 +630,7 @@ class _StoryScreenState extends State<StoryScreen> {
builder: (BuildContext context, TimeMachineState state) {
return Center(
child: Material(
color: Theme.of(context).canvasColor,
borderRadius: const BorderRadius.all(Radius.circular(4)),
child: SizedBox(
height: size.height * 0.8,
@ -781,50 +789,45 @@ class _StoryScreenState extends State<StoryScreen> {
showDialog<void>(
context: context,
builder: (BuildContext context) =>
SimpleDialog(
AlertDialog(
title: Text('About ${state.user.id}'),
contentPadding: const EdgeInsets.symmetric(
horizontal: 24,
vertical: 12,
),
children: <Widget>[
SelectableLinkify(
text: HtmlUtil.parseHtml(
state.user.about,
),
linkStyle: const TextStyle(
color: Colors.orange,
),
onOpen: (LinkableElement link) {
if (link.url.contains(
'news.ycombinator.com/item',
)) {
onStoryLinkTapped.call(link.url);
} else {
LinkUtil.launch(link.url);
}
},
),
ButtonBar(
children: <Widget>[
ElevatedButton(
onPressed: () =>
Navigator.pop(context),
style: ButtonStyle(
backgroundColor:
MaterialStateProperty.all(
Colors.deepOrange,
content: state.user.about.isEmpty
? Row(
mainAxisAlignment:
MainAxisAlignment.center,
children: const <Widget>[
Text(
'empty',
style: TextStyle(
color: Colors.grey,
),
),
],
)
: SelectableLinkify(
text: HtmlUtil.parseHtml(
state.user.about,
),
child: const Text(
'Okay',
style: TextStyle(
fontWeight: FontWeight.bold,
color: Colors.white,
),
linkStyle: const TextStyle(
color: Colors.orange,
),
onOpen: (LinkableElement link) {
if (link.url.contains(
'news.ycombinator.com/item',
)) {
onStoryLinkTapped
.call(link.url);
} else {
LinkUtil.launch(link.url);
}
},
),
],
actions: <Widget>[
TextButton(
onPressed: () => Navigator.pop(context),
child: const Text(
'Okay',
),
),
],
),
@ -942,53 +945,25 @@ class _StoryScreenState extends State<StoryScreen> {
showDialog<bool>(
context: context,
builder: (BuildContext context) {
return SimpleDialog(
return AlertDialog(
title: const Text('Flag this comment?'),
children: <Widget>[
Padding(
padding: const EdgeInsets.only(
left: 24,
right: 12,
),
child: Text(
'Flag this comment posted by ${item.by}?',
style: const TextStyle(
color: Colors.grey,
),
content: Text(
'Flag this comment posted by ${item.by}?',
style: const TextStyle(
color: Colors.grey,
),
),
actions: <Widget>[
TextButton(
onPressed: () => Navigator.pop(context, false),
child: const Text(
'Cancel',
),
),
Padding(
padding: const EdgeInsets.only(
right: 12,
),
child: ButtonBar(
children: <Widget>[
TextButton(
onPressed: () => Navigator.pop(context, false),
child: const Text(
'Cancel',
style: TextStyle(
color: Colors.red,
),
),
),
ElevatedButton(
onPressed: () {
Navigator.pop(context, true);
},
style: ButtonStyle(
backgroundColor:
MaterialStateProperty.all(Colors.deepOrange),
),
child: const Text(
'Yes',
style: TextStyle(
fontWeight: FontWeight.bold,
color: Colors.white,
),
),
),
],
TextButton(
onPressed: () => Navigator.pop(context, true),
child: const Text(
'Yes',
),
),
],
@ -1006,55 +981,27 @@ class _StoryScreenState extends State<StoryScreen> {
showDialog<bool>(
context: context,
builder: (BuildContext context) {
return SimpleDialog(
return AlertDialog(
title: Text('${isBlocked ? 'Unblock' : 'Block'} this user?'),
children: <Widget>[
Padding(
padding: const EdgeInsets.only(
left: 24,
right: 12,
),
child: Text(
'Do you want to ${isBlocked ? 'unblock' : 'block'} ${item.by}'
' and ${isBlocked ? 'display' : 'hide'} '
'comments posted by this user?',
style: const TextStyle(
color: Colors.grey,
),
content: Text(
'Do you want to ${isBlocked ? 'unblock' : 'block'} ${item.by}'
' and ${isBlocked ? 'display' : 'hide'} '
'comments posted by this user?',
style: const TextStyle(
color: Colors.grey,
),
),
actions: <Widget>[
TextButton(
onPressed: () => Navigator.pop(context, false),
child: const Text(
'Cancel',
),
),
Padding(
padding: const EdgeInsets.only(
right: 12,
),
child: ButtonBar(
children: <Widget>[
TextButton(
onPressed: () => Navigator.pop(context, false),
child: const Text(
'Cancel',
style: TextStyle(
color: Colors.red,
),
),
),
ElevatedButton(
onPressed: () {
Navigator.pop(context, true);
},
style: ButtonStyle(
backgroundColor:
MaterialStateProperty.all(Colors.deepOrange),
),
child: const Text(
'Yes',
style: TextStyle(
fontWeight: FontWeight.bold,
color: Colors.white,
),
),
),
],
TextButton(
onPressed: () => Navigator.pop(context, true),
child: const Text(
'Yes',
),
),
],
@ -1239,9 +1186,6 @@ class _StoryScreenState extends State<StoryScreen> {
},
child: const Text(
'Cancel',
style: TextStyle(
color: Colors.red,
),
),
),
ElevatedButton(

View File

@ -0,0 +1,54 @@
import 'package:flutter/material.dart';
import 'package:hacki/config/locator.dart';
import 'package:hacki/repositories/repositories.dart';
import 'package:webview_flutter/webview_flutter.dart';
class WebViewScreen extends StatefulWidget {
const WebViewScreen({
super.key,
required this.url,
});
final String url;
@override
State<WebViewScreen> createState() => _WebViewScreenState();
}
class _WebViewScreenState extends State<WebViewScreen> {
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
backgroundColor: Theme.of(context).canvasColor,
title: Text(
humanize(widget.url),
style: const TextStyle(
fontSize: 12,
),
overflow: TextOverflow.ellipsis,
textAlign: TextAlign.center,
),
centerTitle: true,
),
body: WebView(
onWebViewCreated: (WebViewController controller) async {
final String? html = await locator.get<CacheRepository>().getHtml(
url: widget.url,
);
if (html != null) {
await controller.loadHtmlString(html);
}
},
),
);
}
static String humanize(String link) {
final String humanized = link
.replaceFirst(RegExp('https?://'), '')
.replaceFirst(RegExp(r'www\.'), '');
return humanized;
}
}

View File

@ -13,6 +13,7 @@ class LinkPreview extends StatefulWidget {
required this.link,
required this.story,
required this.showMetadata,
required this.offlineReading,
this.cache = const Duration(days: 30),
this.titleStyle,
this.bodyStyle,
@ -100,6 +101,7 @@ class LinkPreview extends StatefulWidget {
final List<BoxShadow>? boxShadow;
final bool showMetadata;
final bool offlineReading;
@override
_LinkPreviewState createState() => _LinkPreviewState();
@ -138,12 +140,14 @@ class _LinkPreviewState extends State<LinkPreview> {
_url,
story: widget.story,
cache: widget.cache,
offlineReading: widget.offlineReading,
);
} else {
_info = await WebAnalyzer.getInfo(
null,
story: widget.story,
cache: widget.cache,
offlineReading: widget.offlineReading,
);
}

View File

@ -5,6 +5,7 @@ import 'dart:io';
import 'package:collection/collection.dart' show IterableExtension;
import 'package:fast_gbk/fast_gbk.dart';
import 'package:flutter/foundation.dart';
import 'package:hacki/config/locator.dart';
import 'package:hacki/extensions/extensions.dart';
import 'package:hacki/models/models.dart';
import 'package:hacki/repositories/repositories.dart';
@ -112,6 +113,7 @@ class WebAnalyzer {
required Story story,
Duration cache = const Duration(hours: 24),
bool multimedia = true,
required bool offlineReading,
}) async {
InfoBase? info = getInfoFromCache(url);
@ -129,6 +131,27 @@ class WebAnalyzer {
return info;
}
if (offlineReading) {
int index = 0;
Comment? comment;
while (comment == null && index < story.kids.length) {
comment = await locator
.get<CacheRepository>()
.getCachedComment(id: story.kids.elementAt(index));
index++;
}
info = WebInfo(
title: story.title,
description: comment != null ? '${comment.by}: ${comment.text}' : null,
)
.._shouldRetry = false
.._timeout = DateTime.now();
cacheMap[url] = info;
return info;
}
try {
info = await _getInfoByIsolate(
url: url,
@ -140,11 +163,16 @@ class WebAnalyzer {
info._timeout = DateTime.now().add(cache);
cacheMap[url] = info;
}
} catch (e) {
//locator.get<Logger>().log(Level.error, e);
}
return info;
return info;
} catch (e) {
return WebInfo(
title: story.title,
description: story.text,
)
.._shouldRetry = true
.._timeout = DateTime.now();
}
}
static Future<InfoBase?> _getInfo(String url, bool? multimedia) async {
@ -256,20 +284,8 @@ class WebAnalyzer {
static Future<String?> _fetchInfoFromStoryId(List<int> kids) async {
if (kids.isEmpty) return null;
final Comment? comment = await StoriesRepository()
.fetchCommentBy(id: kids.first)
.catchError((Object err) async {
int index = 0;
Comment? comment;
while (comment == null && index < kids.length) {
comment =
await CacheRepository().getCachedComment(id: kids.elementAt(index));
index++;
}
return comment;
});
final Comment? comment =
await StoriesRepository().fetchCommentBy(id: kids.first);
return comment != null ? '${comment.by}: ${comment.text}' : null;
}

View File

@ -1,5 +1,7 @@
import 'package:flutter/material.dart';
import 'package:flutter_bloc/flutter_bloc.dart';
import 'package:flutter_fadein/flutter_fadein.dart';
import 'package:hacki/blocs/blocs.dart';
import 'package:hacki/config/constants.dart';
import 'package:hacki/models/models.dart';
import 'package:hacki/screens/widgets/widgets.dart';
@ -43,6 +45,7 @@ class StoryTile extends StatelessWidget {
child: LinkPreview(
story: story,
link: story.url,
offlineReading: context.read<StoriesBloc>().state.offlineReading,
placeholderWidget: FadeIn(
child: SizedBox(
height: height,

View File

@ -2,12 +2,37 @@ import 'dart:io';
import 'package:flutter/material.dart';
import 'package:flutter_inappwebview/flutter_inappwebview.dart';
import 'package:hacki/config/locator.dart';
import 'package:hacki/main.dart';
import 'package:hacki/repositories/repositories.dart';
import 'package:hacki/screens/screens.dart' show WebViewScreen;
import 'package:url_launcher/url_launcher.dart';
abstract class LinkUtil {
static final ChromeSafariBrowser _browser = ChromeSafariBrowser();
static void launch(String link, {bool useReader = false}) {
static void launch(
String link, {
bool useReader = false,
bool offlineReading = false,
}) {
if (offlineReading) {
locator
.get<CacheRepository>()
.hasCachedWebPage(url: link)
.then((bool cached) {
if (cached) {
HackiApp.navigatorKey.currentState?.push<void>(
MaterialPageRoute<void>(
builder: (BuildContext context) => WebViewScreen(url: link),
),
);
}
});
return;
}
Uri rinseLink(String link) {
final RegExp regex = RegExp(r'\)|].*$');
if (!link.contains('en.wikipedia.org') && link.contains(regex)) {

View File

@ -99,20 +99,6 @@ packages:
url: "https://pub.dartlang.org"
source: hosted
version: "1.3.1"
chewie:
dependency: transitive
description:
name: chewie
url: "https://pub.dartlang.org"
source: hosted
version: "1.3.3"
chewie_audio:
dependency: transitive
description:
name: chewie_audio
url: "https://pub.dartlang.org"
source: hosted
version: "1.3.0"
clipboard:
dependency: "direct main"
description:
@ -204,13 +190,6 @@ packages:
url: "https://pub.dartlang.org"
source: hosted
version: "0.17.1"
cupertino_icons:
dependency: transitive
description:
name: cupertino_icons
url: "https://pub.dartlang.org"
source: hosted
version: "1.0.4"
dbus:
dependency: transitive
description:
@ -316,13 +295,6 @@ packages:
url: "https://pub.dartlang.org"
source: hosted
version: "2.0.0+1"
flutter_html:
dependency: "direct main"
description:
name: flutter_html
url: "https://pub.dartlang.org"
source: hosted
version: "2.2.1"
flutter_inappwebview:
dependency: "direct main"
description:
@ -330,13 +302,6 @@ packages:
url: "https://pub.dartlang.org"
source: hosted
version: "5.4.3+7"
flutter_layout_grid:
dependency: transitive
description:
name: flutter_layout_grid
url: "https://pub.dartlang.org"
source: hosted
version: "1.0.6"
flutter_linkify:
dependency: "direct main"
description:
@ -365,13 +330,6 @@ packages:
url: "https://pub.dartlang.org"
source: hosted
version: "5.0.0"
flutter_math_fork:
dependency: transitive
description:
name: flutter_math_fork
url: "https://pub.dartlang.org"
source: hosted
version: "0.5.0"
flutter_secure_storage:
dependency: "direct main"
description:
@ -428,13 +386,6 @@ packages:
url: "https://pub.dartlang.org"
source: hosted
version: "1.2.1"
flutter_svg:
dependency: transitive
description:
name: flutter_svg
url: "https://pub.dartlang.org"
source: hosted
version: "0.23.0+1"
flutter_test:
dependency: "direct dev"
description: flutter
@ -620,13 +571,6 @@ packages:
url: "https://pub.dartlang.org"
source: hosted
version: "2.0.1"
numerus:
dependency: transitive
description:
name: numerus
url: "https://pub.dartlang.org"
source: hosted
version: "1.1.1"
octo_image:
dependency: transitive
description:
@ -648,20 +592,6 @@ packages:
url: "https://pub.dartlang.org"
source: hosted
version: "1.8.1"
path_drawing:
dependency: transitive
description:
name: path_drawing
url: "https://pub.dartlang.org"
source: hosted
version: "0.5.1+1"
path_parsing:
dependency: transitive
description:
name: path_parsing
url: "https://pub.dartlang.org"
source: hosted
version: "0.2.1"
path_provider:
dependency: "direct main"
description:
@ -1152,41 +1082,6 @@ packages:
url: "https://pub.dartlang.org"
source: hosted
version: "2.4.0"
video_player:
dependency: transitive
description:
name: video_player
url: "https://pub.dartlang.org"
source: hosted
version: "2.4.2"
video_player_android:
dependency: transitive
description:
name: video_player_android
url: "https://pub.dartlang.org"
source: hosted
version: "2.3.3"
video_player_avfoundation:
dependency: transitive
description:
name: video_player_avfoundation
url: "https://pub.dartlang.org"
source: hosted
version: "2.3.4"
video_player_platform_interface:
dependency: transitive
description:
name: video_player_platform_interface
url: "https://pub.dartlang.org"
source: hosted
version: "5.1.2"
video_player_web:
dependency: transitive
description:
name: video_player_web
url: "https://pub.dartlang.org"
source: hosted
version: "2.0.10"
vm_service:
dependency: transitive
description:
@ -1251,12 +1146,12 @@ packages:
source: hosted
version: "1.0.1"
webview_flutter:
dependency: transitive
dependency: "direct main"
description:
name: webview_flutter
url: "https://pub.dartlang.org"
source: hosted
version: "2.8.0"
version: "3.0.4"
webview_flutter_android:
dependency: transitive
description:

View File

@ -1,6 +1,6 @@
name: hacki
description: A Hacker News reader.
version: 0.2.18+57
version: 0.2.19+60
publish_to: none
environment:
@ -28,7 +28,6 @@ dependencies:
flutter_cache_manager: ^3.3.0
flutter_fadein: ^2.0.0
flutter_feather_icons: 2.0.0+1
flutter_html: ^2.2.1
flutter_inappwebview: ^5.4.3+4
flutter_linkify: ^5.0.2
flutter_local_notifications: ^9.5.0
@ -68,6 +67,7 @@ dependencies:
universal_platform: ^1.0.0+1
url_launcher: ^6.1.3
wakelock: ^0.6.1+2
webview_flutter: ^3.0.4
workmanager: ^0.5.0
dev_dependencies: