38 Commits

Author SHA1 Message Date
29fd576109 Avoid using git_bindings except for clone/pull/push/ls-remote
Lets use dart-git instead. It seems stable enough, and I'm soon going to
be moving away from libgit2 to go-git anyway. This is the first step towards
that.
2023-12-12 19:59:54 +01:00
7fd1c99287 Use Provider's context.read/watch
Instead of the legacy Provider.of. Less scope of bugs this way and the
code is so much nicer to read.
2023-12-06 08:20:40 +01:00
657721adc6 Update dart-git and stop using the Result class
Instead we're going to move back to standard exceptions.

Using a custom Result class has created far far more problems
- The Stacktraces aren't always right
- Sometimes one forgets to check the Result error
- All other exception throwing code needing to be converted to Results
- Non idiomatic Dart code

I think it's better to just go back to exceptions. They have their
problems, but overall, I think it's a better approach.
2023-11-24 14:03:30 +01:00
ea8cd35261 Fix deprecated methods 2023-02-09 16:00:29 +01:00
6d453ee62a Rename app_localization_context to l10n
It's easier to enter and this file now contains far more things
2022-11-27 17:52:03 +01:00
6f2ce4a6b5 Port more uses of LocaleKeys to new translation system 2022-11-27 17:42:26 +01:00
ae9228f65e Use super.key
Makes the code a bit more readable.
2022-08-25 11:32:25 +02:00
dee2374aef Fix assert 2022-06-22 13:20:40 +02:00
ae09b1ba12 Add unawaited or explicitly wait
There are still many cases (over 60) to fix.
2022-02-23 15:15:49 +01:00
c56da852b6 Add more specialized snackbox functions
It's easier to control how the errors look this way.
2022-01-27 10:26:23 +01:00
c3e7a9ffd7 lint: Add avoid_void_async 2021-11-17 18:10:59 +01:00
40f994aaa9 Move SyncAttempt to its own file
It needs to be serialized to disk
2021-10-26 22:38:20 +02:00
7e0a77ace3 Fix many cases of 'avoid-ignoring-return-values'
Now that dart-code-metrics has been updated, this lint can finally be
used. So far all of these are false positives, in the sense that I don't
care about their return values.

I wish there was an easy way of marking functions whose return value
shouldn't ever be ignored.
2021-09-27 18:39:18 +02:00
c4ef1f569b Use flutter_lint
Instead of picking lint values. This way I don't need to routinely
looking at extra lints to enable.
2021-09-21 15:42:13 +02:00
33a731a3d7 Add reuse licensing to files in lib 2021-09-15 13:06:43 +02:00
455844e9b0 LocaleKeys++ 2021-08-26 13:54:39 +02:00
07763226df Stop using deprecated packages 2021-07-29 14:39:23 +02:00
30b9a850d4 Move utils file to utils folder 2021-06-04 18:59:58 +02:00
53fd080214 Migrate some widgets to null safety 2021-05-17 23:03:52 +02:00
d008f0d982 First version of dart migrate
Most of the files haven't been migrated. Lets work on this bit by bit
2021-04-10 22:18:35 +02:00
39644f42f3 Update all deps for null safety
Also fix new compile errors
2021-04-10 21:56:18 +02:00
b97d8507f3 Fix missed words in rename 2021-02-15 22:45:39 +01:00
aa805f80c5 SyncButton: Show a different icon on error 2020-10-23 15:35:46 +02:00
43206219da Merge AppState into Repository
The 'AppState' was more of a Repository state, and it's easier if it
lives inside the Repository class.
2020-10-23 02:01:45 +02:00
770394a8f9 Rename StateContainer to Respository 2020-10-23 01:38:47 +02:00
984fc6864e Make all remaining strings translatable 2020-09-08 23:01:39 +02:00
9d00fdac06 Use import_sorter
flutter pub run import_sorter:main --no-comments

The code feels much cleaner
2020-07-24 12:43:28 +02:00
5d7f616c6e const++ 2020-07-21 10:46:03 +02:00
5af4edda18 SyncButton: Always show the number of changes
Even when pulling/pushing
2020-06-10 12:57:53 +02:00
8636021952 SyncButton: Show number of unpushed changes
Related to #123
2020-05-01 11:09:40 +02:00
28ef551805 On sync error: Show the error a bit better
Do not show 'GitException: error'. We do not need to expose that it was
an exception.
2020-04-02 17:29:03 +02:00
a5fcb19d70 SyncButton: Use cloud download/upload instead of arrows 2020-03-30 13:04:28 +02:00
577b73ff3c SyncButton: Seperate pulling and pushing
This way we also refresh the view after the pulling, as we don't need to
wait for a push for that.
2020-03-30 13:00:28 +02:00
3a3ec76529 StateContainer: Use Provider
This way we can avoid listening for changes in many places.
2020-02-11 19:10:34 +01:00
0c0fd17543 syncNotes: Catch the exception outside the StateContainer
The StateContainer doesn't have access to the snackbar.
2020-02-09 16:32:35 +01:00
a759ad4a23 Combine showSnackbar code
It's annoying to always have to remember to call it. We had forgotten in
one place and that resulted in a lot of noise.
2020-01-27 19:02:44 +01:00
7b40cbf65f SyncButton: Disable if no connectivity 2019-12-26 20:56:30 +01:00
bc9e308971 Move SyncButton to its own file 2019-12-26 20:56:30 +01:00