Combine showSnackbar code

It's annoying to always have to remember to call it. We had forgotten in
one place and that resulted in a lot of noise.
This commit is contained in:
Vishesh Handa
2020-01-27 19:02:44 +01:00
parent bd0819c5be
commit a759ad4a23
3 changed files with 4 additions and 15 deletions

@ -1,9 +1,7 @@
import 'package:flutter/material.dart';
import 'package:git_bindings/git_bindings.dart';
import 'package:gitjournal/core/note.dart';
import 'package:gitjournal/core/notes_folder.dart';
import 'package:gitjournal/utils.dart';
import 'package:gitjournal/screens/journal_editor.dart';
import 'package:gitjournal/screens/journal_browsing.dart';
import 'package:gitjournal/state_container.dart';
@ -78,11 +76,7 @@ class JournalListingScreen extends StatelessWidget {
void _syncRepo(BuildContext context) async {
final container = StateContainer.of(context);
try {
await container.syncNotes();
} on GitException catch (exp) {
showSnackbar(context, exp.cause);
}
await container.syncNotes();
}
void _newPost(BuildContext context) {

@ -9,6 +9,7 @@ import 'package:gitjournal/appstate.dart';
import 'package:gitjournal/core/note.dart';
import 'package:gitjournal/core/notes_folder.dart';
import 'package:gitjournal/core/git_repo.dart';
import 'package:gitjournal/utils.dart';
import 'package:path/path.dart' as p;
import 'package:shared_preferences/shared_preferences.dart';
import 'package:flutter_crashlytics/flutter_crashlytics.dart';
@ -111,7 +112,7 @@ class StateContainerState extends State<StateContainer> {
if (shouldLogGitException(e)) {
await FlutterCrashlytics().logException(e, stacktrace);
}
rethrow;
showSnackbar(context, e.cause);
}
await _loadNotes();
}

@ -3,9 +3,7 @@ import 'dart:async';
import 'package:flutter/material.dart';
import 'package:connectivity/connectivity.dart';
import 'package:git_bindings/git_bindings.dart';
import 'package:gitjournal/appstate.dart';
import 'package:gitjournal/utils.dart';
import 'package:gitjournal/state_container.dart';
class SyncButton extends StatefulWidget {
@ -62,11 +60,7 @@ class _SyncButtonState extends State<SyncButton> {
void _syncRepo() async {
final container = StateContainer.of(context);
try {
await container.syncNotes();
} on GitException catch (exp) {
showSnackbar(context, exp.cause);
}
await container.syncNotes();
}
IconData _syncStatusIcon() {