flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-06-28 18:03:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Decrease app boot time

Browse Source 
We don't need to wait for all the futures, and some can be re-used.
This commit is contained in:
Vishesh Handa
2019-06-02 17:29:50 +02:00
parent e389829e2c
commit fb2cbbf3ce
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/app.dart
View File

@ -45,13 +45,13 @@ class JournalApp extends StatelessWidget {
localGitRepoConfigured = true; localGitRepoConfigured = true;
await pref.setBool("localGitRepoConfigured", localGitRepoConfigured); pref.setBool("localGitRepoConfigured", localGitRepoConfigured);
await pref.setString("localGitRepoPath", localGitRepoPath); pref.setString("localGitRepoPath", localGitRepoPath);
} }
var dir = await getGitBaseDirectory(); var dir = await getGitBaseDirectory();
await Settings.instance.load(); Settings.instance.load(pref);
runApp(StateContainer( runApp(StateContainer(
localGitRepoConfigured: localGitRepoConfigured, localGitRepoConfigured: localGitRepoConfigured,

3
lib/settings.dart
View File

@ -7,8 +7,7 @@ class Settings {
Settings._internal(); Settings._internal();
static Settings get instance => _singleton; static Settings get instance => _singleton;
Future load() async { void load(SharedPreferences pref) {
var pref = await SharedPreferences.getInstance();
gitAuthor = pref.getString("gitAuthor") ?? gitAuthor; gitAuthor = pref.getString("gitAuthor") ?? gitAuthor;
gitAuthorEmail = pref.getString("gitAuthorEmail") ?? gitAuthorEmail; gitAuthorEmail = pref.getString("gitAuthorEmail") ?? gitAuthorEmail;
} }