From fb2cbbf3cedb225cc8799490281f07a14e6d26de Mon Sep 17 00:00:00 2001 From: Vishesh Handa Date: Sun, 2 Jun 2019 17:29:50 +0200 Subject: [PATCH] Decrease app boot time We don't need to wait for all the futures, and some can be re-used. --- lib/app.dart | 6 +++--- lib/settings.dart | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/app.dart b/lib/app.dart index be65992a..a942dbc5 100644 --- a/lib/app.dart +++ b/lib/app.dart @@ -45,13 +45,13 @@ class JournalApp extends StatelessWidget { localGitRepoConfigured = true; - await pref.setBool("localGitRepoConfigured", localGitRepoConfigured); - await pref.setString("localGitRepoPath", localGitRepoPath); + pref.setBool("localGitRepoConfigured", localGitRepoConfigured); + pref.setString("localGitRepoPath", localGitRepoPath); } var dir = await getGitBaseDirectory(); - await Settings.instance.load(); + Settings.instance.load(pref); runApp(StateContainer( localGitRepoConfigured: localGitRepoConfigured, diff --git a/lib/settings.dart b/lib/settings.dart index 5b220e4c..24b5b143 100644 --- a/lib/settings.dart +++ b/lib/settings.dart @@ -7,8 +7,7 @@ class Settings { Settings._internal(); static Settings get instance => _singleton; - Future load() async { - var pref = await SharedPreferences.getInstance(); + void load(SharedPreferences pref) { gitAuthor = pref.getString("gitAuthor") ?? gitAuthor; gitAuthorEmail = pref.getString("gitAuthorEmail") ?? gitAuthorEmail; }