flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-07-02 04:47:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

FlattenedNotesFolderTest: Fix it

Browse Source 
Occasionally the random number generator would generate the same number
and we wouldn't check if the file existed.

Also, we were accidentally creating all the notes in the root dir, so
this test was a bit useless.
This commit is contained in:
Vishesh Handa
2020-08-15 13:22:05 +02:00
parent 88328902f4
commit d5ce4e1110
1 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
test/flattened_notes_folder_test.dart
View File

@ -9,6 +9,20 @@ import 'package:gitjournal/core/note.dart';
import 'package:gitjournal/core/notes_folder_fs.dart';
void main() {
var random = Random(DateTime.now().millisecondsSinceEpoch);
String _getRandomFilePath(String basePath) {
while (true) {
var filePath = p.join(basePath, "${random.nextInt(1000)}.md");
if (File(filePath).existsSync()) {
filePath = null;
continue;
}
return filePath;
}
}
group('Flattened Notes Folder Test', () {
Directory tempDir;
NotesFolderFS rootFolder;
@ -18,12 +32,8 @@ void main() {
rootFolder = NotesFolderFS(null, tempDir.path);
var random = Random();
for (var i = 0; i < 3; i++) {
var note = Note(
rootFolder,
p.join(rootFolder.folderPath, "${random.nextInt(1000)}.md"),
);
var note = Note(rootFolder, _getRandomFilePath(rootFolder.folderPath));
note.modified = DateTime(2020, 1, 10 + (i * 2));
note.body = "$i";
await note.save();
@ -37,7 +47,7 @@ void main() {
for (var i = 0; i < 2; i++) {
var note = Note(
sub1Folder,
p.join(rootFolder.folderPath, "${random.nextInt(1000)}.md"),
_getRandomFilePath(sub1Folder.folderPath),
);
note.modified = DateTime(2020, 1, 10 + (i * 2));
note.body = "sub1-$i";
@ -48,7 +58,7 @@ void main() {
for (var i = 0; i < 2; i++) {
var note = Note(
sub2Folder,
p.join(rootFolder.folderPath, "${random.nextInt(1000)}.md"),
_getRandomFilePath(sub2Folder.folderPath),
);
note.modified = DateTime(2020, 1, 10 + (i * 2));
note.body = "sub2-$i";
@ -60,7 +70,7 @@ void main() {
for (var i = 0; i < 2; i++) {
var note = Note(
p1Folder,
p.join(rootFolder.folderPath, "${random.nextInt(1000)}.md"),
_getRandomFilePath(p1Folder.folderPath),
);
note.modified = DateTime(2020, 1, 10 + (i * 2));
note.body = "p1-$i";