flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-07-02 04:47:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

NoteEditing: Make sure we report exceptions on save

Browse Source 
We don't want to silently ignore these.
This commit is contained in:
Vishesh Handa
2020-06-10 13:18:48 +02:00
parent 8a00fd1df6
commit 5714642e15
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/screens/note_editor.dart
View File

@ -10,6 +10,7 @@ import 'package:gitjournal/editors/journal_editor.dart';
import 'package:gitjournal/editors/markdown_editor.dart';
import 'package:gitjournal/editors/raw_editor.dart';
import 'package:gitjournal/editors/checklist_editor.dart';
import 'package:gitjournal/error_reporting.dart';
import 'package:gitjournal/state_container.dart';
import 'package:gitjournal/utils/logger.dart';
import 'package:gitjournal/widgets/folder_selection_dialog.dart';
@ -303,12 +304,18 @@ class NoteEditorState extends State<NoteEditor> {
return false;
}
void _saveNote(Note note) {
void _saveNote(Note note) async {
if (!_noteModified(note)) return;
Log.d("Note modified - saving");
var stateContainer = Provider.of<StateContainer>(context, listen: false);
_isNewNote ? stateContainer.addNote(note) : stateContainer.updateNote(note);
try {
var stateContainer = Provider.of<StateContainer>(context, listen: false);
_isNewNote
? await stateContainer.addNote(note)
: await stateContainer.updateNote(note);
} catch (e, stackTrace) {
logException(e, stackTrace);
}
}
Note _getNoteFromEditor() {

4
lib/state_container.dart
View File

@ -256,7 +256,7 @@ class StateContainer with ChangeNotifier {
});
}
void addNote(Note note) async {
Future<void> addNote(Note note) async {
logEvent(Event.NoteAdded);
note.parent.add(note);
@ -310,7 +310,7 @@ class StateContainer with ChangeNotifier {
});
}
void updateNote(Note note) async {
Future<void> updateNote(Note note) async {
logEvent(Event.NoteUpdated);
note.updateModified();