flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-06-26 08:36:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Split NoteEditor types into its own file

Browse Source 
NoteEditor still hasn't been migrated to null safety
This commit is contained in:
Vishesh Handa
2021-05-25 10:16:59 +02:00
parent d4a5467e23
commit 4632dc40b9
11 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/core/notes_folder_config.dart
View File

@ -8,9 +8,9 @@ import 'package:yaml_serializer/yaml_serializer.dart';
import 'package:gitjournal/core/notes_folder_fs.dart';
import 'package:gitjournal/core/sorting_mode.dart';
import 'package:gitjournal/editors/common_types.dart';
import 'package:gitjournal/folder_views/common.dart';
import 'package:gitjournal/folder_views/standard_view.dart';
import 'package:gitjournal/screens/note_editor.dart';
import 'package:gitjournal/settings.dart';
import 'package:gitjournal/utils/logger.dart';

1
lib/core/org_links_handler.dart
View File

@ -27,7 +27,6 @@ import 'package:path/path.dart';
import 'package:url_launcher/url_launcher.dart';
import 'package:gitjournal/core/note.dart';
import 'package:gitjournal/core/notes_folder_fs.dart';
import 'package:gitjournal/folder_views/common.dart';
import 'package:gitjournal/utils/link_resolver.dart';
import 'package:gitjournal/utils/logger.dart';

1
lib/editors/common_types.dart Normal file
View File

@ -0,0 +1 @@
enum EditorType { Markdown, Raw, Checklist, Journal, Org }

2
lib/main_autocomplete.dart
View File

@ -1,7 +1,5 @@
// @dart=2.9
import 'dart:ui';
import 'package:flutter/material.dart';
import 'package:gitjournal/editors/autocompletion_widget.dart';

1
lib/screens/folder_view.dart
View File

@ -13,6 +13,7 @@ import 'package:gitjournal/core/notes_folder.dart';
import 'package:gitjournal/core/notes_folder_fs.dart';
import 'package:gitjournal/core/sorted_notes_folder.dart';
import 'package:gitjournal/core/sorting_mode.dart';
import 'package:gitjournal/editors/common_types.dart';
import 'package:gitjournal/folder_views/common.dart';
import 'package:gitjournal/folder_views/standard_view.dart';
import 'package:gitjournal/repository.dart';

3
lib/screens/note_editor.dart
View File

@ -30,6 +30,7 @@ import 'package:gitjournal/core/note.dart';
import 'package:gitjournal/core/notes_folder.dart';
import 'package:gitjournal/core/notes_folder_fs.dart';
import 'package:gitjournal/editors/checklist_editor.dart';
import 'package:gitjournal/editors/common_types.dart';
import 'package:gitjournal/editors/journal_editor.dart';
import 'package:gitjournal/editors/markdown_editor.dart';
import 'package:gitjournal/editors/org_editor.dart';
@ -98,8 +99,6 @@ class NoteEditor extends StatefulWidget {
}
}
enum EditorType { Markdown, Raw, Checklist, Journal, Org }
class NoteEditorState extends State<NoteEditor> with WidgetsBindingObserver {
Note note;
EditorType editorType = EditorType.Markdown;

2
lib/settings.dart
View File

@ -27,8 +27,8 @@ import 'package:shared_preferences/shared_preferences.dart';
import 'package:uuid/uuid.dart';
import 'package:gitjournal/core/sorting_mode.dart';
import 'package:gitjournal/editors/common_types.dart';
import 'package:gitjournal/folder_views/common_types.dart';
import 'package:gitjournal/screens/note_editor.dart';
const DEFAULT_ID = "0";
const FOLDER_NAME_KEY = "remoteGitRepoPath";

2
lib/utils.dart
View File

@ -6,10 +6,10 @@ import 'package:provider/provider.dart';
import 'package:share/share.dart';
import 'package:gitjournal/core/notes_folder_fs.dart';
import 'package:gitjournal/screens/note_editor.dart';
import 'package:gitjournal/settings.dart';
import 'app.dart';
import 'core/note.dart';
import 'editors/common_types.dart';
import 'repository.dart';
import 'utils/logger.dart';

2
lib/widgets/new_note_nav_bar.dart
View File

@ -3,7 +3,7 @@ import 'package:flutter/material.dart';
import 'package:font_awesome_flutter/font_awesome_flutter.dart';
import 'package:function_types/function_types.dart';
import 'package:gitjournal/screens/note_editor.dart';
import 'package:gitjournal/editors/common_types.dart';
// FIXME: Remove note_editor import!!

2
lib/widgets/note_editor_selector.dart
View File

@ -22,7 +22,7 @@ import 'package:easy_localization/easy_localization.dart';
import 'package:font_awesome_flutter/font_awesome_flutter.dart';
import 'package:gitjournal/core/note.dart';
import 'package:gitjournal/screens/note_editor.dart';
import 'package:gitjournal/editors/common_types.dart';
class NoteEditorSelector extends StatelessWidget {
final EditorType currentEditor;

2
test/notes_folder_config_test.dart
View File

@ -6,9 +6,9 @@ import 'package:test/test.dart';
import 'package:gitjournal/core/notes_folder_config.dart';
import 'package:gitjournal/core/notes_folder_fs.dart';
import 'package:gitjournal/core/sorting_mode.dart';
import 'package:gitjournal/editors/common_types.dart';
import 'package:gitjournal/folder_views/common.dart';
import 'package:gitjournal/folder_views/standard_view.dart';
import 'package:gitjournal/screens/note_editor.dart';
import 'package:gitjournal/settings.dart';
void main() {