Add lots of listen: false when using Provider

Provider version 4 has an assert which fires if used incorrectly.

lib/editors/scaffold.dart

@@ -48,7 +48,7 @@ class _EditorScaffoldState extends State<EditorScaffold> {
   void _initStateWithContext() {
     if (!mounted) return;
 
-    var settings = Provider.of<Settings>(context);
+    var settings = Provider.of<Settings>(context, listen: false);
 
     setState(() {
       hideUIElements = settings.zenMode;
@@ -79,7 +79,7 @@ class _EditorScaffoldState extends State<EditorScaffold> {
   }
 
   void _editorChanged() {
-    var settings = Provider.of<Settings>(context);
+    var settings = Provider.of<Settings>(context, listen: false);
 
     if (settings.zenMode && !hideUIElements) {
       setState(() {
@@ -89,7 +89,7 @@ class _EditorScaffoldState extends State<EditorScaffold> {
   }
 
   void _switchMode() {
-    var settings = Provider.of<Settings>(context);
+    var settings = Provider.of<Settings>(context, listen: false);
 
     setState(() {
       editingMode = !editingMode;

lib/screens/folder_listing.dart

@@ -157,7 +157,8 @@ class CreateFolderButton extends StatelessWidget {
         );
         if (folderName is String) {
           var container = Provider.of<StateContainer>(context, listen: false);
-          final notesFolder = Provider.of<NotesFolderFS>(context);
+          final notesFolder =
+              Provider.of<NotesFolderFS>(context, listen: false);
 
           container.createFolder(notesFolder, folderName);
         }

lib/screens/folder_view.dart

@@ -163,13 +163,13 @@ class _FolderViewState extends State<FolderView> {
     NotesFolderFS fsFolder = folder.fsFolder;
     var isVirtualFolder = folder.name != folder.fsFolder.name;
     if (isVirtualFolder) {
-      var rootFolder = Provider.of<NotesFolderFS>(context);
+      var rootFolder = Provider.of<NotesFolderFS>(context, listen: false);
-      var settings = Provider.of<Settings>(context);
+      var settings = Provider.of<Settings>(context, listen: false);
 
       fsFolder = getFolderForEditor(settings, rootFolder, editorType);
     }
 
-    var settings = Provider.of<Settings>(context);
+    var settings = Provider.of<Settings>(context, listen: false);
 
     if (editorType == EditorType.Journal && settings.journalEditorSingleNote) {
       var note = await getTodayJournalEntry(fsFolder.rootFolder);

lib/screens/home_screen.dart

@@ -28,7 +28,7 @@ class _HomeScreenState extends State<HomeScreen> {
   void _initFolder() async {
     if (!mounted) return;
 
-    final rootFolder = Provider.of<NotesFolderFS>(context);
+    final rootFolder = Provider.of<NotesFolderFS>(context, listen: false);
     setState(() {
       notesFolder = FlattenedNotesFolder(
         rootFolder,

lib/screens/note_editor.dart

@@ -384,7 +384,7 @@ class NoteEditorState extends State<NoteEditor> {
   void _editTagsSelected(Note _note) async {
     Log.i("Note Tags: ${_note.tags}");
 
-    final rootFolder = Provider.of<NotesFolderFS>(context);
+    final rootFolder = Provider.of<NotesFolderFS>(context, listen: false);
     var allTags = rootFolder.getNoteTagsRecursively();
     Log.i("All Tags: $allTags");
 

lib/screens/onboarding_screens.dart

@@ -111,7 +111,7 @@ class OnBoardingScreenState extends State<OnBoardingScreen> {
   }
 
   void _finish() {
-    var appSettings = Provider.of<AppSettings>(context);
+    var appSettings = Provider.of<AppSettings>(context, listen: false);
     appSettings.onBoardingCompleted = true;
     appSettings.save();
 

lib/screens/settings_git_remote.dart

@@ -79,7 +79,7 @@ class _GitRemoteSettingsScreenState extends State<GitRemoteSettingsScreen> {
         ),
         RedButton(
           text: tr('settings.ssh.reset'),
-          onPressed: () => _resetGitHost(context),
+          onPressed: () => _resetGitHost(),
         ),
       ],
       crossAxisAlignment: CrossAxisAlignment.start,
@@ -122,7 +122,7 @@ class _GitRemoteSettingsScreenState extends State<GitRemoteSettingsScreen> {
     });
   }
 
-  void _resetGitHost(BuildContext context) async {
+  void _resetGitHost() async {
     var ok = await showDialog(
       context: context,
       builder: (_) => HostChangeConfirmationDialog(),
@@ -131,7 +131,7 @@ class _GitRemoteSettingsScreenState extends State<GitRemoteSettingsScreen> {
       return;
     }
 
-    var stateContainer = Provider.of<StateContainer>(context);
+    var stateContainer = Provider.of<StateContainer>(context, listen: false);
     var gitDir = stateContainer.appState.gitBaseDirectory;
 
     // Figure out the next available folder

lib/screens/tag_listing.dart

@@ -69,7 +69,7 @@ class TagListingScreen extends StatelessWidget {
       onTap: () {
         var route = MaterialPageRoute(
           builder: (context) {
-            var rootFolder = Provider.of<NotesFolderFS>(context);
+            var rootFolder = Provider.of<NotesFolderFS>(context, listen: false);
             var folder = FlattenedNotesFolder(
               rootFolder,
               filter: (Note n) =>

lib/setup/screens.dart

@@ -468,7 +468,7 @@ class GitHostSetupScreenState extends State<GitHostSetupScreen> {
       gitCloneErrorMessage = "";
     });
 
-    var stateContainer = Provider.of<StateContainer>(context);
+    var stateContainer = Provider.of<StateContainer>(context, listen: false);
     var basePath = stateContainer.appState.gitBaseDirectory;
 
     // Just in case it was half cloned because of an error

lib/widgets/purchase_widget.dart

@@ -223,7 +223,7 @@ class _PurchaseWidgetState extends State<PurchaseWidget> {
   }
 
   void _deliverProduct(SubscriptionStatus status) {
-    var appSettings = Provider.of<AppSettings>(context);
+    var appSettings = Provider.of<AppSettings>(context, listen: false);
     appSettings.proMode = status.isPro;
     appSettings.proExpirationDate = status.expiryDate.toIso8601String();
     appSettings.save();