flutter/GitJournal
1
0
Fork 0
mirror of https://github.com/GitJournal/GitJournal.git synced 2025-06-29 18:38:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add lots of listen: false when using Provider

Browse Source 
Provider version 4 has an assert which fires if used incorrectly.
This commit is contained in:
Vishesh Handa
2020-09-28 00:09:14 +02:00
parent c20f8314c1
commit 43269bbe53
10 changed files with 17 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/editors/scaffold.dart
View File

@ -48,7 +48,7 @@ class _EditorScaffoldState extends State<EditorScaffold> {
void _initStateWithContext() {
if (!mounted) return;
var settings = Provider.of<Settings>(context);
var settings = Provider.of<Settings>(context, listen: false);
setState(() {
hideUIElements = settings.zenMode;
@ -79,7 +79,7 @@ class _EditorScaffoldState extends State<EditorScaffold> {
}
void _editorChanged() {
var settings = Provider.of<Settings>(context);
var settings = Provider.of<Settings>(context, listen: false);
if (settings.zenMode && !hideUIElements) {
setState(() {
@ -89,7 +89,7 @@ class _EditorScaffoldState extends State<EditorScaffold> {
}
void _switchMode() {
var settings = Provider.of<Settings>(context);
var settings = Provider.of<Settings>(context, listen: false);
setState(() {
editingMode = !editingMode;

3
lib/screens/folder_listing.dart
View File

@ -157,7 +157,8 @@ class CreateFolderButton extends StatelessWidget {
);
if (folderName is String) {
var container = Provider.of<StateContainer>(context, listen: false);
final notesFolder = Provider.of<NotesFolderFS>(context);
final notesFolder =
Provider.of<NotesFolderFS>(context, listen: false);
container.createFolder(notesFolder, folderName);
}

6
lib/screens/folder_view.dart
View File

@ -163,13 +163,13 @@ class _FolderViewState extends State<FolderView> {
NotesFolderFS fsFolder = folder.fsFolder;
var isVirtualFolder = folder.name != folder.fsFolder.name;
if (isVirtualFolder) {
var rootFolder = Provider.of<NotesFolderFS>(context);
var settings = Provider.of<Settings>(context);
var rootFolder = Provider.of<NotesFolderFS>(context, listen: false);
var settings = Provider.of<Settings>(context, listen: false);
fsFolder = getFolderForEditor(settings, rootFolder, editorType);
}
var settings = Provider.of<Settings>(context);
var settings = Provider.of<Settings>(context, listen: false);
if (editorType == EditorType.Journal && settings.journalEditorSingleNote) {
var note = await getTodayJournalEntry(fsFolder.rootFolder);

2
lib/screens/home_screen.dart
View File

@ -28,7 +28,7 @@ class _HomeScreenState extends State<HomeScreen> {
void _initFolder() async {
if (!mounted) return;
final rootFolder = Provider.of<NotesFolderFS>(context);
final rootFolder = Provider.of<NotesFolderFS>(context, listen: false);
setState(() {
notesFolder = FlattenedNotesFolder(
rootFolder,

2
lib/screens/note_editor.dart
View File

@ -384,7 +384,7 @@ class NoteEditorState extends State<NoteEditor> {
void _editTagsSelected(Note _note) async {
Log.i("Note Tags: ${_note.tags}");
final rootFolder = Provider.of<NotesFolderFS>(context);
final rootFolder = Provider.of<NotesFolderFS>(context, listen: false);
var allTags = rootFolder.getNoteTagsRecursively();
Log.i("All Tags: $allTags");

2
lib/screens/onboarding_screens.dart
View File

@ -111,7 +111,7 @@ class OnBoardingScreenState extends State<OnBoardingScreen> {
}
void _finish() {
var appSettings = Provider.of<AppSettings>(context);
var appSettings = Provider.of<AppSettings>(context, listen: false);
appSettings.onBoardingCompleted = true;
appSettings.save();

6
lib/screens/settings_git_remote.dart
View File

@ -79,7 +79,7 @@ class _GitRemoteSettingsScreenState extends State<GitRemoteSettingsScreen> {
),
RedButton(
text: tr('settings.ssh.reset'),
onPressed: () => _resetGitHost(context),
onPressed: () => _resetGitHost(),
),
],
crossAxisAlignment: CrossAxisAlignment.start,
@ -122,7 +122,7 @@ class _GitRemoteSettingsScreenState extends State<GitRemoteSettingsScreen> {
});
}
void _resetGitHost(BuildContext context) async {
void _resetGitHost() async {
var ok = await showDialog(
context: context,
builder: (_) => HostChangeConfirmationDialog(),
@ -131,7 +131,7 @@ class _GitRemoteSettingsScreenState extends State<GitRemoteSettingsScreen> {
return;
}
var stateContainer = Provider.of<StateContainer>(context);
var stateContainer = Provider.of<StateContainer>(context, listen: false);
var gitDir = stateContainer.appState.gitBaseDirectory;
// Figure out the next available folder

2
lib/screens/tag_listing.dart
View File

@ -69,7 +69,7 @@ class TagListingScreen extends StatelessWidget {
onTap: () {
var route = MaterialPageRoute(
builder: (context) {
var rootFolder = Provider.of<NotesFolderFS>(context);
var rootFolder = Provider.of<NotesFolderFS>(context, listen: false);
var folder = FlattenedNotesFolder(
rootFolder,
filter: (Note n) =>

2
lib/setup/screens.dart
View File

@ -468,7 +468,7 @@ class GitHostSetupScreenState extends State<GitHostSetupScreen> {
gitCloneErrorMessage = "";
});
var stateContainer = Provider.of<StateContainer>(context);
var stateContainer = Provider.of<StateContainer>(context, listen: false);
var basePath = stateContainer.appState.gitBaseDirectory;
// Just in case it was half cloned because of an error

2
lib/widgets/purchase_widget.dart
View File

@ -223,7 +223,7 @@ class _PurchaseWidgetState extends State<PurchaseWidget> {
}
void _deliverProduct(SubscriptionStatus status) {
var appSettings = Provider.of<AppSettings>(context);
var appSettings = Provider.of<AppSettings>(context, listen: false);
appSettings.proMode = status.isPro;
appSettings.proExpirationDate = status.expiryDate.toIso8601String();
appSettings.save();