mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-06-26 05:47:26 +08:00
3df3a985a4
This patch changes the remote target to use the remote packet size to build QTDP packets, and to check if there is enough room for the packet. I changed the function to raise an error if the packet is too small, instead of aborting gdb (through xsnprintf). It isn't clear if gdb will be in a consistent state with respect to the stub after this, since it's possible that some packets will be sent but not others, and there could be an incomplete tracepoint on the stub. The char array used to build the packets is changed to a gdb::char_vector and sized with the result from get_remote_packet_size. When checking if the buffer is large enough to hold the tracepoint condition agent expression, the length of the expression is multiplied by two, since it is encoded with two hex digits per expression byte. For simplicity, I assume that the result won't overflow, which can happen for very long condition expressions. gdb/ChangeLog: 2018-08-06 Pedro Franco de Carvalho <pedromfc@linux.ibm.com> * remote.c (remote_target::download_tracepoint): Remove BUF_SIZE. Replace array buf with gdb::char_vector buf, of size get_remote_packet_size (). Replace references to buf and BUF_SIZE to buf.data () and buf.size (). Replace strcpy, strcat and xsnprintf with snprintf. Raise errors if the buffer is too small.
README for GNU development tools This directory contains various GNU compilers, assemblers, linkers, debuggers, etc., plus their support routines, definitions, and documentation. If you are receiving this as part of a GDB release, see the file gdb/README. If with a binutils release, see binutils/README; if with a libg++ release, see libg++/README, etc. That'll give you info about this package -- supported targets, how to use it, how to report bugs, etc. It is now possible to automatically configure and build a variety of tools with one command. To build all of the tools contained herein, run the ``configure'' script here, e.g.: ./configure make To install them (by default in /usr/local/bin, /usr/local/lib, etc), then do: make install (If the configure script can't determine your type of computer, give it the name as an argument, for instance ``./configure sun4''. You can use the script ``config.sub'' to test whether a name is recognized; if it is, config.sub translates it to a triplet specifying CPU, vendor, and OS.) If you have more than one compiler on your system, it is often best to explicitly set CC in the environment before running configure, and to also set CC when running make. For example (assuming sh/bash/ksh): CC=gcc ./configure make A similar example using csh: setenv CC gcc ./configure make Much of the code and documentation enclosed is copyright by the Free Software Foundation, Inc. See the file COPYING or COPYING.LIB in the various directories, for a description of the GNU General Public License terms under which you can copy the files. REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info on where and how to report problems.