espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-08-02 02:35:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

PR27719, lang_mark_undefineds trashes memory

Browse Source 
It's not enough to test that the output is ELF before casting
bfd_link_hash_entry to elf_link_hash_entry.  Some ELF targets (d30v,
dlx, pj, s12z, xgate) use the generic linker support in bfd/linker.c
and thus their symbols are of type generic_link_hash_entry.

Not all of the places this patch touches can result in wrong accesses,
but I thought it worth ensuring that all occurrences of
elf_link_hash_entry in ld/ were obviously correct.

	PR 27719
	* ldlang.c (lang_mark_undefineds, undef_start_stop): Test that
	the symbol hash table is the correct type before accessing
	elf_link_hash_entry symbols.
	* plugin.c (is_visible_from_outside): Likewise.
	* emultempl/armelf.em (ld${EMULATION_NAME}_finish): Likewise.
	* emultempl/solaris2.em (elf_solaris2_before_allocation): Likewise.
This commit is contained in:
Alan Modra
2021-04-11 23:34:21 +09:30
parent e601909a32
commit fc304b8891
5 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
ld/ChangeLog
View File

@ -1,3 +1,13 @@
2021-04-12 Alan Modra <amodra@gmail.com>
PR 27719
* ldlang.c (lang_mark_undefineds, undef_start_stop): Test that
the symbol hash table is the correct type before accessing
elf_link_hash_entry symbols.
* plugin.c (is_visible_from_outside): Likewise.
* emultempl/armelf.em (ld${EMULATION_NAME}_finish): Likewise.
* emultempl/solaris2.em (elf_solaris2_before_allocation): Likewise.
2021-04-09 Alan Modra <amodra@gmail.com>
* testsuite/ld-powerpc/inlinepcrel-1.d: Update expected output.

2
ld/emultempl/armelf.em
View File

@ -463,7 +463,7 @@ gld${EMULATION_NAME}_finish (void)
{
struct elf_link_hash_entry * eh;
if (!entry_symbol.name)
if (!entry_symbol.name || !is_elf_hash_table (link_info.hash))
return;
h = bfd_link_hash_lookup (link_info.hash, entry_symbol.name,

3
ld/emultempl/solaris2.em
View File

@ -64,7 +64,8 @@ elf_solaris2_before_allocation (void)
const char **sym;
/* Do this for both executables and shared objects. */
if (!bfd_link_relocatable (&link_info))
if (!bfd_link_relocatable (&link_info)
&& is_elf_hash_table (link_info.hash))
{
for (sym = global_syms; *sym != NULL; sym++)
{

4
ld/ldlang.c
View File

@ -4009,7 +4009,7 @@ lang_mark_undefineds (void)
{
ldlang_undef_chain_list_type *ptr;
if (bfd_get_flavour (link_info.output_bfd) == bfd_target_elf_flavour)
if (is_elf_hash_table (link_info.hash))
for (ptr = ldlang_undef_chain_list_head; ptr != NULL; ptr = ptr->next)
{
struct elf_link_hash_entry *h = (struct elf_link_hash_entry *)
@ -6822,7 +6822,7 @@ undef_start_stop (struct bfd_link_hash_entry *h)
}
h->type = bfd_link_hash_undefined;
h->u.undef.abfd = NULL;
if (bfd_get_flavour (link_info.output_bfd) == bfd_target_elf_flavour)
if (is_elf_hash_table (link_info.hash))
{
const struct elf_backend_data *bed;
struct elf_link_hash_entry *eh = (struct elf_link_hash_entry *) h;

2
ld/plugin.c
View File

@ -636,7 +636,7 @@ is_visible_from_outside (struct ld_plugin_symbol *lsym,
blhe->root.string))
return false;
/* Only ELF symbols really have visibility. */
if (bfd_get_flavour (link_info.output_bfd) == bfd_target_elf_flavour)
if (is_elf_hash_table (link_info.hash))
{
struct elf_link_hash_entry *el = (struct elf_link_hash_entry *)blhe;
int vis = ELF_ST_VISIBILITY (el->other);