espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-23 03:29:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdb/testsuite: fix failure in gdb.base/step-over-no-symbols.exp

Browse Source 
This test fails on my machine:

    p /x $pc^M
    $2 = 0x55555555514e^M
    (gdb) PASS: gdb.base/step-over-no-symbols.exp: displaced=off: get after PC
    FAIL: gdb.base/step-over-no-symbols.exp: displaced=off: advanced

This is due to the check added in 5f0e2eb79e6b ("GDB/testsuite: Fix a
catastrophic step-over-no-symbols.exp failure"), that makes sure the PC
values are integer.  As documented in the TCL doc [1], "string is
integer" returns 1 if the string is a valid 32-bit integer format.  The
PC values are greater than 32 bits, so are not recognized as integers by
that test.

    % string is integer -strict 0x55555555
    1
    % string is integer -strict 0x555555555
    0

Replace the "string is integer" test with a regexp one, that verifies
the PC is a hex value.

[1] https://www.tcl.tk/man/tcl/TclCmd/string.htm#M21

gdb/testsuite/ChangeLog:

	* gdb.base/step-over-no-symbols.exp (test_step_over): Replace
	integer format test with regexp.

Change-Id: I71f8197e7b52e97b4901980544a8d1072aabd362
This commit is contained in:
Simon Marchi
2020-11-02 16:35:47 -05:00
parent 257e02d836
commit f468977aac
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2020-11-02 Simon Marchi <simon.marchi@polymtl.ca>
* gdb.base/step-over-no-symbols.exp (test_step_over): Replace
integer format test with regexp.
2020-11-02 Gary Benson <gbenson@redhat.com>
* gdb.base/print-file-var.exp (test): Separate compiler and

4
gdb/testsuite/gdb.base/step-over-no-symbols.exp
View File

@ -78,8 +78,8 @@ proc test_step_over { displaced } {
set after_addr [get_pc "get after PC"]
gdb_assert {{[string is integer -strict $before_addr] \
&& [string is integer -strict $after_addr] \
gdb_assert {{[regexp "^${hex}$" $before_addr] \
&& [regexp "^${hex}$" $after_addr] \
&& $before_addr != $after_addr}} "advanced"
}