espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-19 17:18:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdb/riscv: fix creating breakpoints at invalid addresses

Browse Source 
To allow breakpoints to be created at invalid addresses,
target_read_code is used instead of read_code.  This was fixed in
commit:

  commit c01660c625766e848195285cc20581b9ed7ecfe2
  Date:   Wed Apr 17 00:31:43 2019 +0100

      gdb/riscv: Allow breakpoints to be created at invalid addresses

Unfortunately, the call to read_code was left in by mistake.  The
result is that GDB will fail when trying to create the breakpoint,
rather than when trying to install the breakpoint (as is the case with
other targets).

This commit fixes this mistake and removes the offending call to
read_code.

gdb/ChangeLog:

	* riscv-tdep.c (riscv_breakpoint_kind_from_pc): Remove call to
	read_code.
This commit is contained in:
Changbin Du
2021-03-25 11:02:23 +00:00
committed by Andrew Burgess
parent efa30ac3c5
commit d3cbca38df
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2021-03-24 Changbin Du <changbin.du@gmail.com>
* riscv-tdep.c (riscv_breakpoint_kind_from_pc): Remove call to
read_code.
2021-03-24 Simon Marchi <simon.marchi@polymtl.ca>
* target.h (current_top_target): Remove, make callers use the

1
gdb/riscv-tdep.c
View File

@ -706,7 +706,6 @@ riscv_breakpoint_kind_from_pc (struct gdbarch *gdbarch, CORE_ADDR *pcptr)
user. */
if (target_read_code (*pcptr, buf, 1) == -1)
buf[0] = 0;
read_code (*pcptr, buf, 1);
}
if (riscv_debug_breakpoints)