espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-08-05 21:50:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

x86: Properly check invalid relocation against protected symbol

Browse Source 
Only check invalid relocation against protected symbol defined in shared
object.

bfd/

	PR ld/29377
	* elf32-i386.c (elf_i386_scan_relocs): Only check invalid
	relocation against protected symbol defined in shared object.
	* elf64-x86-64.c (elf_x86_64_scan_relocs): Likewise.

ld/

	PR ld/29377
	* testsuite/ld-elf/linux-x86.exp: Run PR ld/29377 tests.
	* testsuite/ld-elf/pr29377a.c: New file.
	* testsuite/ld-elf/pr29377b.c: Likewise.
This commit is contained in:
H.J. Lu
2022-07-18 11:44:32 -07:00
parent b87062aade
commit bd0736124c
5 changed files with 35 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bfd/elf32-i386.c
View File

@ -1811,6 +1811,8 @@ elf_i386_scan_relocs (bfd *abfd,
if (h->pointer_equality_needed
&& h->type == STT_FUNC
&& eh->def_protected
&& !SYMBOL_DEFINED_NON_SHARED_P (h)
&& h->def_dynamic
&& elf_has_indirect_extern_access (h->root.u.def.section->owner))
{
/* Disallow non-canonical reference to canonical

2
bfd/elf64-x86-64.c
View File

@ -2254,6 +2254,8 @@ elf_x86_64_scan_relocs (bfd *abfd, struct bfd_link_info *info,
if (h->pointer_equality_needed
&& h->type == STT_FUNC
&& eh->def_protected
&& !SYMBOL_DEFINED_NON_SHARED_P (h)
&& h->def_dynamic
&& elf_has_indirect_extern_access (h->root.u.def.section->owner))
{
/* Disallow non-canonical reference to canonical

16
ld/testsuite/ld-elf/linux-x86.exp
View File

@ -134,6 +134,22 @@ run_cc_link_tests [list \
{{readelf {--dyn-syms -W} pr28158.rd} {nm -D pr28158.nd}} \
"pr28158" \
] \
[list \
"Build pr29377.o" \
"-r -Wl,-z,noexecstack" \
"" \
{pr29377a.c indirect-extern-access.S} \
{} \
"pr29377.o" \
] \
[list \
"Build pr29377" \
"$NOPIE_LDFLAGS tmpdir/pr29377.o" \
"-fPIC" \
{pr29377b.c} \
{} \
"pr29377" \
] \
]
run_ld_link_exec_tests [list \

5
ld/testsuite/ld-elf/pr29377a.c Normal file
View File

@ -0,0 +1,5 @@
__attribute__ ((visibility ("protected")))
void
foo (void)
{
}

10
ld/testsuite/ld-elf/pr29377b.c Normal file
View File

@ -0,0 +1,10 @@
extern void foo (void);
void (*foo_p) (void);
int
main ()
{
foo_p = foo;
return 0;
}