gdb: make use of skip_to_space and skip_spaces

Some late feedback on this commit:

  commit 037d7135de575c9e0c20e9158c105979bfee339c
  Date:   Mon Nov 16 11:36:56 2020 +0000

      gdb: improve command completion for 'print', 'x', and 'display'

Suggested making use of the skip_to_space and skip_spaces helper
functions.  There should be no user visible changes after this commit.

gdb/ChangeLog:

	* printcmd.c (skip_over_slash_fmt): Make use of skip_to_space and
	skip_spaces.
This commit is contained in:
Andrew Burgess
2020-11-19 10:09:42 +00:00
parent 6266b411ce
commit b3ff61f815
2 changed files with 7 additions and 4 deletions

View File

@ -1,3 +1,8 @@
2020-11-19 Andrew Burgess <andrew.burgess@embecosm.com>
* printcmd.c (skip_over_slash_fmt): Make use of skip_to_space and
skip_spaces.
2020-11-18 Keith Seitz <keiths@redhat.com>
* linux-tdep.c (dump_note_entry_p): Return true instead of

View File

@ -1261,8 +1261,7 @@ skip_over_slash_fmt (completion_tracker &tracker, const char **args)
if (ISALNUM (text[1]) || ISSPACE (text[1]))
{
/* Skip over the actual format specification. */
while (*text != '\0' && !ISSPACE (*text))
++text;
text = skip_to_space (text);
if (*text == '\0')
{
@ -1272,8 +1271,7 @@ skip_over_slash_fmt (completion_tracker &tracker, const char **args)
else
{
in_fmt = false;
while (ISSPACE (*text))
++text;
text = skip_spaces (text);
}
}
else if (text[1] == '\0')