Use ordinary calling convention for clean_restart

clean_restart accepts a single optional argument.  Rather than using
{args} and handling the argument by hand, change it to use Tcl's own
argument-checking.
This commit is contained in:
Tom Tromey
2023-01-25 09:25:36 -07:00
parent 3efac389d8
commit 6b9276b7e6
2 changed files with 6 additions and 16 deletions

View File

@ -7437,20 +7437,16 @@ proc build_executable { testname executable {sources ""} {options {debug}} } {
}
# Starts fresh GDB binary and loads an optional executable into GDB.
# Usage: clean_restart [executable]
# Usage: clean_restart [EXECUTABLE]
# EXECUTABLE is the basename of the binary.
# Return -1 if starting gdb or loading the executable failed.
proc clean_restart { args } {
proc clean_restart {{executable ""}} {
global srcdir
global subdir
global errcnt
global warncnt
if { [llength $args] > 1 } {
error "bad number of args: [llength $args]"
}
gdb_exit
# This is a clean restart, so reset error and warning count.
@ -7470,8 +7466,7 @@ proc clean_restart { args } {
gdb_reinitialize_dir $srcdir/$subdir
if { [llength $args] >= 1 } {
set executable [lindex $args 0]
if {$executable != ""} {
set binfile [standard_output_file ${executable}]
return [gdb_load ${binfile}]
}

View File

@ -1008,20 +1008,16 @@ proc mi_run_with_cli {args} {
}
# Starts fresh GDB binary and loads an optional executable into GDB.
# Usage: mi_clean_restart [executable]
# Usage: mi_clean_restart [EXECUTABLE]
# EXECUTABLE is the basename of the binary.
# Return -1 if starting gdb or loading the executable failed.
proc mi_clean_restart { args } {
proc mi_clean_restart {{executable ""}} {
global srcdir
global subdir
global errcnt
global warncnt
if { [llength $args] > 1 } {
error "bad number of args: [llength $args]"
}
gdb_exit
# This is a clean restart, so reset error and warning count.
@ -1034,8 +1030,7 @@ proc mi_clean_restart { args } {
mi_gdb_reinitialize_dir $srcdir/$subdir
if { [llength $args] >= 1 } {
set executable [lindex $args 0]
if {$executable != ""} {
set binfile [standard_output_file ${executable}]
return [mi_gdb_load ${binfile}]
}