espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-07-04 20:37:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix error in file_and_directory patch

Browse Source 
In my earlier C++-ization patch for file_and_directory, I introduced
an error:

-  if (strcmp (fnd.name, "<unknown>") != 0)
+  if (fnd.is_unknown ())

This change inverted the sense of the test, which causes failures with
.debug_names.

This patch fixes the bug.  Regression tested on x86-64 Fedora 34.  I
also tested it using the AdaCore internal test suite, with
.debug_names -- this was failing before, and now it works.
This commit is contained in:
Tom Tromey
2021-12-08 12:52:34 -07:00
parent 2988a36005
commit 621f8c42d3
1 changed files with 1 additions and 1 deletions

2
gdb/dwarf2/read.c

@ -3008,7 +3008,7 @@ dw2_get_file_names_reader (const struct die_reader_specs *reader,
file_and_directory &fnd = find_file_and_directory (comp_unit_die, cu);
int offset = 0;
if (fnd.is_unknown ())
if (!fnd.is_unknown ())
++offset;
else if (lh == nullptr)
return;