espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-12-19 01:19:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdb/amd-dbgapi: add assert in require_forward_progress

Browse Source 
I didn't have a problem in this area, but it seems to me that this
pre-condition should always hold.  We should only disable forward
progress requirement if the target says it's ok to do so.  Otherwise, we
could get in a situation where we wait for events from amd-dbgapi, which
will never arrive, because amd-dbgapi didn't actually resume things.

Change-Id: Ifc49f55c7874924b7c47888b8391a07a01d960fc
Approved-by: Lancelot Six <lancelot.six@amd.com>
This commit is contained in:
Simon Marchi
2025-06-09 12:08:58 -04:00
parent a421b077b2
commit 5ac1c64c04
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/amd-dbgapi-target.c
View File

@@ -450,6 +450,12 @@ static void
require_forward_progress (ptid_t ptid, process_stratum_target *proc_target,
bool require)
{
/* If we try to disable forward progress requirement but the target expects
resumed threads to be committed to the target, we could wait for events
that will never arrive. */
if (!require)
gdb_assert (!proc_target->commit_resumed_state);
for (inferior *inf : all_inferiors (proc_target))
{
if (ptid != minus_one_ptid && inf->pid != ptid.pid ())