espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-25 04:49:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

[gdb/testsuite] Fix unbalanced braces in gdb.tui/new-layout.exp

Browse Source 
On SLE-11 with tcl version 8.5, we run into:
...
UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to \
  invalid command name: }
ERROR: Couldn't send tui new-layout example src 1} to GDB.
...

Apparently tcl 8.6 is more forgiving about unbalanced braces.

Expose the unbalanced braces on tcl 8.6 by temporarily wrapping the
test-case in:
...
proc do_this { args } {
    uplevel 1 {*}$args
}

do_this {
  ...
}
...
and escape them using a backslash.

Tested on x86_64-linux.

gdb/testsuite/ChangeLog:

2020-09-16  Tom de Vries  <tdevries@suse.de>

	PR testsuite/26618
	* gdb.tui/new-layout.exp: Escape unbalanced braces.
This commit is contained in:
Tom de Vries
2020-09-16 10:57:17 +02:00
parent c1229f84a4
commit 4d91ddd342
2 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2020-09-16 Tom de Vries <tdevries@suse.de>
PR testsuite/26618
* gdb.tui/new-layout.exp: Escape unbalanced braces.
2020-09-15 Tom Tromey <tromey@adacore.com>
PR rust/26197:

12
gdb/testsuite/gdb.tui/new-layout.exp
View File

@ -42,12 +42,12 @@ gdb_test "tui new-layout example src 1 src 1" \
"Window \"src\" seen twice in layout"
gdb_test "tui new-layout example src 1" \
"New layout does not contain the \"cmd\" window"
gdb_test "tui new-layout example src 1}" \
"Extra '}' in layout specification"
gdb_test "tui new-layout example {src 1} 1}" \
"Extra '}' in layout specification"
gdb_test "tui new-layout example {src 1" \
"Missing '}' in layout specification"
gdb_test "tui new-layout example src 1\}" \
"Extra '\}' in layout specification"
gdb_test "tui new-layout example {src 1} 1\}" \
"Extra '\}' in layout specification"
gdb_test "tui new-layout example \{src 1" \
"Missing '\}' in layout specification"
gdb_test_no_output "tui new-layout example asm 1 status 0 cmd 1"