* frame.c (find_frame_sal): Initialize sal->pspace field from frame

data.
	* stack.c (set_last_displayed_sal): Validate that PSPACE is not NULL.

testuite:
	* gdb.base/break-inline.exp: New file.
	* gdb.base/break-inline.c: New file.
This commit is contained in:
Aleksandar Ristovski
2012-02-15 19:27:59 +00:00
parent 3af2590d3e
commit 4cb6da1cdd
6 changed files with 75 additions and 0 deletions

View File

@ -1,3 +1,9 @@
2012-02-15 Aleksandar Ristovski <aristovski@qnx.com>
* frame.c (find_frame_sal): Initialize sal->pspace field from frame
data.
* stack.c (set_last_displayed_sal): Validate that PSPACE is not NULL.
2012-02-15 Tom Tromey <tromey@redhat.com>
PR gdb/12659:

View File

@ -2096,6 +2096,8 @@ find_frame_sal (struct frame_info *frame, struct symtab_and_line *sal)
we can't do much better. */
sal->pc = get_frame_pc (frame);
sal->pspace = get_frame_program_space (frame);
return;
}

View File

@ -909,6 +909,11 @@ set_last_displayed_sal (int valid, struct program_space *pspace,
last_displayed_addr = addr;
last_displayed_symtab = symtab;
last_displayed_line = line;
if (valid && pspace == NULL)
{
warning (_("Trying to set NULL pspace."));
clear_last_displayed_sal ();
}
}
/* Forget the last sal we displayed. */

View File

@ -1,3 +1,8 @@
2012-02-15 Aleksandar Ristovski <aristovski@qnx.com>
* gdb.base/break-inline.exp: New file.
* gdb.base/break-inline.c: New file.
2012-02-15 Tom Tromey <tromey@redhat.com>
* gdb.base/pc-fp.exp: Add "info register" tests.

View File

@ -0,0 +1,32 @@
/* This testcase is part of GDB, the GNU debugger.
Copyright (C) 2012 Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
static int g;
static inline void
foo (void)
{
g = 42;
}
int
main (int argc, char *argv[])
{
foo ();
return g;
}

View File

@ -0,0 +1,25 @@
# Copyright (C) 2012 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
if { [prepare_for_testing break-inline.exp "break-inline" {} {debug nowarnings optimize=-O2}] } {
return -1
}
gdb_test "start" "Temporary breakpoint.*foo().*"
# Now test 'break' with no arguments.
gdb_test "break" "Breakpoint.*"