espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-23 19:50:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix aarch64 ftrace JIT condition testcase

Browse Source 
This patch fixes the following failure:
FAIL: gdb.trace/trace-condition.exp: ftrace: -(21 << 1) == -42: check 10
frames were collected.

This was due to aarch64_emit_sub using the wrong order in its operands, so the
operation would end up being 42 - 0 rather than 0 - 42.

This patch also fixes the order of aarch64_emit_add for clarity.

The test case for emit_sub is fixed so that the proper order of
the operands is needed for the test to pass.

Tested on aarch64-native-extended-gdbserver.

Note: trace-condition.exp was broken a bit so I had to modify it to run
the test. A fix is coming for that in another patch.

gdb/gdbserver/ChangeLog:

	* linux-aarch64-low.c (aarch64_emit_add): Switch x1 and x0.
	(aarch64_emit_sub): Likewise.

gdb/testsuite/ChangeLog:

	* gdb.trace/trace-condition.exp (foreach): Fix emit_sub testcase.
This commit is contained in:
Antoine Tremblay
2016-04-13 09:40:00 -04:00
parent 3a00c80277
commit 45e3745ed0
4 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/gdbserver/ChangeLog
View File

@ -1,3 +1,8 @@
2016-04-13 Antoine Tremblay <antoine.tremblay@ericsson.com>
* linux-aarch64-low.c (aarch64_emit_add): Switch x1 and x0.
(aarch64_emit_sub): Likewise.
2016-04-12 Pedro Alves <palves@redhat.com>
* utils.c (prepare_to_throw_exception): Delete.

4
gdb/gdbserver/linux-aarch64-low.c
View File

@ -2258,7 +2258,7 @@ aarch64_emit_add (void)
uint32_t *p = buf;
p += emit_pop (p, x1);
p += emit_add (p, x0, x0, register_operand (x1));
p += emit_add (p, x0, x1, register_operand (x0));
emit_ops_insns (buf, p - buf);
}
@ -2272,7 +2272,7 @@ aarch64_emit_sub (void)
uint32_t *p = buf;
p += emit_pop (p, x1);
p += emit_sub (p, x0, x0, register_operand (x1));
p += emit_sub (p, x0, x1, register_operand (x0));
emit_ops_insns (buf, p - buf);
}

4
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,7 @@
2016-04-13 Antoine Tremblay <antoine.tremblay@ericsson.com>
* gdb.trace/trace-condition.exp (foreach): Fix emit_sub testcase.
2016-04-13 Markus Metzger <markus.t.metzger@intel.com>
* gdb.btrace/instruction_history.c (loop): Add declaration.

2
gdb/testsuite/gdb.trace/trace-condition.exp
View File

@ -138,7 +138,7 @@ foreach trace_command { "trace" "ftrace" } {
# Test various operations to cover as many opcodes as possible.
test_tracepoints $trace_command "21 + 21 == 42" 10
test_tracepoints $trace_command "21 - 21 == 0" 10
test_tracepoints $trace_command "42 - 21 == 21" 10
test_tracepoints $trace_command "21 * 2 == 42" 10
test_tracepoints $trace_command "21 << 1 == 42" 10
test_tracepoints $trace_command "42 >> 1 == 21" 10