Fix gdb.base/structs2.exp with Clang

gdb.base/structs2.exp fails to run with Clang, because of:

 gdb compile failed, /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.base/structs2.c:16:14: warning:
       implicit conversion from 'int' to 'signed char' changes value from 130 to
       -126 [-Wconstant-conversion]
   param_reg (130, 120, 33000, 32000);
   ~~~~~~~~~  ^~~
 /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.base/structs2.c:16:24: warning:
       implicit conversion from 'int' to 'short' changes value from 33000 to
       -32536 [-Wconstant-conversion]
   param_reg (130, 120, 33000, 32000);
   ~~~~~~~~~            ^~~~~
 2 warnings generated.

		 === gdb Summary ===

 # of untested testcases         1

Fix it by passing actual negative numbers.

gdb/testsuite/ChangeLog:

	* gdb.base/structs2.c (main): Adjust second parem_reg call to
	explicitly write negative numbers.
	* gdb.base/structs2.exp: Adjust expected output.
This commit is contained in:
Pedro Alves
2020-07-02 19:32:40 +01:00
parent bf90c83acc
commit 3c8ea5be24
3 changed files with 8 additions and 2 deletions

View File

@ -1,3 +1,9 @@
2020-07-03 Pedro Alves <palves@redhat.com>
* gdb.base/structs2.c (main): Adjust second parem_reg call to
explicitly write negative numbers.
* gdb.base/structs2.exp: Adjust expected output.
2020-07-03 Pedro Alves <palves@redhat.com>
* gdb.base/charset.c (init_string): Change all char parameters to

View File

@ -13,7 +13,7 @@ main ()
bkpt = 0;
param_reg (120, 130, 32000, 33000);
param_reg (130, 120, 33000, 32000);
param_reg (-120, 130, -32000, 33000);
return 0;
}

View File

@ -49,5 +49,5 @@ if [test_compiler_info gcc-3-*] {
setup_xfail hppa*-* gcc/15860
}
gdb_test "continue" \
".*pr_char=-126.*pr_uchar=120.*pr_short=-32536.*pr_ushort=32000.*bkpt = 1.*" \
".*pr_char=-120.*pr_uchar=130.*pr_short=-32000.*pr_ushort=33000.*bkpt = 1.*" \
"structs2 continue2"