espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-08-06 06:45:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove two initialization functions

Browse Source 
I noticed a couple of initialization functions that aren't really
needed, and that currently require explicit calls in gdb_init.  This
patch removes these functions, simplifying gdb a little.

Regression tested on x86-64 Fedora 34.
This commit is contained in:
Tom Tromey
2022-06-19 14:59:32 -06:00
parent d7c8330389
commit 37163dcf1a
3 changed files with 8 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/cli/cli-cmds.c
View File

@ -76,7 +76,7 @@ static void filter_sals (std::vector<symtab_and_line> &);
/* See cli-cmds.h. */
unsigned int max_user_call_depth;
unsigned int max_user_call_depth = 1024;
/* Define all cmd_list_elements. */
@ -2105,12 +2105,6 @@ filter_sals (std::vector<symtab_and_line> &sals)
sals.erase (from, sals.end ());
}
void
init_cmd_lists (void)
{
max_user_call_depth = 1024;
}
static void
show_info_verbose (struct ui_file *file, int from_tty,
struct cmd_list_element *c,

2
gdb/cli/cli-cmds.h
View File

@ -151,8 +151,6 @@ extern unsigned int max_user_call_depth;
/* Exported to gdb/top.c */
void init_cmd_lists (void);
int is_complete_command (struct cmd_list_element *cmd);
/* Exported to gdb/main.c */

23
gdb/top.c
View File

@ -2231,17 +2231,6 @@ show_startup_quiet (struct ui_file *file, int from_tty,
value);
}
static void
init_gdb_version_vars (void)
{
struct internalvar *major_version_var = create_internalvar ("_gdb_major");
struct internalvar *minor_version_var = create_internalvar ("_gdb_minor");
int vmajor = 0, vminor = 0, vrevision = 0;
sscanf (version, "%d.%d.%d", &vmajor, &vminor, &vrevision);
set_internalvar_integer (major_version_var, vmajor);
set_internalvar_integer (minor_version_var, vminor + (vrevision > 0));
}
static void
init_main (void)
{
@ -2405,6 +2394,13 @@ Usage: new-ui INTERPRETER TTY\n\
The first argument is the name of the interpreter to run.\n\
The second argument is the terminal the UI runs on."), &cmdlist);
set_cmd_completer (c, interpreter_completer);
struct internalvar *major_version_var = create_internalvar ("_gdb_major");
struct internalvar *minor_version_var = create_internalvar ("_gdb_minor");
int vmajor = 0, vminor = 0, vrevision = 0;
sscanf (version, "%d.%d.%d", &vmajor, &vminor, &vrevision);
set_internalvar_integer (major_version_var, vmajor);
set_internalvar_integer (minor_version_var, vminor + (vrevision > 0));
}
/* See top.h. */
@ -2423,8 +2419,6 @@ gdb_init ()
make_final_cleanup (do_chdir_cleanup, xstrdup (current_directory));
#endif
init_cmd_lists (); /* This needs to be done first. */
init_page_info ();
/* Here is where we call all the _initialize_foo routines. */
@ -2454,9 +2448,6 @@ gdb_init ()
during startup. */
set_language (language_c);
expected_language = current_language; /* Don't warn about the change. */
/* Create $_gdb_major and $_gdb_minor convenience variables. */
init_gdb_version_vars ();
}
void _initialize_top ();