algorithm/javascript-algorithms
1
0
Fork 0
mirror of https://github.com/trekhleb/javascript-algorithms.git synced 2025-07-07 01:44:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't treat 1 as prime number.

Browse Source
This commit is contained in:
Oleksii Trekhleb
2018-05-24 16:48:10 +03:00
parent f0ddaf243c
commit 5503cced48
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/algorithms/math/primality-test/__test__/trialDivision.test.js
View File

@ -4,7 +4,7 @@ import trialDivision from '../trialDivision';
* @param {function(n: number)} testFunction * @param {function(n: number)} testFunction
*/ */
function primalityTest(testFunction) { function primalityTest(testFunction) {
expect(testFunction(1)).toBeTruthy(); expect(testFunction(1)).toBeFalsy();
expect(testFunction(2)).toBeTruthy(); expect(testFunction(2)).toBeTruthy();
expect(testFunction(3)).toBeTruthy(); expect(testFunction(3)).toBeTruthy();
expect(testFunction(5)).toBeTruthy(); expect(testFunction(5)).toBeTruthy();

6
src/algorithms/math/primality-test/trialDivision.js
View File

@ -3,11 +3,11 @@
* @return {boolean} * @return {boolean}
*/ */
export default function trialDivision(number) { export default function trialDivision(number) {
if (number <= 0) { if (number <= 1) {
// If number is less then one then it isn't prime by definition. // If number is less than one then it isn't prime by definition.
return false; return false;
} else if (number <= 3) { } else if (number <= 3) {
// All numbers from 1 to 3 are prime. // All numbers from 2 to 3 are prime.
return true; return true;
} }