From 5503cced48e2d1411cbaf57cc65773def491dc7a Mon Sep 17 00:00:00 2001 From: Oleksii Trekhleb Date: Thu, 24 May 2018 16:48:10 +0300 Subject: [PATCH] Don't treat 1 as prime number. --- .../math/primality-test/__test__/trialDivision.test.js | 2 +- src/algorithms/math/primality-test/trialDivision.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/algorithms/math/primality-test/__test__/trialDivision.test.js b/src/algorithms/math/primality-test/__test__/trialDivision.test.js index 9e5b67ec..d4f54d47 100644 --- a/src/algorithms/math/primality-test/__test__/trialDivision.test.js +++ b/src/algorithms/math/primality-test/__test__/trialDivision.test.js @@ -4,7 +4,7 @@ import trialDivision from '../trialDivision'; * @param {function(n: number)} testFunction */ function primalityTest(testFunction) { - expect(testFunction(1)).toBeTruthy(); + expect(testFunction(1)).toBeFalsy(); expect(testFunction(2)).toBeTruthy(); expect(testFunction(3)).toBeTruthy(); expect(testFunction(5)).toBeTruthy(); diff --git a/src/algorithms/math/primality-test/trialDivision.js b/src/algorithms/math/primality-test/trialDivision.js index 79988e64..64e62472 100644 --- a/src/algorithms/math/primality-test/trialDivision.js +++ b/src/algorithms/math/primality-test/trialDivision.js @@ -3,11 +3,11 @@ * @return {boolean} */ export default function trialDivision(number) { - if (number <= 0) { - // If number is less then one then it isn't prime by definition. + if (number <= 1) { + // If number is less than one then it isn't prime by definition. return false; } else if (number <= 3) { - // All numbers from 1 to 3 are prime. + // All numbers from 2 to 3 are prime. return true; }